[boskid] [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Bugs that we just recently fixed in our development version, and will get to you in the next release.
Post Reply
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

[boskid] [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

1) Press Ctrl+Shift+E to open the prototype explorer
2) Click the <all> dropdown box and select any mod you want
3) Instant crash.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 1505
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by boskid »

Cannot reproduce.
Attachments
Factorio 1.1.34 2021-06-06 21-24-39.mp4
(3.1 MiB) Downloaded 25 times

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

That is... weird. :oops:
It happend 3 times in a row clicking a different mod each time. And now I can't reproduce it myself anymore (and the log is gone too *sigh*). I'll add a log if it pops up again.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

Hasn't happend again so far, but I found one of the original logs.
Attachments
prototype-gui-crash-log.log
(17.61 KiB) Downloaded 368 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

Happend again. Crash -> Restart -> Crash -> Restart -> Works fine.

Given the weird pattern I wouldn't be entirely suprised if it's somehow my hardware or my shitty internet...
Attachments
_autosave3.zip
(872.75 KiB) Downloaded 198 times
prototype-gui-crash-log-2.log
(17.76 KiB) Downloaded 101 times
factorio-dump-current.dmp
(609.33 KiB) Downloaded 100 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 1505
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by boskid »

Hm.. there are certain mods that are not available on the mod portal so i can not verify with exact set of mods.

This error is weird:

Code: Select all

  85.824 Error ModManager.hpp:51: No history for the given key: console.
Only occurence of word "console" in the source code is for the "console" font from the default fonts. Lines from the stack trace say it is literally crashing while trying to fill "fonts" category in the prototypes gui.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

I sent you the missing mods in a PM. Also while preparing that I got it again. Looks exactly like the other ones.

The only font related thing in my mods as far as I can see is in Screenshot Maker:

Code: Select all

data:extend{{
  type = "font",
  name = "er:selection-rectangle-label-font",
  from = "default-semibold",
  size = 32,
  }}
Attachments
factorio-dump-current.dmp
(624.78 KiB) Downloaded 109 times
factorio-current.log
(19.84 KiB) Downloaded 111 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

So, it definetly isn't a fluke. It's still happening every once in a while. But always resolves itself after a few restarts.

As it always happens after fetching the wiki mappings

Code: Select all

21.728 Info HttpSharedState.cpp:54: Downloading https://wiki.factorio.com/api.php?format=json&action=query&formatversion=2&prop=revisions&titles=Factorio%3AClass_to_page_mapping&rvprop=ids
I was suspecting it might be something network related. Dropped/corrupt packeges, timeout in the middle of the download or something. But I haven't found a way to reliably reproduce it yet.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

Updated to 1.1.35. No change. Still looks exactly the same and is elusive to reproduction attempts.
Attachments
factorio-dump-current.dmp
(628.19 KiB) Downloaded 130 times
factorio-current.log
(19.77 KiB) Downloaded 129 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

I think I might have found something. I've just managed to make it crash 8 times in a row (previous record was 3 or 4, usually 1 or 2) by changing a mods hash before every restart. All I did was add one letter to a comment in eradicators-core load-order.lua (a file that is loaded in all stages). (This is my dev instance, so all the mods are folder junctions, not zips).

Code: Select all

--[[

  asdfghijklm

  ]]
  1. Change mod hash.
  2. Start game
  3. Press continue to load last game
  4. Ctrl+Shift+E
  5. Click "base" in the mod selector
  6. Wait for the crash message
  7. Goto 1)
It seems to crash exactly once after each hash change and then works normally until the hash changes again. I don't have time right now to determine a minimal mod set to reproduce.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

Yep. I just reproduced it without any other mods except zz-bugest-template (attached) using the steps above. Just edit the comment in main.lua. I've attached the empty_map that I load just to be sure.
Attachments
zz-bugtest-template.7z
(828 Bytes) Downloaded 161 times
_empty_map.zip
(854.25 KiB) Downloaded 160 times
factorio-dump-current.dmp
(631 KiB) Downloaded 157 times
factorio-current.log
(15.46 KiB) Downloaded 90 times
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Rseding91
Factorio Staff
Factorio Staff
Posts: 11861
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [boskid] [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by Rseding91 »

Thanks for the report and for the detailed reproduction steps. It's now fixed for the next release.
If you want to get ahold of me I'm almost always on Discord.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5026
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [boskid] [1.1.34] Crash PrototypesHistoryTemplate<PrototypeHistory>::operator[]

Post by eradicator »

Rseding91 wrote:
Tue Jun 22, 2021 5:17 pm
Thanks for the report and for the detailed reproduction steps. It's now fixed for the next release.
Nice. So what was it in the end?
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Post Reply

Return to “Resolved for the next release”