[Request] event.onentitydamaged / event.onattack

[Choumiko]

I would like to propose 1 and/or 2 new events:
onentitydamaged : event contains the entity, the damage(amount/type) and the entity that caused the damage (if there is one)

onattack : contains unit group, engaging turrets (basicly the info the player already gets shown to the right of the toolbar when biters attack. I guess there's something like an event already in the factorio source for this

Possible use cases: buildings do certain things (e.g. spawn combat robots, stop/start trains, whatever is modable) when an entity in their area get's damaged.

I just got the idea for something like The Fat Controller: When being attacked, click a button and your camera switches to the attack. As i really like seeing those biters get killed but rarely am close enough

(quoted from https://forums.factorio.com/forum/vie ... =25&t=7507)
I'm sure there are loads of other uses

[L0771]

onentitydamaged : event contains the entity, the damage(amount/type) and the entity that caused the damage (if there is one)

I want add event.tick and event.playerindex if the entity that cause damage is a player (else nil), to continue with the same format of all others events.

[Rahjital]

I don't think the onattack event is possible since that's not how the game mechanics work. When biters get the order to attack, they can be kilometres away from your base, and the event getting triggered at that time wouldn't be very usefull. For turrets attacking biters, you could simply use event.onentitydamaged again.

A better thing would be event.onentityattacking, which would trigger whenever anything attacks. It's needed because weapons can have splash damage (rocket launcher, mines), create many projectiles at one (shotgun) or have other ways of damaging many entities (flamethrower), and because even projectiles that are guaranteed to hit (like laser bolts or worm spit) take some time to travel. It should contain the attacking entity, the target entity, a table of all projectiles and possibly damage value too.

I want add event.tick and event.playerindex if the entity that cause damage is a player (else nil), to continue with the same format of all others events.

You could use game.tick for time and loop through players characters to see if any of them is the event.damagedentity. Only events that actually concern players (and only players) have event.playerindex.

[Choumiko]

A better thing would be event.onentityattacking, which would trigger whenever anything attacks. It's needed because weapons can have splash damage (rocket launcher, mines), create many projectiles at one (shotgun) or have other ways of damaging many entities (flamethrower), and because even projectiles that are guaranteed to hit (like laser bolts or worm spit) take some time to travel. It should contain the attacking entity, the target entity, a table of all projectiles and possibly damage value too.

That's what i meant with " (basicly the info the player already gets shown to the right of the toolbar when biters attack. I guess there's something like an event already in the factorio source for this)" An event that gets triggered the first time the triangle thingy pops up, it already shows "X turrets engaged with the enemy, y objects being damaged" so a lot of the info is gathered already

event.tick makes sense i guess. As for playerindex, with multiplayer in development, maybe entities should have .isPlayer() or just .getplayerindex() simply returning nil if not a player? I haven't gotten into MP-safe modding yet, so no clue if this makes sense.

[Rahjital]

That's what i meant with " (basicly the info the player already gets shown to the right of the toolbar when biters attack. I guess there's something like an event already in the factorio source for this)" An event that gets triggered the first time the triangle thingy pops up, it already shows "X turrets engaged with the enemy, y objects being damaged" so a lot of the info is gathered already

I don't know how Factorio works, but those warning signs are most likely done simply by storing the last tick a turret shot or a player entity was damaged and displaying the warning based on that. Implementing such a thing is no hard thing and the code is probably too simple to have any event associated to it.

The onentityattacked event would have to fire every single time anything shoots/bites/spits/attacks to be useful, not simply whenever those triangles show up. Limiting it to show you a biter attack would be trivial to do in Lua, so there's no need to limit the event for that.

[Degraine]

I would like this as well. It'd be very handy for a certain application I have in mind.