Adding more methods to manipulate scripted achievements

[Gangsir]

Rseding91 asked me to post this here, so I'd like to request the following methods to manipulate achievements, if possible:

• LuaPlayer::disable_achievement() - Takes an achievement, and disables/fails it, showing the failed achievement icon, and preventing it from being unlocked through script or internal means, could be limited to just 'achievement' type or all types, either or.
• (Bonus) Add a way to revert the previous, something like LuaPlayer::enable_achievement()
• (Bonus) Add some way to read if an achievement is already earned by a player, something like an 'achievements' table for each player listing their achievements and status.

I'm sure most of these are done internally, but exposing it to modders for their own achievements would be great.

Thanks so much to whoever ends up implementing this, I'd really appreciate it.

[Bilka]

Some more bonus points:

• The order parameter, to determine the order of achievements in the achievement list
• The ability to add a description to achievements of the type "achievement" in the locale

[Rseding91]

Some more bonus points:

• The order parameter, to determine the order of achievements in the achievement list
• The ability to add a description to achievements of the type "achievement" in the locale

Unless I'm reading something wrong the order string is already used to order things in the achievements list. After the unlocked/locked status is accounted for.

[Bilka]

Unless I'm reading something wrong the order string is already used to order things in the achievements list. After the unlocked/locked status is accounted for.

I must have missed it when reading through the code, oops.

[nucleargen]

[*] The ability to add a description to achievements of the type "achievement" in the locale[/list]

i think this may be treated as bug, since all other achievements type has description.

[Rseding91]

I fixed the inability to set the name/description through the prototype for 0.16.

[eradicator]

Being a bit "paranoid" i'll voice my concerns: If LuaPlayer::disable_achievement() is actually implemented i think it should only work on achievements that the calling mod implements itself. Disabling other mods or vanilla achievements just invites "hardcore" focused mod authors to force their standards on everyone :P. And players would only notice this when it's already too late. Oh, on that issue...it'd be nice if there was some sort of warning message when an achivement is permanently failed (a simple text message would suffice).

Also LuaPlayer::enable_achievement() sounds weird... i'd like to hear an example for a situation where you can post-factum un-fail a condition for an achievement?

[Bilka]

Being a bit "paranoid" i'll voice my concerns: If LuaPlayer::disable_achievement() is actually implemented

No need to voice your concerns, this won't be implemented

[eradicator]

I'd still kinda like the ability to read the achivement status of a player.
Something like:
game.player.achivements = {'blabla' = true, 'foobar' = false}

[Bilka]

I'd still kinda like the ability to read the achivement status of a player.
Something like:
game.player.achivements = {'blabla' = true, 'foobar' = false}

I don't think that will happen since it's not deterministic

[Gangsir]

Bumping post per Bilka's request.