Trying to check type of energy_interface

[protocol_1903]

I'm trying to run the following code to check if a machine uses electricity, then change it to burner once that is done. It loads into Factorio but for whatever reason it isn't working. It is probably something wrong with the syntax, I'm new to LUA. I think its something with how I'm checking the source type.

Code: Select all

for _, machine in pairs(data.raw) do
  if machine.energy_source ~= nil then
    if machine.energy_source.type == "electric" then
      machine.energy_source = {
        type = "burner",
        effectivity = 0.5,
        fuel_inventory_size = 1
      }
    end
  end
end

[Pi-C]

I'm trying to run the following code to check if a machine uses electricity, then change it to burner once that is done. It loads into Factorio but for whatever reason it isn't working. It is probably something wrong with the syntax, I'm new to LUA. I think its something with how I'm checking the source type.

Your syntax is OK, but your data isn't.

Code: Select all

for _, machine in pairs(data.raw) do
	…
end

You don't want to check everything below data.raw, but only the prototypes of the type "assembling-machine". This should work:

Code: Select all

for _, machine in pairs(data.raw["assembling-machine"]) do
	…
end

By the way, I've always found it helpful for debugging to log the value of the loop variables. This would have shown you that you'd tried to operate on the list of prototype names, not the prototypes themselves.

[protocol_1903]

You don't want to check everything below data.raw, but only the prototypes of the type "assembling-machine".

I want to change every entity possible, not just every assembling machine.

By the way, I've always found it helpful for debugging to log the value of the loop variables. This would have shown you that you'd tried to operate on the list of prototype names, not the prototypes themselves.

How do you do that, and where do you access the log?

[Pi-C]

You don't want to check everything below data.raw, but only the prototypes of the type "assembling-machine".

I want to change every entity possible, not just every assembling machine.

This should do the trick:

Code: Select all

for t, types in pairs(data.raw) do
	for p, prototype in pairs(types) do
		log(string.format("p: %s\tprototype.type: %s\tprototype.energy_source: %s", p, p.type, serpent.line(prototype.energy_source)))	
		if prototype.energy_source and prototype.energy_source.type == "electric" then
			prototype.energy_source = {
				type = "burner",
			        effectivity = 0.5,
			        fuel_inventory_size = 1
			}
		end
	end
end

By the way, I've always found it helpful for debugging to log the value of the loop variables. This would have shown you that you'd tried to operate on the list of prototype names, not the prototypes themselves.

How do you do that, and where do you access the log?

I've added a logging instruction above. In case you wonder why I've logged just "prototype.type" instead of "prototype": prototype definitions may be huge, and if you loop over all entities in data.raw, the log file will grow so big that it is rather hard to read and, therefore, useless.

I'm using the stand-alone version of Factorio. There, the log file is factorio-current.log in the folder where I've unpacked the game. You can find more detailed info if you check the wiki for Application directory.

[protocol_1903]

Sorry for the late reply, but your advice worked! Thanks for the help! I used this to develop the Powerless mod.