[Solved, Thanks :)]Unexpected Symbol Near "}"

[Starfoth]

I'm trying to make a medikit mod, but the game won't let me. It keeps telling me I have an unexpected symbol near "}". Can someone help me? I just copied the code for fish and edited some things that I needed to edit

Code: Select all

{
    type = "capsule",
    name = "Medkit",
    icon = "Starfoth's_Simple_Medkit_Mod_0.13.0/graphics/ugly_medkit.png",
    flags = { "goes-to-quickbar" },
    subgroup = "ammo",
    capsule_action =
    {
      type = "use-on-self",
      attack_parameters =
      {
        type = "projectile",
        ammo_category = "capsule",
        cooldown = 15,
        range = 0,
        ammo_type =
        {
          category = "capsule",
          target_type = "position",
          action =
          {
            type = "direct",
            action_delivery =
            {
              type = "instant",
              target_effects =
              {
                type = "damage",
                damage = { type = "physical", amount = -200 },
              }
            }
          }
        }
      }
    }
    order = "g[medicine]-a[basicmed]",
    stack_size = 20,
}

[LuziferSenpai]

Code: Select all

{
 type = "capsule",
 name = "Medkit",
 icon = "Starfoth's_Simple_Medkit_Mod_0.13.0/graphics/ugly_medkit.png",
 flags = { "goes-to-quickbar" },
 subgroup = "ammo",
 capsule_action = { type = "use-on-self", attack_parameters = { type = "projectile", ammo_category = "capsule", cooldown = 15, range = 0, ammo_type = { category = "capsule", target_type = "position", action =
 				  { type = "direct", action_delivery = { type = "instant", target_effects = { type = "damage", damage = { type = "physical", amount = -200 }, } } } } } }, <-- This comma is missing! Everything else is okay!
 order = "g[medicine]-a[basicmed]",
 stack_size = 20,
}

[Starfoth]

Code: Select all

{
 type = "capsule",
 name = "Medkit",
 icon = "Starfoth's_Simple_Medkit_Mod_0.13.0/graphics/ugly_medkit.png",
 flags = { "goes-to-quickbar" },
 subgroup = "ammo",
 capsule_action = { type = "use-on-self", attack_parameters = { type = "projectile", ammo_category = "capsule", cooldown = 15, range = 0, ammo_type = { category = "capsule", target_type = "position", action =
 				  { type = "direct", action_delivery = { type = "instant", target_effects = { type = "damage", damage = { type = "physical", amount = -200 }, } } } } } }, <-- This comma is missing! Everything else is okay!
 order = "g[medicine]-a[basicmed]",
 stack_size = 20,
}

I appreciate the help, but I'm still getting "Unexpected symbol near "{"
I added in the comma, but it still doesn't go

[aubergine18]

You need a proper code editor with syntax highlighting, it would have shown you the problem immediately:

Code: Select all

<-- This comma is missing! Everything else is okay!

The `<` at start of that precedes the `--` comment marker, so its seen by Lua as an error.

There's a list of decent editors, linters, etc., available in this topic: viewtopic.php?f=34&t=29919

Also, start indenting stuff properly, it makes code much easier to read and errors much easier to spot:

Code: Select all

{
  type = "capsule",
  name = "Medkit",
  icon = "Starfoth's_Simple_Medkit_Mod_0.13.0/graphics/ugly_medkit.png",
  flags = { "goes-to-quickbar" },
  subgroup = "ammo",
  capsule_action = {
    type = "use-on-self",
    attack_parameters = {
      type = "projectile",
      ammo_category = "capsule",
      cooldown = 15,
      range = 0,
      ammo_type = {
        category = "capsule",
        target_type = "position",
        action = {
          type = "direct",
          action_delivery = {
            type = "instant",
            target_effects = {
              type = "damage",
              damage = {
                type = "physical",
                amount = -200
              },
            }
          }
        }
      }
    }
  },
  order = "g[medicine]-a[basicmed]",
  stack_size = 20,
}

[ssilk]

Simple programmers rule with such syntax errors (and no syntax highlight): Comment out until it is working. The bug must be in the latest comment.

[Starfoth]

Thanks everyone, you guys helped me and it looks like it's working.
It looks like I'll be able to make my first Factorio mod.

I'll also probably write better, more readable code in the future, thank-you all

[Starfoth]

I've uploaded it, but it doesn't work. I downloaded it from the mod portal, and it doesn't show up in game. However, if I place my original .zip file, the one that I uploaded in the mod folder, it actually works.

Anyone know what might cause this?

[daniel34]

I've uploaded it, but it doesn't work. I downloaded it from the mod portal, and it doesn't show up in game. However, if I place my original .zip file, the one that I uploaded in the mod folder, it actually works.

Anyone know what might cause this?

Your files and folders are starting with an uppercase letter, you should have them all in lowercase, including the ones in the subfolders.

starfoth-medkit-mod.png (5.82 KiB) Viewed 4760 times

[aubergine18]

Uppercase letter doesn't matter, there are loads of mods with uppercase first letter, spaces, etc.

What matters is the following:

Mod filename must be <name>_<version>

Where <name> and <version> are exactly the same as those defined in the info.json (case sensitive).

So if info.json has

"name" = "Foo Bar"
"version" = "0.1.2"

The mod folder/zip name must be: Foo Bar_0.1.2

Likewise the subfolders can be upper or lower case, they're just there to better organise the files (there's no mandatory need to use subfolders, everything could just go in main folder and several mods already do this). What matters is that in the `requires` statements and also any paths mentioned in prototypes and elsewhere, those must be exactly the same case.

For exmaple, a path in a prototype might look like:

icon = "__Foo Bar__/Graphics/something.png"

And a require statement might look like:

require 'Prototypes.whatever'

As long as the same case is used everywhere, it will work just fine.

All that being said, lowercase is so much easier to type, which I why I always use lowercase folder names. One exception though: I usually use Title Case for my mod name (and thus mod folder) because it looks nicer in-game when you hover over a modded entity/item/tech etc and the yellow mod name is shown in the UI.

[aubergine18]

Just downloaded the mod, the problem is clear:

The zip uses Title Case

When you unzip it, the folder created is in lower case (that means it was lower case to start with, before it was zipped)

The info.json has Title Case "name" value:

"name": "Starfoth Medkit Mod",
"version": "0.13.2",

So what's needed to fix it is that before zipping it up, make sure the main folder is using Title Case for the mod name. The zip it and make sure the zip is also using Title Case, and it will work.

Or, if it's simpler, just put everything lowercase. But whatever you do, be consistent - any inconsistency in case sensitivity will break the mod.

[Starfoth]

I've uploaded it, but it doesn't work. I downloaded it from the mod portal, and it doesn't show up in game. However, if I place my original .zip file, the one that I uploaded in the mod folder, it actually works.

Anyone know what might cause this?

Your files and folders are starting with an uppercase letter, you should have them all in lowercase, including the ones in the subfolders.

starfoth-medkit-mod.png

Got it fixed and now the mod works completely

It's up on the mod portal

Thank-you everyone

[daniel34]

When you unzip it, the folder created is in lower case (that means it was lower case to start with, before it was zipped)

When I unzip it (with WinRar on Windows 7 NTFS) the folders/files still use Title case, as it also was before he zipped them up. When I then start Factorio the mod suddenly works without any further changes as it did on his machine before he zipped it up.

The reason this problem only happens after zipping it up is that the mod was written on Windows and its filesystem is case-insensitive. When Factorio is looking for the prototypes folder then Windows will happily provide the Prototypes folder instead without Factorio noticing. But once the mod is zipped up the zip-library that Factorio uses when reading the file is case-sensitive and won't find a folder named prototypes in there.

In fact, it won't even find a valid control.lua or data.lua because the .zip contains them in Title case, that's why ingame at the mod list it says Synchronisation: Not needed (Missions only) which means it won't be included in the installed mods list when connecting to multiplayer as it is not able to alter the gamestate in any way (TL;DR you can join vanilla servers with it installed and active).

All that being said, lowercase is so much easier to type, which I why I always use lowercase folder names. One exception though: I usually use Title Case for my mod name (and thus mod folder) because it looks nicer in-game when you hover over a modded entity/item/tech etc and the yellow mod name is shown in the UI.

Completely agreed. I did write they should be (not had to be) in lowercase as it (1) is good advice and (2) fixes the issue. I've seen such issues in the past and am aware that files can be mixed case as long as their case is the same everywhere they are used. By simply keeping all of them lowercase you not only can not mix them up, you also prevent issues like this from happening.

[aubergine18]

In fact, it won't even find a valid control.lua or data.lua because the .zip contains them in Title case

This is a valid point, you are correct.

By the time I downloaded the mod those had already been converted to lowercase, along with all the internal folder names. The zip was title case, the info.json was title case, the unzipped mod folder was lowercase, so it still wasn't working for me due to that mismatch. (I'm on a Mac with case sensitive FS).