[1.1.104] Cliff deconstruction cannot be cancelled normally and is not actioned by construction bots

[xykite]

It is possible for cliffs to reach what looks like an inconsistent state, in which they are visually marked for deconstruction with a red cross but do not appear to have any current or planned deconstruction orders: Bots ignore them, and the red cross can't be removed by shift-selecting a deconstruction planner to cancel.

This is pretty easy to reproduce but the specific outcome depends on the particular cliff and location of the roboport - so for the sake of determinism I've included a save (follow the below from 2 for the cliffs north of the player, inside the wooden chests).

1. Set up a powered roboport within range of some cliffs; give it 1 construction bot and a storage chest containing cliff explosives.

   

   cliff.png (123.52 KiB) Viewed 237 times

2. alt-D and select a region of cliffs to schedule them for deconstruction.

   

   deconstruct-8.png (165.64 KiB) Viewed 237 times

3. While the construction bot is en-route but before it has thrown any explosives, right-click-deconstruct the bot to pick it up.
4. alt-D and shift-select the same region of cliffs to cancel the deconstruction.

cancel-7.png (326.35 KiB) Viewed 237 times

Result: Often at least one red cross remains. These cannot now be removed by shift-clicking a deconstruction planner, and they do not result in tasks for construction bots. So it looks like the deconstruction order is lost rather than cancelled.

orphaned-red-cross.png (183.63 KiB) Viewed 237 times

Expected: Any visible red crosses should correspond to active or pending deconstruction orders. Shift-clicking with a deconstruction planner should remove all red crosses.

For the provided save, note that in step 4 one of the cancelled cliffs doesn't get a rectangular selection box, and the number of cancelled cliffs does not match the number from the original deconstruction request in step 2.

There is a trivial workaround: to get rid of the red crosses, select the cliffs with a deconstruction planner again, then cancel the deconstruction order by shift-clicking again.

[Rseding91]

Thanks for the report. This is now fixed for 2.0.