[boskid][1.1.104] Large saves fail to load on Linux with Bad zip file

[XanaAdmin]

Large saves do not load correctly on Linux. Reproduced on multiple fresh games. Suspiciously works at least up to 3.6gb but not 4.4gb. uint32_t filesize?

Code: Select all

$ ./factorio/bin/x64/factorio --start-server $save
   0.000 2024-03-31 23:50:20; Factorio 1.1.104 (build 62119, linux64, full)
   0.010 Operating system: Linux (Debian n/a)
...

   0.482 Loading map /home/desk/factorio/saves/loop-miner-chunk1000v2.zip: 11587704914 bytes.
   0.621 Error ServerMultiplayerManager.cpp:92: MultiplayerManager failed: "Opening file /home/desk/factorio/saves/loop-miner-chunk1500.zip/level.datmetadata failed -- error code -103 (Bad zip file)"

   0.414 Loading map /home/desk/factorio/saves/loop-miner-chunk1000v2.zip: 5197304281 bytes.
   0.478 Error ServerMultiplayerManager.cpp:92: MultiplayerManager failed: "Opening file /home/desk/factorio/saves/loop-miner-chunk1000.zip/level.datmetadata failed -- error code -103 (Bad zip file)"
   
   0.435 Loading map /home/desk/factorio/saves/hyperdar-1_000.zip: 4448324652 bytes.
   0.492 Error ServerMultiplayerManager.cpp:92: MultiplayerManager failed: "Opening file /home/desk/factorio/saves/hyperdar-1_000.zip/level.datmetadata failed -- error code -103 (Bad zip file)"
   
   0.413 Loading map /home/desk/factorio/saves/hypder-1_000_1.2.zip: 3680535214 bytes.
   0.461 Loading level.dat: 8033011179 bytes.
   0.467 Info Scenario.cpp:204: Map version 1.1.94-0
 140.522 Verbose Scenario.cpp:260: Loading level.dat finished: 140.054693 seconds

On Windows the same saves load successfully past this point.

Code: Select all

   0.796 Loading map C:\Users\desk\hyperdar-1_000.zip: 4448324652 bytes.
   0.983 Loading level.dat: 9404671187 bytes.
   0.988 Info Scenario.cpp:204: Map version 1.1.94-0

[Rseding91]

Do you have one of these saves that you could send me somehow?

[XanaAdmin]

Too large for the forum so I put them here.

https://xana.sh/factorio/loop-miner-chu ... 2-1000.zip (5.1gb)
https://xana.sh/factorio/hyperdar-1_000.zip (4.4gb)

[boskid]

I managed to reproduce this issue in 1.1.x on linux but when trying this in 2.0 on linux it loaded without any issues so it is fixed at least for 2.0. Since part of the fixes was to update minizip library i am not going to mess with 1.1.x anymore and i will say this is a duplicate of 105620.

[XanaAdmin]

Fixes here are related to MiniZip, you may try extracting the save file into a directory using an external tool to try loading a save file when it does not load from zip, factorio supports loading unpacked save files.

From that thread. Running from an unzipped folder works successfully for me. Thanks!

Excited for the expansion

Code: Select all

   0.445 Loading map /home/desk/factorio/saves/hyperdar-1_000
   0.539 Loading level.dat: 9404671187 bytes.
   0.543 Info Scenario.cpp:204: Map version 1.1.94-0
 209.934 Verbose Scenario.cpp:260: Loading level.dat finished: 209.386993 seconds.