[Low priority][Graphical] Shadows darken "glowing" objects (eg rail signals)

Bugs that are actually features.
Post Reply
User avatar
Reika
Filter Inserter
Filter Inserter
Posts: 582
Joined: Tue May 19, 2015 1:56 am
Contact:

[Low priority][Graphical] Shadows darken "glowing" objects (eg rail signals)

Post by Reika »

Notice how the selected rail chain signal looks darkened by the shadow falling across it, despite it ostensibly being a lighted object.
Image
Image

Rseding91
Factorio Staff
Factorio Staff
Posts: 13209
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [Low priority][Graphical] Shadows darken "glowing" objects (eg rail signals)

Post by Rseding91 »

Thanks for the report however that's just how it works when it's all just sprites: a lot of shadows are just gray transparent textures and when you render one over top of another it darkens it giving the shadow effect. There's no real light engine at play in the game - just sprites on sprites.
If you want to get ahold of me I'm almost always on Discord.

User avatar
Reika
Filter Inserter
Filter Inserter
Posts: 582
Joined: Tue May 19, 2015 1:56 am
Contact:

Re: [Low priority][Graphical] Shadows darken "glowing" objects (eg rail signals)

Post by Reika »

Rseding91 wrote: ↑
Fri Sep 11, 2020 5:30 am
Thanks for the report however that's just how it works when it's all just sprites: a lot of shadows are just gray transparent textures and when you render one over top of another it darkens it giving the shadow effect. There's no real light engine at play in the game - just sprites on sprites.
I know, but render layers are a thing, so you could ensure "glowing" objects come on top of shadows.
Image

orzelek
Smart Inserter
Smart Inserter
Posts: 3911
Joined: Fri Apr 03, 2015 10:20 am
Contact:

Re: [Low priority][Graphical] Shadows darken "glowing" objects (eg rail signals)

Post by orzelek »

Reika wrote: ↑
Sat Sep 12, 2020 9:20 am
Rseding91 wrote: ↑
Fri Sep 11, 2020 5:30 am
Thanks for the report however that's just how it works when it's all just sprites: a lot of shadows are just gray transparent textures and when you render one over top of another it darkens it giving the shadow effect. There's no real light engine at play in the game - just sprites on sprites.
I know, but render layers are a thing, so you could ensure "glowing" objects come on top of shadows.
I think that for semi proper solution lights layer would need to be used to lighten shadows when they are rendered.
Applying light after shadow is placed will give visible dimming there.

User avatar
Reika
Filter Inserter
Filter Inserter
Posts: 582
Joined: Tue May 19, 2015 1:56 am
Contact:

Re: [Low priority][Graphical] Shadows darken "glowing" objects (eg rail signals)

Post by Reika »

orzelek wrote: ↑
Sat Sep 12, 2020 11:30 am
Reika wrote: ↑
Sat Sep 12, 2020 9:20 am
Rseding91 wrote: ↑
Fri Sep 11, 2020 5:30 am
Thanks for the report however that's just how it works when it's all just sprites: a lot of shadows are just gray transparent textures and when you render one over top of another it darkens it giving the shadow effect. There's no real light engine at play in the game - just sprites on sprites.
I know, but render layers are a thing, so you could ensure "glowing" objects come on top of shadows.
I think that for semi proper solution lights layer would need to be used to lighten shadows when they are rendered.
Applying light after shadow is placed will give visible dimming there.
This is about the sprite itself, not whatever light the entity emits.
Image

orzelek
Smart Inserter
Smart Inserter
Posts: 3911
Joined: Fri Apr 03, 2015 10:20 am
Contact:

Re: [Low priority][Graphical] Shadows darken "glowing" objects (eg rail signals)

Post by orzelek »

Reika wrote: ↑
Sun Sep 13, 2020 4:09 am
orzelek wrote: ↑
Sat Sep 12, 2020 11:30 am
Reika wrote: ↑
Sat Sep 12, 2020 9:20 am
Rseding91 wrote: ↑
Fri Sep 11, 2020 5:30 am
Thanks for the report however that's just how it works when it's all just sprites: a lot of shadows are just gray transparent textures and when you render one over top of another it darkens it giving the shadow effect. There's no real light engine at play in the game - just sprites on sprites.
I know, but render layers are a thing, so you could ensure "glowing" objects come on top of shadows.
I think that for semi proper solution lights layer would need to be used to lighten shadows when they are rendered.
Applying light after shadow is placed will give visible dimming there.
This is about the sprite itself, not whatever light the entity emits.
I was hoping that when rendering shadows you have lightmap ready - so if rendering shadow of any entity it could be suppresed in places where there is a light on lightmap.

Post Reply

Return to β€œNot a bug”