on_player_main_inventory_changed unreliable

[ownlyme]

I'm trying to determine when a bot takes an item out of my hand
To achieve this, i registered some events for on_player_main_inventory_changed, on_player_cursor_stack_changed and on_player_fast_transferred
Then i wrote an on_tick script that compares the last-registered on_player_main_inventory_changed and on_player_cursor_stack_changed ticks and makes sure the player didn't fast-transfer something on the same tick.
But when i proceeded to test my system with concrete, i often got items taken out of my hand without the scripts noticing. (randomly)
After further investigation, i found out that the on_player_main_inventory_changed event didn't fire reliably
I also disabled all other mods to make sure no other mod was swallowing the events, like when a mod destroys a robot on a robot_built event.

i attached the mods, to test you might need to sell a few reactors for some money first and toggle the checkbox next to the red + green buttons in the crafting menu

let me know if you need more information or different testing methods

i dont remember anymore why i monitored both events but it looks like i can solve my problem without the main_inventory_changed event.
still it would be really nice if all events were reliable

[Rseding91]

The event is not instant. it happens at the end of the current tick that the change happened in so if something removes, then adds, then removes, then adds, you still only get 1 event at the end of the tick.

[ownlyme]

yeah but in the on_tick function i only check if it happened in the last tick (see my first screenshot)
but it's getting worse:

Screenshot_9.jpg (23.77 KiB) Viewed 1396 times

(this is new....)
when i look at that screenshot i have no clue why my new system works... (99% of the time)

guess my bug is not reproducible..

[Rseding91]

Don't use game.print() for debug things that involve same-tick times because you'll hit the spam protection logic and any duplicate messages just get erased.

Always use log() for those kinds of things. I suspect you're just not seeing the duplicate message in the console because it got eaten by spam protection.

[ownlyme]

as you see it's written in a way that there won't be any dublicate messages until the first time it detected that the cursor is empty

[Rseding91]

Then you'll need to find a way to prove that there's an issue with the game logic. The event uses the same internal item-changed notification system that everything uses and that has *extensive* testing and automated tests in place to verify it's correct.

[ownlyme]

i think i got confused because construction robots sometimes go back into your inventory even if there should still be items that they could pick up (but maybe they are reserved?), thus triggering the event.
So i assumed the main_inventory_changed event would always fire even if i have the item in my hand, which it doesn't
But the on_player_cursor_stack_changed event seems to be reliable

sorry for the inconvenience