[0.17.60] GUI crashed when tinkering with fluid mixing: "Failed to create GUI slot"

[boskid]

Steps to reproduce:

1. Open editor
2. Build this:

   

   gui-tinkering-crash-1.png (35.78 KiB) Viewed 917 times

3. Remove cutter underground pipe to get into this state:

   

   gui-tinkering-crash-2.png (32.77 KiB) Viewed 917 times

4. Use upgrade planner to upgrade AM2 into AM3, this will give you this:

   

   gui-tinkering-crash-3.png (47.44 KiB) Viewed 917 times

5. Click left mouse on AM3 to open its GUI
6. Crash
   log

   Code: Select all

      0.003 2019-08-01 17:56:30; Factorio 0.17.60 (build 46514, win64, steam)

   Code: Select all

   cc:\cygwin64\tmp\factorio-build-pdpjjf\src\material\productionhelper.cpp (270): ProductionHelper::createMaterialGuiSlot
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\gui\assemblingmachinegui.cpp (139): AssemblingMachineGui::updateContent
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\input\commonmapinteraction.cpp (405): CommonMapInteraction::openEntityGui
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\input\commonmapinteraction.cpp (158): CommonMapInteraction::openGuiInternal
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\gameview.cpp (565): GameView::loadGuiForController
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\gameview.cpp (400): GameView::executeAction
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\gameview.cpp (328): GameView::executeActions
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\game.cpp (301): Game::postAllegroActionProcessed
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\game.cpp (274): Game::postUpdate
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\mainloop.cpp (959): MainLoop::prepare
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\mainloop.cpp (656): MainLoop::mainLoopStep
   c:\cygwin64\tmp\factorio-build-pdpjjf\src\mainloop.cpp (377): MainLoop::run

   Code: Select all

    139.288 Error ProductionHelper.cpp:270: Failed to create GUI slot: objectIndex: 1, isInput: false, inventory size: 1, fluidBoxManager: true, input size: 0, output size: 0, target specification: source: entity-inventory, target: default, inventory index: 3, slot index: 1, source: 77, extra info: name: assembling-machine-3, fixed-recipe: <null>, current-recipe: empty-crude-oil-barrel, simulation: false, setup: true

   factorio-current.log

   (14.23 KiB) Downloaded 74 times

This bug report consists of two issues:
- GUI part to fix
- fluid mixing part to fix (ref 73890)

@Dominik: upgrade of steam engine into steam turbine is also sufficient to trigger fluid mixing between steam and other fluid

-- edit:
Same issue may be triggered when using assembler with inputs (like "fill sulfuric acid barrel"). Little different error message:

Code: Select all

 944.462 Error ProductionHelper.cpp:270: Failed to create GUI slot: objectIndex: 1, isInput: true, inventory size: 1, fluidBoxManager: true, input size: 0, output size: 0, target specification: source: entity-inventory, target: default, inventory index: 2, slot index: 1, source: 77, extra info: name: assembling-machine-3, fixed-recipe: <null>, current-recipe: fill-crude-oil-barrel, simulation: false, setup: true

[Dominik]

Yes, the gui crashes when the fluids are already in a broken state. That is known.