[0.17.34] Deconstruction planner does not remove curved rails with trains on them in editor mode

[knightelite]

What did I do?

Used a deconstruction planner from editor mode to remove rails with trains on them.

What happened?

All trains were removed, all straight rails were removed, curved rails with no trains on top were removed, but curved rails without trains on them were not removed.

What did I expect to have happen?

I expected all rails to be removed. In regular mode (non editor) trains + rails with no trains are marked for deconstruction, while in editor it should be everything removed.

Gif demonstrating the problem. I've attached the save used in this demo as well.

[Rseding91]

Thanks for the report. There's actually no special logic in editor mode around removing trains on rails. You just happen to be in a setup where when iterating the entities to be marked for deconstruction the trains are found first and destroyed via the editor "destroy on marked for deconstruction" logic. In the curved rail example the train isn't the first thing found and so it finds the curved rail first, fails to remove it because it has a train on it, and then moves on.

I've got a large collection of things that I want to work on for the editor mode at some point so I'll add this to it. For now, this isn't technically a bug - just behavior you thought would work one way but actually doesn't do anything special.