[0.16.51] trigger_created_entity has wrong force

[Forty-Bot]

In data.lua:

Code: Select all

data.raw.projectile["atomic-rocket"].action.action_delivery.target_effects[2].trigger_created_entity = true

In control.lua:

Code: Select all

script.on_event(defines.events.on_trigger_created_entity, function (e)
    game.print(e.entity.name .. " " .. e.entity.force.name)
end)

When firing the rocket, the output is "explosion neutral", but the expected output is "explosion player" since the player shot the rocket, so the created entity should be on the players' force. Additionally, despite create-trivial-smoke being a subtype of create-entity, trigger_created_entity appears to do nothing (this can be tested by using [1] instead of [2] in the snippet above).

[Klonan]

This isn't a bug

It isn't that explosion is created with the wrong force,
It is that explosion has no force, so it always reads and acts as 'neutral'.

Create trivial smoke is a distinct trigger effect from the created entity, and wasn't programmed to trigger the event

[Forty-Bot]

It is that explosion has no force, so it always reads and acts as 'neutral'.

So can we change that? It's created by something with a force (the projectile). I'm using it to create other effects at run-time which are force-dependent, so I would like some way to get the original force from this event. In any case, this behaviour is non-intuitive. And this still doesn't change that other subtypes of create-entity should still create this event.

[posila]

So can we change that?

No. Make the projectile trigger spawn an entity that has force instead (for example something based of simple-entity-with-owner).

EDIT:

And this still doesn't change that other subtypes of create-entity should still create this event.

create-trivial-smoke trigger effect is not subtype of create-entity trigger effect.

trivial-smoke is not an entity (in Factorio's sense of entity), it has its own LuaSurface::create_trivial_smoke function, and it's not possible to access existing trivial smokes from lua context (for example by using LuaSurface::find_entities)

[Forty-Bot]

create-trivial-smoke trigger effect is not subtype of create-entity trigger effect.

It says it is on the wiki

Inherits all properties from Types/TriggerEffectItem.

[Rseding91]

create-trivial-smoke trigger effect is not subtype of create-entity trigger effect.

It says it is on the wiki

Inherits all properties from Types/TriggerEffectItem.

Correct. It doesn't extend https://wiki.factorio.com/Types/CreateE ... EffectItem as everything that does extend it says.