[0.17.54] PermissionGroup train permissions not working properly

[veladon]

The following permissions when configured on a permission group don't seem to work properly:

defines.input_action.change_train_stop_station
- disabling still allows colour to be changed

defines.input_action.change_train_wait_condition
defines.input_action.change_train_wait_condition_data
- disabling these two still allows editing of wait conditions (e.g. can change the time passed slider and circuit conditions)

defines.input_action.drag_train_schedule
- disabling still allows dragging stations

defines.input_action.drag_train_wait_condition
- disabling still allows dragging schedule wait conditions

defines.input_action.open_train_gui
- disabling still allows you to left-click a train to open train gui

defines.input_action.open_train_station_gui
- disabling still allows you to left-click a train station to open train station gui

---------------

In the attached screenshot, the AND/OR button is incorrectly aligned. To replicate, disable the above train conditions and drag a train wait condition below the AND/OR button up.

---------------


Save file is set up where the Default permission group does not have any of the above permissions.

[Rseding91]

defines.input_action.change_train_stop_station
- disabling still allows colour to be changed

Correct. change_train_stop_station has nothing to do with the color of a train. That is the "set entity color" permission.

defines.input_action.change_train_wait_condition
defines.input_action.change_train_wait_condition_data
- disabling these two still allows editing of wait conditions (e.g. can change the time passed slider and circuit conditions)

Try to do it, close the GUI, and open it again. You'll see nothing was changed.

defines.input_action.drag_train_schedule
- disabling still allows dragging stations

Try to do it, close the GUI, and open it again. You'll see nothing was changed.

defines.input_action.drag_train_wait_condition
- disabling still allows dragging schedule wait conditions

Try to do it, close the GUI, and open it again. You'll see nothing was changed.

defines.input_action.open_train_gui
- disabling still allows you to left-click a train to open train gui

open_train_gui is not the only way to open a train GUI. You also have to disable open_gui. open_train_gui is a special version for opening train GUIs from the train stop GUI.

defines.input_action.open_train_station_gui
- disabling still allows you to left-click a train station to open train station gui

open_train_station_gui is not the only way to open a train station GUI. You also have to disable open_gui. open_train_station_gui is a special version for opening train station GUIs from minimaps (the map inside a train GUI)