[kovarex] [0.15.33] Self-replacable entity revive in on_put_item

[eradicator]

Symptom:
If an entity that is fast-replacable by itself (i.e. inserters, belts, mining drills) is .revive()'d in defines.events.on_put_item in a different rotation, then during the following fast replace the entity loses it's circuit network cables.

Background:
I was trying to write a small script that properly preserves entity settings (circuit conditions/connections, recipe, rotation, etcpp) when the player "manually revives" a ghost by building the same structure on top of a ghost.

Code

Code: Select all

local function is_same_position(posa,posb)
  return (posa.x == posb.x) and (posa.y == posb.y)
  end

local function on_put_item(e)
  --check if this event is ghostly
  local p   = game.players[e.player_index]
  local pos = e.position
  local ghost = p.surface.find_entity('entity-ghost', pos)
  if ghost == nil then return end
  
  --fetch some pointers
  local cur = p.cursor_stack
  assert(cur.valid_for_read and cur.valid, 'Wtf? How did you do that?') --on_put_item without a cursor stack should be impossible...
  
  --fetch prototypes
  local tp = ghost.ghost_prototype      --target prototype
  local sp = cur.prototype.place_result --source prototype
  if sp == nil then return end

  --revive
  if (tp.type == sp.type) and (tp.name == sp.name) and is_same_position(ghost.position,pos) then
    local _,zombie,itemproxy = ghost.revive(true)
    if zombie then
      cur.count = cur.count - 1
      end
    -- if itemproxy then itemproxy.destroy() end --can destroy module requsts here
    end
  end

Reproduction:
1) Build e.g two inserters/belts and connect them with a circuit cable
2) Make a blueprint of them and place those two ghosts somewhere
3) Build an inserter on top of one of the ghosts but revive the ghost in on_put_item (e.g. using above code). Take care to hold the inserter on the cursor in a different rotation than the ghost.
4) The ghost is revived and immediately fast-replaced by itself, losing it's circuit connection but keeping circuit settings

Addendum
Everything works fine btw if you build the inserter in the same direction as the ghost, as then it can not fast-replace itself. Things that are not self-replacable are not affected either because the actual build event just fails.

Expected Behavior
Ideally the fast-replacing would be canceld so that rotation can be preserved as well ... fine, i just want it to keep the cables. Unless this whole functionality has already been secretly integrated into 0.16 .

[Bilka]

Expected Behavior
Ideally the fast-replacing would be canceld so that rotation can be preserved as well

Please no, fast rotating by fast replacing inserters/belts is one of the core functions that make placing belts not incredibly tedious. Without that you would either have to mine every single entity and place it again (not preserving circuit network settings) or press r/shift + r on each entity up to 2 times. Please preserve the circuit wires instead.

[eradicator]

@Bilka:
Err, that was obviously meant to only cancel when there was reviving going on, and - as marked by the smiley - was half-jokingly because i didn't actually expect that to happen.

[kovarex]

The decision was made to not allow fast replace from ghost with different direction.

[eradicator]

The decision was made to not allow fast replace from ghost with different direction.

Maybe i'm understanding that wrong, but this bug report wasn't concerning fast-replacing ghosts. It's concerning ghosts that were revived before being fast-replaced and should thus be normal entities. If you need me to describe this in more details please give me a hint?

[kovarex]

rebuilding doesn't cancel circuit connection.