Protect game tables and Lua libraries during data stage

[eduran]

Not really an interface request, but I did not know where else to put it.

Would it be possible to prevent mods from overriding built-in game tables and Lua libraries during the data stage? If one mod does something stupid like "math = 0", all following mods are in trouble. Ideally the responsible mod should throw an error, not the mod trying to access "math". You can even do stuff like settings = 0 or data = 0.

I know it will result in an error either way, but it would be nice if reports like this were directed towards whoever overrode debug, instead of my mod.

[Nexela]

Seconded! for debug at least.

[eradicator]

Thirded.
And for table/string at least, so ppl don't inject their own shitty code.

[Rseding91]

I'm not against the idea but Lua includes no such "protection" system so I would have to add it and then it's going to incur a performance overhead for every single global assignment for the rest of time.

[eradicator]

I welcome our new local variable overlords.
Would it make *reading* globals slower too?
(And just for the record, the protection is only needed for settings/data stage, so in control everybody could still be free to shoot themselfs in the foot?)

[eduran]

Maybe something along those lines, for data stage only?

so in control everybody could still be free to shoot themselfs in the foot?)

No problem with that. But during the data stage, everyone's feet are at risk

[Rseding91]

Maybe something along those lines, for data stage only?

so in control everybody could still be free to shoot themselfs in the foot?)

No problem with that. But during the data stage, everyone's feet are at risk

That doesn't protect if someone does math = nil. It only protects if someone does math.random = nil.

[eradicator]

Maybe something along those lines, for data stage only?

so in control everybody could still be free to shoot themselfs in the foot?)

No problem with that. But during the data stage, everyone's feet are at risk :D

That doesn't protect if someone does math = nil. It only protects if someone does math.random = nil.

Or against setmetatable(_ENV,nil) or rawset(_ENV,math,nil). :twisted:

[mrudat]

Perhaps a sanity check after a mod is run that the expected globals are still there?

[eradicator]

Perhaps a sanity check after a mod is run that the expected globals are still there?

I like that vector. No need to do expensive checks. Just reset all global libraries to default after each mod. That way they can still shoot their own feet, but won't affect anyone elses.

[darkfrei]

Why we cannot just insert tables to data.raw? It looks like read-only table.

Code: Select all

data.raw = {new_type = {type = "new_type", name = "new-name"}}

Or

Code: Select all

table.insert (data.raw.inserter, {type = "inserter", name = "new-inserter"})