PyCoalTBaA or the PyCoal Touched by an Angel Compatibility Patch

[lux]

I am getting the same

error in assignid, item-subgroup with name 'slag-processing' does not exist slag-processing-nio

I disabled pymods and have attached my mod list. Let me know if any other info is required. Thanks for making an awesome mod!

[kingarthur]

I am getting the same

error in assignid, item-subgroup with name 'slag-processing' does not exist slag-processing-nio

I disabled pymods and have attached my mod list. Let me know if any other info is required. Thanks for making an awesome mod!

alright ill look into as soon as i get this issue with omnifluid and pyph sorted. or in a few hours if this omni issue keeps pissing me off

[katalex]

bug1.jpg (32.91 KiB) Viewed 5507 times

bug.jpg (214.33 KiB) Viewed 5507 times

[lux]

I am getting the same

error in assignid, item-subgroup with name 'slag-processing' does not exist slag-processing-nio

I disabled pymods and have attached my mod list. Let me know if any other info is required. Thanks for making an awesome mod!

alright ill look into as soon as i get this issue with omnifluid and pyph sorted. or in a few hours if this omni issue keeps pissing me off

Indeed I have no idea how to fix it, but I can see it in the source here
https://github.com/kingarthur91/PyCoalT ... g.lua#L324
https://github.com/kingarthur91/PyCoalT ... g.lua#L366
Renaming those to just slag-processing said it did not know about slag-processing, so my noob guess is something in one of the other mods changed.

Also i forgot to attach a save, so here is one (note that this was saved before some mods were updated, latest on everything is what I am actually trying to run).

[kingarthur]

I am getting the same

error in assignid, item-subgroup with name 'slag-processing' does not exist slag-processing-nio

I disabled pymods and have attached my mod list. Let me know if any other info is required. Thanks for making an awesome mod!

alright ill look into as soon as i get this issue with omnifluid and pyph sorted. or in a few hours if this omni issue keeps pissing me off

Indeed I have no idea how to fix it, but I can see it in the source here
https://github.com/kingarthur91/PyCoalT ... g.lua#L324
https://github.com/kingarthur91/PyCoalT ... g.lua#L366
Renaming those to just slag-processing said it did not know about slag-processing, so my noob guess is something in one of the other mods changed.

Also i forgot to attach a save, so here is one (note that this was saved before some mods were updated, latest on everything is what I am actually trying to run).

Ya. I'm assuming somebody updated something as angel just put out some updates.

I'm not that worried about if they are updated it just the issue of trying to find them is a pain when sync mods with save is so much faster given not all the mods names are the same in the modlist as on the mod portal

[kingarthur]

the error with angels mods and slag-processing has been fixed. please update pycoaltbaa.

[kingarthur]

the new fix seems not useful (PyCoalTBaA_0.0.48)



9.119 Loading mod pycoalprocessing 1.1.6 (data-final-fixes.lua)
9.302 Loading mod bobplates 0.17.3 (data-final-fixes.lua)
9.487 Loading mod bobelectronics 0.17.3 (data-final-fixes.lua)
9.759 Loading mod pyindustry 1.2.1 (data-final-fixes.lua)
10.017 Loading mod pypetroleumhandling 1.0.1 (data-final-fixes.lua)
10.128 Error ModManager.cpp:1294: Failed to load mod "pypetroleumhandling": __pypetroleumhandling__/prototypes/functions/functions.lua:266: attempt to perform arithmetic on field 'amount' (a nil value)
stack traceback:
__pypetroleumhandling__/prototypes/functions/functions.lua:266: in function 'hotairrecipes'
__pypetroleumhandling__/data-final-fixes.lua:5: in main chunk
10.130 Loading mod core 0.0.0 (data.lua)
10.249 Checksum for core: 995669552
10.843 Error ModManager.cpp:1294: Error in assignID, recipe-category with name 'crafting' does not exist.

Can you give me a full medalist. The newest version of Bob's is working for me with no issues

only PY and BOB and PyCoalTBaA_0.0.48 . nothing else

list
bobassembly_0.17.3
bob-basic-belt-reskin_0.17.3
bobclasses_0.17.3
bobelectronics_0.17.3
bobenemies_0.17.4
bobgreenhouse_0.17.0
bobinserters_0.17.5
boblibrary_0.17.0
boblogistics_0.17.7
bobmining_0.17.3
bobmodules_0.17.3
bobores_0.17.1
bobplates_0.17.3
bobpower_0.17.4
bobrevamp_0.17.2
bobtech_0.17.2
bobvehicleequipment_0.17.1
bobwarfare_0.17.4
pycoalprocessing_1.1.6
PyCoalTBaA_0.0.48
pyfusionenergy_1.2.1
pyhightech_1.1.3
pyhightech_1.1.4
pyindustry_1.2.1
pypetroleumhandling_1.0.1
stdlib_1.0.2

this has been fixed and will be in the next pypetroleumhandling update

[AmatorPhasma]

Hi,

I know you did not investigate the problem with my mods because of the other things as you said, but I have looked into it a bit... (If I know that there is a failure, I have to deal with it or I can not sleep: D)

I have collected some information:

Here are (again for the memory) the error:

Code: Select all

31.363 Error ModManager.cpp:1294: Error while loading recipe prototype "basic-electronic-components" (recipe): Difficulty normal: Recipe has invalid main product basic-electronic-components. The product does not exist in the recipe product list. 

I checked all my override functions in my library (found some problems or missing checks, so it was very productive ), but nothing that results in this error.
At the end I just throw a serpent.block log... at the end of every mod in this pack.
"Debugging in factorio sometimes feels a bit strange, it's a bit like reverse engineering the SMB protocol, and I can say you thats a pain in the a... "

In the end I can determine the failure in the last stage of your mod and to the angelsmods.functions.OV.execute()

Code: Select all

  17.838 Script @__apm_power__/data-final-fixes.lua:12: =================================================================
  17.838 Script @__apm_power__/data-final-fixes.lua:13: After final stage apm_power
  17.838 Script @__apm_power__/data-final-fixes.lua:14: {
  category = "electronics-machine",
  expensive = {
    enabled = false,
    energy_required = 3,
    ingredients = {
      {
        amount = 1,
        name = "tinned-copper-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    result = "basic-electronic-components",
    result_count = 3
  },
  name = "basic-electronic-components",
  normal = {
    enabled = false,
    energy_required = 2,
    ingredients = {
      {
        amount = 1,
        name = "tinned-copper-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    result = "basic-electronic-components",
    result_count = 5
  },
  type = "recipe"
}

^^looks good

Code: Select all

8.164 Script @__apm_recycling__/data-final-fixes.lua:5: =================================================================
  18.164 Script @__apm_recycling__/data-final-fixes.lua:6: After final stage apm_recycling
  18.164 Script @__apm_recycling__/data-final-fixes.lua:7: {
  category = "electronics-machine",
  expensive = {
    enabled = false,
    energy_required = 3,
    ingredients = {
      {
        amount = 1,
        name = "tinned-copper-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    main_product = "basic-electronic-components",
    results = {
      {
        amount = 3,
        name = "basic-electronic-components",
        type = "item"
      },
      {
        amount_max = 1,
        amount_min = 0,
        name = "apm_scrap_metal_box_tin",
        probability = 0.01,
        type = "item"
      }
    }
  },
  name = "basic-electronic-components",
  normal = {
    enabled = false,
    energy_required = 2,
    ingredients = {
      {
        amount = 1,
        name = "tinned-copper-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    main_product = "basic-electronic-components",
    results = {
      {
        amount = 5,
        name = "basic-electronic-components",
        type = "item"
      },
      {
        amount_max = 1,
        amount_min = 0,
        name = "apm_scrap_metal_box_tin",
        probability = 0.01,
        type = "item"
      }
    }
  },
  type = "recipe"
}
  18.164 Script @__apm_recycling__/data-final-fixes.lua:8: ================================================================= 

^^looks good

Code: Select all

30.278 Script @__PyCoalTBaA__/data-final-fixes.lua:272: =================================================================
  30.278 Script @__PyCoalTBaA__/data-final-fixes.lua:273: After final stage PyCoalTBaA
  30.278 Script @__PyCoalTBaA__/data-final-fixes.lua:274: {
  category = "electronics-machine",
  expensive = {
    enabled = false,
    energy_required = 3,
    ingredients = {
      {
        amount = 1,
        name = "tinned-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    main_product = "basic-electronic-components",
    results = {
      {
        amount = 3,
        name = "resistor2",
        type = "item"
      },
      {
        amount_max = 1,
        amount_min = 0,
        name = "apm_scrap_metal_box_tin",
        probability = 0.01,
        type = "item"
      }
    }
  },
  name = "basic-electronic-components",
  normal = {
    enabled = false,
    energy_required = 2,
    ingredients = {
      {
        amount = 1,
        name = "tinned-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    main_product = "basic-electronic-components",
    results = {
      {
        amount = 5,
        name = "resistor2",
        type = "item"
      },
      {
        amount_max = 1,
        amount_min = 0,
        name = "apm_scrap_metal_box_tin",
        probability = 0.01,
        type = "item"
      }
    }
  },
  type = "recipe"
}
  30.278 Script @__PyCoalTBaA__/data-final-fixes.lua:275: ================================================================= 

^^looks bad

The function here simply replaced the "basic-electronic-components" with "resistor2" but don't check if there is a main_product because this recipe has multiple output and no icon or icons definition.

you call in (./prototypes/overrides-Hightech.lua)

Code: Select all

OV.global_replace_item('basic-electronic-components','resistor2')

and then call in (./data-final-fixes.lua)

Code: Select all

if mods["angelspetrochem"] then
    angelsmods.functions.OV.execute()

^^ Therefore, this error is only raised if "angelspetrochem" is included, and this is the function that forgets to check the "main_product" property in this recipe. I did not thoroughly investigate this function. We should ask Angel for help, because its his function you use here.

I have attatched the last log with this error and a save file before enabling angelspetrochem mod for a easy sync (I hate to select mods manuel )

EDIT: .. its called "because" NOT "becouse", I will never learn this ...

[kingarthur]

Hi,

I know you did not investigate the problem with my mods because of the other things as you said, but I have looked into it a bit... (If I know that there is a failure, I have to deal with it or I can not sleep: D)

I have collected some information:

Here are (again for the memory) the error:

Code: Select all

31.363 Error ModManager.cpp:1294: Error while loading recipe prototype "basic-electronic-components" (recipe): Difficulty normal: Recipe has invalid main product basic-electronic-components. The product does not exist in the recipe product list. 

I checked all my override functions in my library (found some problems or missing checks, so it was very productive ), but nothing that results in this error.
At the end I just throw a serpent.block log... at the end of every mod in this pack.
"Debugging in factorio sometimes feels a bit strange, it's a bit like reverse engineering the SMB protocol, and I can say you thats a pain in the a... "

In the end I can determine the failure in the last stage of your mod and to the angelsmods.functions.OV.execute()

Code: Select all

  17.838 Script @__apm_power__/data-final-fixes.lua:12: =================================================================
  17.838 Script @__apm_power__/data-final-fixes.lua:13: After final stage apm_power
  17.838 Script @__apm_power__/data-final-fixes.lua:14: {
  category = "electronics-machine",
  expensive = {
    enabled = false,
    energy_required = 3,
    ingredients = {
      {
        amount = 1,
        name = "tinned-copper-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    result = "basic-electronic-components",
    result_count = 3
  },
  name = "basic-electronic-components",
  normal = {
    enabled = false,
    energy_required = 2,
    ingredients = {
      {
        amount = 1,
        name = "tinned-copper-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    result = "basic-electronic-components",
    result_count = 5
  },
  type = "recipe"
}

^^looks good

Code: Select all

8.164 Script @__apm_recycling__/data-final-fixes.lua:5: =================================================================
  18.164 Script @__apm_recycling__/data-final-fixes.lua:6: After final stage apm_recycling
  18.164 Script @__apm_recycling__/data-final-fixes.lua:7: {
  category = "electronics-machine",
  expensive = {
    enabled = false,
    energy_required = 3,
    ingredients = {
      {
        amount = 1,
        name = "tinned-copper-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    main_product = "basic-electronic-components",
    results = {
      {
        amount = 3,
        name = "basic-electronic-components",
        type = "item"
      },
      {
        amount_max = 1,
        amount_min = 0,
        name = "apm_scrap_metal_box_tin",
        probability = 0.01,
        type = "item"
      }
    }
  },
  name = "basic-electronic-components",
  normal = {
    enabled = false,
    energy_required = 2,
    ingredients = {
      {
        amount = 1,
        name = "tinned-copper-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    main_product = "basic-electronic-components",
    results = {
      {
        amount = 5,
        name = "basic-electronic-components",
        type = "item"
      },
      {
        amount_max = 1,
        amount_min = 0,
        name = "apm_scrap_metal_box_tin",
        probability = 0.01,
        type = "item"
      }
    }
  },
  type = "recipe"
}
  18.164 Script @__apm_recycling__/data-final-fixes.lua:8: ================================================================= 

^^looks good

Code: Select all

30.278 Script @__PyCoalTBaA__/data-final-fixes.lua:272: =================================================================
  30.278 Script @__PyCoalTBaA__/data-final-fixes.lua:273: After final stage PyCoalTBaA
  30.278 Script @__PyCoalTBaA__/data-final-fixes.lua:274: {
  category = "electronics-machine",
  expensive = {
    enabled = false,
    energy_required = 3,
    ingredients = {
      {
        amount = 1,
        name = "tinned-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    main_product = "basic-electronic-components",
    results = {
      {
        amount = 3,
        name = "resistor2",
        type = "item"
      },
      {
        amount_max = 1,
        amount_min = 0,
        name = "apm_scrap_metal_box_tin",
        probability = 0.01,
        type = "item"
      }
    }
  },
  name = "basic-electronic-components",
  normal = {
    enabled = false,
    energy_required = 2,
    ingredients = {
      {
        amount = 1,
        name = "tinned-cable",
        type = "item"
      },
      {
        amount = 1,
        name = "solid-carbon",
        type = "item"
      }
    },
    main_product = "basic-electronic-components",
    results = {
      {
        amount = 5,
        name = "resistor2",
        type = "item"
      },
      {
        amount_max = 1,
        amount_min = 0,
        name = "apm_scrap_metal_box_tin",
        probability = 0.01,
        type = "item"
      }
    }
  },
  type = "recipe"
}
  30.278 Script @__PyCoalTBaA__/data-final-fixes.lua:275: ================================================================= 

^^looks bad

The function here simply replaced the "basic-electronic-components" with "resistor2" but don't check if there is a main_product because this recipe has multiple output and no icon or icons definition.

you call in (./prototypes/overrides-Hightech.lua)

Code: Select all

OV.global_replace_item('basic-electronic-components','resistor2')

and then call in (./data-final-fixes.lua)

Code: Select all

if mods["angelspetrochem"] then
    angelsmods.functions.OV.execute()

^^ Therefore, this error is only raised if "angelspetrochem" is included, and this is the function that forgets to check the "main_product" property in this recipe. I did not thoroughly investigate this function. We should ask Angel for help, because its his function you use here.

I have attatched the last log with this error and a save file before enabling angelspetrochem mod for a easy sync (I hate to select mods manuel )

EDIT: .. its called "because" NOT "becouse", I will never learn this ...

I actually just got around to looking at your mods. Spent about an hour just kinda playing with it and looking at stuff in it.

If it's an item replacement issue I've made my own replacer functions that dont use Angel's. It should account for main product and things. I'm checking it now

[kingarthur]

Hi,

I know you did not investigate the problem with my mods because of the other things as you said, but I have looked into it a bit... (If I know that there is a failure, I have to deal with it or I can not sleep: D)

and all the errors are fixed now. so it will load at least

[AmatorPhasma]

Hi,

I know you did not investigate the problem with my mods because of the other things as you said, but I have looked into it a bit... (If I know that there is a failure, I have to deal with it or I can not sleep: D)

and all the errors are fixed now. so it will load at least

Thanks!

Well, can I go to sleep now?!

I pushed Angel anyway, because if something really does not work properly in his function, that should be considered.

/me creeps unobtrusively to bed

[Arch666Angel]

this will one way or the other always require an additional action, because what would you insert as an icon there if you just remove the main_product, only thing you really can do is add an placeholder and that's not as helpful either. If you change it to do nothing in instances where there is a main_product defined it isn't helpful either because you then have to check all recipes again to see if it worked...

[kingarthur]

this will one way or the other always require an additional action, because what would you insert as an icon there if you just remove the main_product, only thing you really can do is add an placeholder and that's not as helpful either. If you change it to do nothing in instances where there is a main_product defined it isn't helpful either because you then have to check all recipes again to see if it worked...

i swap over to the global item replace function i wrote after i started venturing out from under the wings of my guardian angel and it replaces the main product which gets rid of those errors.

OV.global_replace_item doesnt apparently

[Rue99]

kingarthur, well done for fighting your way through the thickets of mod compatability - my Bob/Angel game now works with PyPH etc. However, as usual, I always regret installing Pyanadon's mods - come for the beautiful buildings, run away screaming at the sheer complexity and slowness of it all . Still, that's on me, not you and you deserve a big *thanks* for your hard work!

[cygnos]

Im crashing on 'Failed to load mods: __PyCoalTBaA__/data-updates.lua:15: __PyCoalTBaA__/prototypes/Overrides-Omnimatter.lua:127: attempt to index field 'phosphate-rock-02' (a nil value)'

Using most of py, angels, omni, bobs. Seems the 'data.raw.resource["phosphate-rock-02"]' gets deleted somewhere, its nil by the time its at prototypes.overrides-omnimatter.lua #127.

Commenting out that line or checking if 'data.raw.resource["phosphate-rock-02"]' exists before setting 'data.raw.resource["phosphate-rock-02"]["autoplace"] = nil' fixes it.

[katalex]

Hello,
All ok.
But I can't make glass in early game, can't find recipe.
Glass<-quartz<-crystal mine<-transport belt...i can't make transport belt without logistic, logistic demands sc pack1

[kingarthur]

Hello,
All ok.
But I can't make glass in early game, can't find recipe.
Glass<-quartz<-crystal mine<-transport belt...i can't make transport belt without logistic, logistic demands sc pack1

are you using aaii or something?

[katalex]

are you using aaii or something?

No.

[kingarthur]

are you using aaii or something?

No.

Ok. Send a save and I'll see what's broken

[katalex]

Снимок экрана от 2019-04-28 08-16-29.png (41.62 KiB) Viewed 5345 times

Снимок экрана от 2019-04-28 08-15-51.png (165.57 KiB) Viewed 5345 times

Save file

Ax.zip

(2.5 MiB) Downloaded 122 times

Usually used recipe with clear sand+broken brown substation from angels mods.