[MOD] Deadlock's Stacking Beltboxes & Compact Loaders

[ShinoHarvest]

miss angel catalist(mineral, cristal, hybrid) and slag for compresed recipe

[Deadlock989]

miss angel catalist(mineral, cristal, hybrid) and slag for compresed recipe

Third party mod items are not directly supported, see the first post for add-ons for other mods and the FAQ.

[Deadlock989]

DSB & DCL version: 1.6.0
Date: 08. 05. 2018
Changes:
- Final "definitive" version for Factorio 0.16.
- Another check added to belt snapping, courtesy of shanemadden.

[MasterZenII]

There is a request on the mod portal to add a tier 0 beltbox

That gave me a chuckle, if you are at the point of the game that you are using those belts then you do not need stacked resources, having the loader however is handy and compact loaders already has a tier 0 loader.

[MasterZenII]

miss angel catalist(mineral, cristal, hybrid) and slag for compresed recipe

Was easy enough to make so I thought why not. Also I missed the catalysts in my own personal add-on. XD

[Sigma1]

The graphics are real nice! I'm just wondering how you made the textures?

[Deadlock989]

The graphics are real nice! I'm just wondering how you made the textures?

Thanks. Blender, TexturePacker, PNGGauntlet and a 16 year old version of Photoshop.

[Deadlock989]

Deadlock's Stacking Beltboxes version: 1.6.1
Date: 10. 05. 2018
Bugfixes:
- Fixed an issue when updating technologies with modded vanilla items, where a recipe tech unlock could be duplicated.

[Xagros]

Hi!, bro. Can you add my mod to the third party add-ons list? My mod supports Angel, AAI and Bob mods.

More bobs!

[Fuchsi_II]

I am trying to create an addon for DSB and DCM that adds support for more vanilla items.
But it works only with some items.
can some one help me. I guess it works correctly only with items with the prototype name item.

here is my mod/addon: http://www.mediafire.com/file/kc71ql4ii ... _0.0.1.zip
and here is my factorio log: http://www.mediafire.com/file/t28yp8s63 ... urrent.log

[Deadlock989]

I am trying to create an addon for DSB and DCM that adds support for more vanilla items.
But it works only with some items.
can some one help me. I guess it works correctly only with items with the prototype name item.

That's right, the way DSB is set up, it expects to be working with prototypes of type "item". The things that are throwing errors for you are all non-items. Science packs are "tools" and ammo is "ammo", etc.

This hasn't come up before because so far no-one has had a need for those things to be stacked on belts.

[Villfuk02]

BUG: Breaks without any reason when used with my mod called CustomModules. Replacing part of code in create_stacking_recipes and create_unstacking_recipes with this fixes the issue:

if icon_size and (icon_size ~= 32 and icon_size ~= 64 and icon_size ~= 128) then
--log("ERROR: DSB asked to use icon_size that is not 32, 64 or 128 ("..item-name..")")
--return
icon_size = 32
end

[mrvn]

What size are your icons?

[Villfuk02]

No items from my mod can be stacked and all icons are 32x32. By disabling parts of my mod I have found out, that everything works until I add a recipe. Then it breaks.
It really makes no sense.

[mrvn]

Code: Select all

--log("ERROR: DSB asked to use icon_size that is not 32, 64 or 128 ("..item-name..")")

What was the item-name there? You should really just comment out the return, not the log.

[Villfuk02]

There is an error in that line. There should be item_name, not item-name.

so a better option is

Code: Select all

if icon_size and (icon_size ~= 32 and icon_size ~= 64 and icon_size ~= 128) then
log("ERROR: DSB asked to use icon_size that is not 32, 64 or 128 ("..item_name..")")
--return
icon_size = 32
end

[Villfuk02]

when fixed, it can finally do wat is it supposed to and I can read the log:

Code: Select all

1.415 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (raw-wood)
   1.415 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (iron-ore)
   1.415 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (copper-ore)
   1.415 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (stone)
   1.415 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (coal)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (iron-plate)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (copper-plate)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (steel-plate)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (stone-brick)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (copper-cable)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (iron-gear-wheel)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (iron-stick)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (sulfur)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (plastic-bar)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (solid-fuel)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (electronic-circuit)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (advanced-circuit)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (processing-unit)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (battery)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (uranium-ore)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (uranium-235)
   1.416 Script @__DeadlockStacking__/prototypes/shared.lua:229: ERROR: DSB asked to use icon_size that is not 32, 64 or 128 (uranium-238)

It errors with every single stackable item. BUT WHY???

My mod doesn't change anything, so why is it erroring like crazy with my mod?

[Deadlock989]

when fixed, it can finally do wat is it supposed to and I can read the log:

It errors with every single stackable item. BUT WHY???

My mod doesn't change anything, so why is it erroring like crazy with my mod?

There is indeed a typo on that line with the variable name, thanks for the report.

As for why your mod is triggering unusual behaviour with vanilla recipe icon sizes, I can't see your code so there's no advice I can give. I'm at work so can't go hunting for your mod right now, but if you post a link to the version that causes the problem, I can take a look later.

[Villfuk02]

this is the mod: https://mods.factorio.com/mod/CustomModules
and i think all versions will cause this issue, but all except the last one have proven to be somewhat buggy or incompatible, so work with the last one (0.16.1)

[Deadlock989]

this is the mod: https://mods.factorio.com/mod/CustomModules
and i think all versions will cause this issue, but all except the last one have proven to be somewhat buggy or incompatible, so work with the last one (0.16.1)

Thanks. The problem is about 95% on my end and 5% on yours. Internally, DSB uses the same function to generate stacked vanilla items as it does when other mods call for their stuff be stacked (with or without a specific icon size). For vanilla stuff, it is supposed to be called without specifying an icon size (which it then sets to 32 as a default), but a derp on my end still has an old local variable (c) specified in the call, and that local c is no longer initialised, which worked fine for the last couple of months as long as nothing else was initialising c (i.e. it was nil). Meanwhile, your mod assigns values to c as a global variable (e.g. in your item.lua where it's used in a for loop) and because CustomModules runs before DSB, that final value of c (probably 1 or something) was being mistakenly passed along to the vanilla stacks generation.

I will fix it on my end later but in the meantime, one should ideally be using local variables by default unless there is a specific need for them to be global, so you could prevent the issue for the time being by making sure your variables are local.