[0.14] What is it used for?

[Coppermine]

Got this in 1.5.6
<snip>

I can see how Helmod might have led to that, and I think I've fixed it in 1.5.7.

[Coppermine]

What is it really used for? 1.5.7

• Avoid crash on unexpected translation response.
• Avoid horizontal scrollbar in recipe pane.

[Coppermine]

I'm still looking for feedback on whether 1.5.6 fixed the problem of being kicked in multiplayer that some people were experiencing. Do let me know if that's still an issue.

[TwentyEighty]

Thanks for the fix! I can't reproduce any of these bugs in 1.5.7 multiplayer

[ptx0]

I'm still looking for feedback on whether 1.5.6 fixed the problem of being kicked in multiplayer that some people were experiencing. Do let me know if that's still an issue.

haven't had it since the update, thanks!

[Helfima]

hello coppermine
I mean you must add more control on the response of tranlation request
some time the key is nil (it was the last bug of TwentyEighty)

Code: Select all

local key = event.localised_string[1] or event.localised_string
  translations[key] = event.result

https://github.com/Helfima/helmod/blob/ ... r.lua#L667

[Squelch]

My apologies for the interjection on the localization handling, but I would like to make a small feature request if I may?

Would you please consider adding resource mine recipes?

There's only one resource mine in vanilla that has a recipe to speak of - Uranium needs sulfuric acid and is easy to remember. Mods that add many more of the same type of resources (I'm currently playing Py) are not so easy. Right now, I'm having to travel to the resource patch, and placing a mine (if the tech is available) just to see what extra materials I need to supply.

Mine with recipe

WIIRUF-Mine-Requirements.PNG (545.3 KiB) Viewed 6435 times

If the tech hasn't yet been researched, the situation is worse because the required materials are not shown for ghost entities.

WIIRUF-Mine-Requirements-Ghost.PNG (498.01 KiB) Viewed 6435 times

As seen in both images. WIIRUF has no recipe for the mine that would allow me to pre-empt any additional requirements.

It could also be said that the vanilla game's info panel should also display consumed resources together with the already shown electricity requirement for ghost entities, but I digress.

[Coppermine]

hello coppermine
I mean you must add more control on the response of tranlation request
some time the key is nil (it was the last bug of TwentyEighty)

Code: Select all

local key = event.localised_string[1] or event.localised_string
  translations[key] = event.result

https://github.com/Helfima/helmod/blob/ ... r.lua#L667

I don't think that's what TwentyEighty's last bug was. That bug was when translations was nil, not when key was nil. I agree that if the key is nil that would be a problem, so if you have seen that happen I'll add some defense against it.

[mrvn]

hello coppermine
I mean you must add more control on the response of tranlation request
some time the key is nil (it was the last bug of TwentyEighty)

Code: Select all

local key = event.localised_string[1] or event.localised_string
  translations[key] = event.result

https://github.com/Helfima/helmod/blob/ ... r.lua#L667

I don't think that's what TwentyEighty's last bug was. That bug was when translations was nil, not when key was nil. I agree that if the key is nil that would be a problem, so if you have seen that happen I'll add some defense against it.

I'm confused. The key is the translation in that code. So a localized_string of nil would be a key of nil. Nothing wrong with having nil as key in a table though. If event.result is nil that's a bigger problem.

Also the key line seems to make no sense. Shouldn't it be the other way around `local key = event.localised_string or event.localised_string[1]`? Because if the localized_string can be indexed then the second part would always be true. But if the localised_string is nil then I think indexing will fail.

[Coppermine]

What is it really used for? 1.5.8

• Show fluid used to mine ore in Mined from pane.
• Have more consistent vertical alignment of text.

[Sander_Bouwhuis]

Thanks Coppermine!

[Coppermine]

What is it really used for? 1.5.9

• Avoid crash on duplicate mining fluid name.

What is it really used for? 1.5.10

• Offer interface for other mods to open WIIRUF window.

[Squelch]

What is it really used for? 1.5.8

• Show fluid used to mine ore in Mined from pane.
• Have more consistent vertical alignment of text.

Fantastic!

Thanks

[orbadon]

Since many mods add fluids with a fuel value, it would be awesome to have that fuel value shown in WIIRUF as a tooltip or listed.

[Coppermine]

What is it really used for? 1.5.11

• Fix crash related to small_slot_button style.

[Sander_Bouwhuis]

Thank you so much for keeping this mod up to date!

[Coppermine]

What is it really used for? 1.5.12

• Fix crash when search term involves parentheses.

[curiosity]

There is a bug. WIIRUF sometimes incorrectly reports the machines that the recipe can be crafted in. In Sea Block:

1.png (30.78 KiB) Viewed 5978 times

2.png (118.71 KiB) Viewed 5978 times