[raiguard][1.1.109] Crash with whitespace save names on linux

[PennyJim]

I presume the save names are ran through a trim function to remove leading and trailing whitespace. This means you have to be careful about names getting trimmed into empty strings.

This works on Mac and displays an in-game error:
(and windows, but the screenshot is mac)

08-13-2024, 12-22-49.png (23.21 KiB) Viewed 565 times

The problem is that on Linux the error resolves to the general crash handler and displays in a popup that then closes the game when closed:

Screenshot from 2024-08-13 12-12-50.png (4.1 KiB) Viewed 565 times

[raiguard]

This only occurs when using non-blocking saving.

[PennyJim]

So this kind of save-name validation is done after the thread is forked off to do the saving?
I would've expected it to happen before.

I would then dismiss the severity of the issue due to it being a hidden experimental feature, but I feel like I remember hearing about it becoming a regular setting in 2.0 or something..?

[raiguard]

I had intended to promote the feature to non-hidden in 2.0, but I haven't been able to fix all of the issues yet, so it will likely remain hidden after all. I have too much to do before the release.

[PennyJim]

Ah that sucks. Good luck with your 2.0 workload <3