[1.0.0] Crash loading invalid blueprint

[benoitranque]

To be clear I know this is entirely my fault.

I just expected the invalid blueprint to throw an error message, not crash the game.

Details on how to reproduce: So I was making railways blueprints, and decided to use the snap to grid feature. To my annoyance, you cannot snap to a rail's midpoint, which is what I intended. In the image below, I intended to snap at the midpoint of the outermost rails.

Not to be deterred by intentional game design, I went to this https://factorio.tmin10.ru/ blueprint encoder/decoder, and changed the x and y values of snap to grid. I then encoded the blueprint again, and attempted to load the blueprint into the game. Factorio did not like that!

stuff

0eNqVmO1umzAYhe/Fv6HC38CtTFUFicUs8SVjpkZV7n0mSZN1odt5f0VW7Ee2jw484oO1/erm4MfI6g+2jM2cxynvgj9u43dW6yJjp+3nnLGmXaZ+jS7f5s1+7Fgdw+oy5g/TuLD6RyL4bmz6bW08zY7VzEc3sIyNzbCNQuN7lkh+PLoE5+fXjLkx+ujddf1lcHob16F1IU24r1xiWtv9jPkFkbF5WtKqabxtk192KWRiH31wh+tf4pw9IQWKlDBSokgNIxWKtDBSo8gKRho4HjwfCzPxgEqYiSdUwUw8Il7AUDwkDpdI4ClxuEYCj4nDRRJ4ThyukiAEBZdJEIKC6yQJQcF9koSg4EJJQlBwoyQelIAbJfGgBNwoRXgvwY1SeFACbpTCgxJwoxQhKLhRihAU3ChNCMp+0Zn8pjzPj+iX25WqF/2Vavaoj0q1vstdnyYHf8jnqXffv6fMeQ/1KFKY2mmeQtx5Lpl/EOSjNYM7+nX4335k8XlYnQ67R+SU430WfH9zArt/TQtASgx7P6n9m7qrhop4k+K+a/PNTWrw+MSNGqJqVwDTEl0bYZZE2UaYFdG2AaYqiLqNMDnVtxGooAo3ApVU40agiqrcCFRTlRuBGqpyI1BLVW4EWlKVG4FWVOUGoLqgKjcC5VTlRqCCqtwIVFKVG4EqqnIjUE1VbgRqqMqNQC1VuRFoSVVuBFpRlRuAmoKq3AiUU5X7CfqaXb8a1n98nMzYLxeW64SSK6sqaywvjE6K+BvBZtOk

Copy blueprint





Warning: the following blueprint will crash your game!

0eNqVmNuOmzAURf/FzzDCd+BXqlEFiUUtcZMxVaNR/r1myCSdhmn3eYqs2Eu2tzYs8cbafnVz8GNk9RtbxmbO45R3wZ+38S9Wa56xy/ZzzVjTLlO/Rpdv82Y/dqyOYXUZ86dpXFj9LRF8Nzb9tjZeZsdq5qMbWMbGZthGofE9SyQ/nl2C8+trxtwYffRuX/8+uHwf16F1IU24r1xiWtv9iPk7ImPztKRV03jb5r5LIRP77IM77X+Ja/aEFChSwkiJIjWMVCjSwkiNIisYaeB48HwszMQDKmEmnlAFM/GIeAFD8ZA4XCKBp8ThGgk8Jg4XSeA5cbhKghAUXCZBCAqukyQEBfdJEoKCCyUJQcGNknhQAm6UxIMScKMU4b0EN0rhQQm4UQoPSsCNUoSg4EYpQlBwozQhKPtJZ/Kb8jw/ol9uV6pe9GeqOaI+KtX6Lnd9mhz8KZ+n3n39njLXI9SjSGFqp3kK8eC5ZP5BkI/WDO7s1+F/+5HFx2F1OuwRkVOO91Hw480J7P41LQApMez9pPZv6qEaKuJNivuuzRc3qcHjEzdqiKpdAUxLdG2EWRJlG2FWRNsGmKog6jbC5FTfRqCCKtwIVFKNG4EqqnIjUE1VbgRqqMqNQC1VuRFoSVVuBFpRlRuA6oKq3AiUU5UbgQqqciNQSVVuBKqoyo1ANVW5EaihKjcCtVTlRqAlVbkRaEVVbgBqCqpyI1BOVe4n6Gu2fzWs//g4mbGfLiz7hJIrqyprLC+MTor4G+qj06Y=

Copy blueprint



Looking at the log, we can see the source of the error:



Solutions: at the very least the game should not crash. Ideally, blueprints should be allowed to snap to the middle of a rail. Without this feature, a rail system of 50x50 tiles (100% roboport coverage) with 4 tiles between rails cannot take advantage of the snapping feature.

Thanks a bunch!

Error Blueprint.cpp:763: this->snapToGrid->x % coreSnapping == 0 was not true

[posila]

Ok, I made it error gracefully.