[0.18.22] Modded game won't load.

This subforum contains all the issues which we already resolved.
Mobius1
Fast Inserter
Fast Inserter
Posts: 191
Joined: Thu Feb 09, 2017 12:05 am
Contact:

[0.18.22] Modded game won't load.

Post by Mobius1 »

Hello,
I'm having an issue that I don't know if you guys can fix or if it's something related to the mods I'm using but for some reason my game doesn't load.
Currently I'm using Factorio 0.18.22 (Steam) with the modpack attached, installed by ModMyFactory app. If I start a new game, I have 0 issues, game loads, saves and everything works fine. After a couple of hours playing the game takes a very very very long time to save, so I had autosave interval every 30 mins. Manual saving of the game took around 5 minutes to complete, but eventually I had to sleep and I closed the game. So when I tried to load the game yesterday, I started loading it at 23:00, today, when it was 14:00 the game still hasn't loaded, but no errors were thrown, no windows hangs, no nothing. Simply stuck on loading screen with the progress bar filled up.
It's a very weird bug and if I need to provide more info for you guys just lemme know.
EDIT: the savefile upload didn't finish and I click submit, attaching it now, sorry. :D
Apparently I cannot send the savefile, it keeps throwing error :

Code: Select all

ERROR
Error parsing server response.
So here's the google drive link for the save: https://drive.google.com/open?id=1Y5xlv ... Lnml-AtI48
Attachments
Krasfact.rar
(1.16 KiB) Downloaded 54 times
Last edited by Mobius1 on Sun May 10, 2020 6:27 pm, edited 2 times in total.

Loewchen
Global Moderator
Global Moderator
Posts: 7089
Joined: Wed Jan 07, 2015 5:53 pm
Contact:

Re: Modded game won't load.

Post by Loewchen »

Post log after a session with the issue and the save, see: 52433.

Mobius1
Fast Inserter
Fast Inserter
Posts: 191
Joined: Thu Feb 09, 2017 12:05 am
Contact:

Re: Modded game won't load.

Post by Mobius1 »

Logfile attached, I posted both of them I don't know which one you need. Thanks for quick response btw!
Attachments
factorio-previous.log
(71.24 KiB) Downloaded 60 times
factorio-current.log
(66.94 KiB) Downloaded 61 times

Mobius1
Fast Inserter
Fast Inserter
Posts: 191
Joined: Thu Feb 09, 2017 12:05 am
Contact:

Re: [0.18.22] Modded game won't load.

Post by Mobius1 »

I've updated factorio to 0.18.24, some of the mods to newest version as well, still no loading, anything I can do?

Zavian
Smart Inserter
Smart Inserter
Posts: 1606
Joined: Thu Mar 02, 2017 2:57 am
Contact:

Re: [0.18.22] Modded game won't load.

Post by Zavian »

My guess is one of the mods in your save is buggy, and is running some Lua in an infinite loop at game load. The simplest way to track that down is probably to disable a few mods at a time, until you can laod the save. When you work out which mod is buggy, you can then report that to the mod author.

User avatar
darkfrei
Smart Inserter
Smart Inserter
Posts: 2883
Joined: Thu Nov 20, 2014 11:11 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by darkfrei »

Zavian wrote:
Sat May 16, 2020 12:11 pm
My guess is one of the mods in your save is buggy, and is running some Lua in an infinite loop at game load. The simplest way to track that down is probably to disable a few mods at a time, until you can laod the save. When you work out which mod is buggy, you can then report that to the mod author.
It would be nice if the game write the mod name/file name before the migration loading or loading of the control.lua file.
So you can understand the problem mod without mod disabling.

Pi-C
Smart Inserter
Smart Inserter
Posts: 1088
Joined: Sun Oct 14, 2018 8:13 am
Contact:

Re: [0.18.22] Modded game won't load.

Post by Pi-C »

darkfrei wrote:
Sat May 16, 2020 12:35 pm
It would be nice if the game write the mod name/file name before the migration loading
You mean something like this?

Code: Select all

3630.146 Script @__attach-notes__/framework.lua:71: 0 [AN] Successfully initialized
3630.146 Checksum for script __attach-notes__/control.lua: 319134954
3630.148 Checksum for script __cargo-ships__/control.lua: 409728531
3630.174 Checksum for script __creative-mod__/control.lua: 967780231
3630.175 Checksum for script __DodgeChallenger_by_Pankeko__/control.lua: 0
3630.180 Checksum for script __eradicators-sudo__/control.lua: 3472922332
3630.181 Checksum for script __LJD_Vehicles_A16__/control.lua: 0
3630.182 Checksum for script __markers__/control.lua: 277108317
3630.183 Checksum for script __shortwave__/control.lua: 1828527205
3630.199 Checksum for script __Bio_Industries__/control.lua: 2739123876
3630.202 Checksum for script __GCKI__/control.lua: 2726291875
3630.205 Checksum for script __VehicleWagon2__/control.lua: 3475492742
3630.216 Applying migration: Aircraft: migration.lua
3630.219 Applying migration: Attach Notes: attach-notes_0.3.0.lua
3630.220 Script @__attach-notes__/migrations/attach-notes_0.3.0.lua:26: Attach notes: Global metatables have been updated
3630.220 Applying migration: Cargo Ships: migrations-0-0-18.lua
3630.220 Applying migration: Cargo Ships: migrations_2.lua
3630.223 Applying migration: Markers: 0.1.2-techs-recipes.lua
3630.372 Checksum for script /home/pc/GOG_Games/Factorio/test/temp/currently-playing/control.lua: 2031664712
:-)
A good mod deserves a good changelog. Here's a tutorial (WIP) about Factorio's way too strict changelog syntax!

posila
Factorio Staff
Factorio Staff
Posts: 5073
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by posila »

Deserializing of global table for mod LootChestPlus gets stuck - so that does not seem like mod's fault. Moving to bug reports for further investigation.

@darkfrei: you can see what mod it got stuck on when verbose logging is enabled.

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4942
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by Klonan »

posila wrote:
Sun May 17, 2020 5:22 am
Deserializing of global table for mod LootChestPlus gets stuck - so that does not seem like mod's fault. Moving to bug reports for further investigation.

@darkfrei: you can see what mod it got stuck on when verbose logging is enabled.
Some guy on twitter complained before about long load/save times, and the culprit was loot chest plus.
It spams global with an obscene amount of data:
https://twitter.com/flexible_games/stat ... 1830648832

The save game linked has a script.dat of over 60MB,
I don't think there is a bug here...

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4942
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by Klonan »

Mobius1 wrote:
Sun May 10, 2020 6:08 pm
Hello,
I'm having an issue that I don't know if you guys can fix or if it's something related to the mods I'm using but for some reason my game doesn't load.
To answer your original question: remove the loot chest plus mod

posila
Factorio Staff
Factorio Staff
Posts: 5073
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by posila »

Either way, I think someone should look into why 15 hours is not enough to load 60MB lua table.

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4942
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by Klonan »

posila wrote:
Sun May 17, 2020 9:07 am
Either way, I think someone should look into why 15 hours is not enough to load 60MB lua table.
Sure, its 1.8 million Lua tables in the saves script data,

I would be super happy if it could be optimized,
From the performance test it looks like its just Lua doing Lua things and taking a long time doing them,

Image

Also slightly off-topic,
I thought it might be easier to look at, if the script data was stored in directories, and a file for each mod,
So we have
saves/my_save_game/script/level.dat
saves/my_save_game/script/mod-krastorio.dat
saves/my_save_game/script/mod-lootChestPlus.dat

Which would give us some more flexibility down the line, for instance, not even loading the global data of a mod that has been removed

User avatar
darkfrei
Smart Inserter
Smart Inserter
Posts: 2883
Joined: Thu Nov 20, 2014 11:11 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by darkfrei »

Klonan wrote:
Sun May 17, 2020 9:06 am
Mobius1 wrote:
Sun May 10, 2020 6:08 pm
Hello,
I'm having an issue that I don't know if you guys can fix or if it's something related to the mods I'm using but for some reason my game doesn't load.
To answer your original question: remove the loot chest plus mod
There is always another mod, that do almost the same job. For example my Active Provider Looting Chest

User avatar
fishycat
Filter Inserter
Filter Inserter
Posts: 281
Joined: Thu Apr 09, 2015 7:38 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by fishycat »

Klonan wrote:
Sun May 17, 2020 9:38 am
Sure, its 1.8 million Lua tables in the saves script data ...
That's... a lot... strange thing is, I just recently finished a playthrough and didn't experience any strange load behavior. Now, is there something I can do to stop this madness?
Also sorry for the inconvenience my mod caused! I know the factory must grow :D

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4942
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by Klonan »

fishycat wrote:
Sun May 17, 2020 10:52 am
That's... a lot... strange thing is, I just recently finished a playthrough and didn't experience any strange load behavior. Now, is there something I can do to stop this madness?
Also sorry for the inconvenience my mod caused! I know the factory must grow :D
Well, I would say if they don't have any lootchests, don't accumulate all the positions in global

User avatar
fishycat
Filter Inserter
Filter Inserter
Posts: 281
Joined: Thu Apr 09, 2015 7:38 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by fishycat »

Klonan wrote:
Sun May 17, 2020 10:58 am
Well, I would say if they don't have any lootchests, don't accumulate all the positions in global
Could you please test my fix, if it still happens? Thanks for your help.
Attachments
LootChestPlus_1.2.7.zip
(3.07 MiB) Downloaded 39 times

Mobius1
Fast Inserter
Fast Inserter
Posts: 191
Joined: Thu Feb 09, 2017 12:05 am
Contact:

Re: [0.18.22] Modded game won't load.

Post by Mobius1 »

Code: Select all

The mod Loot Chest+ (1.2.7) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event LootChestPlus::on_entity_died (ID 4)
__LootChestPlus__/control.lua:31: bad argument #1 of 3 to 'insert' (table expected, got nil)
stack traceback:
	[C]: in function 'insert'
	__LootChestPlus__/control.lua:31: in function <__LootChestPlus__/control.lua:29>
Tried loading the game without the mod, it worked fine, managed to save and reload fine, then when I applied the changes it loaded but immediately thrown this error.

posila
Factorio Staff
Factorio Staff
Posts: 5073
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by posila »

Thanks for the report.
The incredible slow loading of mod data is fixed for 0.18.25

TreefrogGreaken
Long Handed Inserter
Long Handed Inserter
Posts: 58
Joined: Thu May 04, 2017 12:07 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by TreefrogGreaken »

Hey,

Quick question im sure I can test this with my mod.

What does this fix, fix exactly?

The old version of my mod, used to store every water tiles position, type, and some other mod variables in a table when a offshore pump was placed in a water area, as you can imagine, this table could be huge, and would lead to massive save and load times. Would this fix help with a single huge lua (1m+ entries) table?

I've changed it in my current mod to do edge detection instead which solved the issue, with some slight but ok issues.

Nice to know if I could go back to the old method?

posila
Factorio Staff
Factorio Staff
Posts: 5073
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.18.22] Modded game won't load.

Post by posila »

FactorioBot wrote:
Tue May 19, 2020 11:40 am
[*]Fixed performance issue with initializing huge Lua arrays, that could cause loading of some modded saves take forever.
The game will not take forever to load anymore if you save 1M+ array into global

Post Reply

Return to “Resolved Problems and Bugs”