[kovarex] [16.14] Crash when loading v15 game save with logistics mod

[ChubbyHorse]

When attempting to load a game save from v15 with several mods, it crashes.
I've isolated it to the 5dim-core and 5dim-logistics mod.
All other mods were disabled to reduce conflicts and identify which one was the cause.

Steps to reproduce:
Enable 5dim-core and 5dim-logistics mod
Load map
Wait for game to list items that were removed from missing mods
Click "Close" and will display crash dialog within 1 second (typical); sometimes instantly

Game save: http://bighosshosting.com/anewworldlocal-replayx5.zip
(Internet was too slow to upload - kept timing out)

[Loewchen]

Code: Select all

   0.001 2018-01-04 21:03:45; Factorio 0.16.14 (build 34822, win64, alpha)
   0.001 Operating system: Windows 10 (version 1511) 
   0.002 Program arguments: "C:\Users\dgrantham\Desktop\Factorio_0.16\bin\x64\factorio.exe" 
   0.002 Read data path: C:/Users/dgrantham/Desktop/Factorio_0.16/data
   0.002 Write data path: C:/Users/dgrantham/Desktop/Factorio_0.16 [227752/457359MB]
   0.002 Binaries path: C:/Users/dgrantham/Desktop/Factorio_0.16/bin
   0.014 System info: [CPU:        Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, 32 cores, RAM: 131037MB]
   0.014 Display options: [FullScreen: 1] [VSync: 0] [UIScale: system (100.0%)] [MultiSampling: OFF] [Screen: 1] [Lang: en]
   0.015 Available display adapters: 2
   0.015  [0]: \\.\DISPLAY1 - Radeon (TM) RX 480 Graphics {0x8080001, [-1920,0], 1920x1080, 32bit, 60Hz}
   0.015  [1]: \\.\DISPLAY2 - Radeon (TM) RX 480 Graphics {0x8080005, [0,0], 1920x1080, 32bit, 60Hz}
   0.016 Create display on adapter 1. Size 1280x720 at position [310, 162].
   0.147 Initialised Direct3D:[0] Radeon (TM) RX 480 Graphics; driver: aticfx64.dll 22.19.162.4
   0.152   Video memory size (dedicated video/dedicated system/shared system/available): 4044/0/65518/4088 MB
   0.212 DSound: Starting _dsound_update thread
   0.212 DSound: Enter _dsound_update; tid=16056
   0.214 Device reset internal.
   0.222 Desktop composition is active.
   0.222 Graphics settings preset: extreme
   0.222 Graphics options: [Graphics quality: high] [Video memory usage: all] [Light scale: 25%] [DXT: false] [Shader: 1]
   0.222                   [Parallel sprite loading: 1] [Max texture size: 0/8192] [Bmp cache: 0] [Sprite slicing: 1] [Low quality rotation: 0]
   0.376 Info ModManager.cpp:199: Found duplicate mod lh_power_armor_mk3, using higher version (0.0.3 > 0.0.2).
   0.391 Info ModManager.cpp:199: Found duplicate mod Reactor Interface, using higher version (1.0.1 > 1.0.0).
   0.415 Loading mod settings 5dim_core 0.16.4 (settings-updates.lua)
   0.418 Loading mod core 0.0.0 (data.lua)
   0.442 Loading mod base 0.16.14 (data.lua)
   0.654 Loading mod 5dim_core 0.16.4 (data.lua)
   0.715 Loading mod 5dim_logistic 0.16.3 (data.lua)
   0.778 Loading mod base 0.16.14 (data-updates.lua)
   0.838 Loading mod 5dim_core 0.16.4 (data-final-fixes.lua)
   0.902 Checksum for core: 3441685048
   0.902 Checksum of base: 2600059353
   0.902 Checksum of 5dim_core: 3908669320
   0.902 Checksum of 5dim_logistic: 3800065001
   1.061 Loading sounds...
   1.194 Info PlayerData.cpp:65: Local player-data.json available, timestamp 1515117742
   1.194 Info PlayerData.cpp:72: Cloud player-data.json unavailable
   1.395 Loaded shader file C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/graphics/shaders/game.cso
   1.396 Loaded shader file C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/graphics/shaders/zoom-to-world.cso
   1.397 Loaded shader file C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/graphics/shaders/alpha-mask.cso
   1.424 Initial atlas bitmap size is 16384
   1.483 Created atlas bitmap 16384x16372 [none]
   1.486 Created atlas bitmap 16384x4280 [none]
   1.488 Created atlas bitmap 16384x9585 [shadow]
   1.488 Created atlas bitmap 16384x2104 [decal]
   1.488 Created atlas bitmap 8192x5568 [mipmap]
   1.489 Created atlas bitmap 8192x800 [mipmap, smoke]
   1.490 Created atlas bitmap 8192x8160 [linear-minification, mipmap, terrain]
   1.490 Created atlas bitmap 8192x2112 [no-crop, trilinear-filtering, icon, light]
   1.490 Created atlas bitmap 8192x924 [alpha-mask]
  14.344 Sprites loaded
  14.344 Convert atlas 8192x5568 to: mipmap 
  14.508 Convert atlas 8192x800 to: mipmap 
  14.541 Convert atlas 8192x8160 to: min-linear 
  14.766 Convert atlas 8192x2112 to: trilinear-filtering 
  14.825 Convert atlas 8192x924 to: alpha-mask
  15.470 Custom inputs active: 0
  15.488 Info Updater.cpp:750: Downloading https://updater.factorio.com/get-available-versions?username=ChubbyHorse&token=<private>&apiVersion=2
  16.880 0 packages available to download (experimental updates enabled).
  16.941 Factorio initialised
  24.532 Loading map C:\Users\dgrantham\Desktop\Factorio_0.16\saves\anewworldlocal-replay3.zip: 64731710 bytes.
  25.215 Loading Level.dat: 90802857 bytes.
  25.222 Info Scenario.cpp:135: Map version 0.15.21-0
  25.232 Info PrototypeMigrationList.cpp:61: Activating migration base/2017-12-03_Factorio_0.16.0.json
  41.900 Applying migration: Base Mod: 2017-08-08_Factorio_0.16.0.lua
  41.909 Applying migration: Base Mod: 2017-11-07_Factorio_0.16.0.lua
  42.038 Applying migration: Base Mod: 2018-01-04_Factorio_0.16.13.lua
  42.163 Loading script.dat: 226914 bytes.
  42.169 Checksum for script C:/Users/dgrantham/Desktop/Factorio_0.16/temp/currently-playing/control.lua: 3637072345
  42.170 Checksum for script __5dim_core__/control.lua: 229716422
  42.174 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:23: Running silo script migration: 1 -> 2
  42.174 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:118: Executing silo script migration - Mod gui from left to top
  42.175 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  42.175 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  42.175 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  42.175 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  42.175 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  42.175 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  42.175 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  42.175 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  60.305 Loading map C:\Users\dgrantham\Desktop\Factorio_0.16\saves\anewworldlocal-replay4.zip: 64183204 bytes.
  61.030 Loading Level.dat: 89946432 bytes.
  61.039 Info Scenario.cpp:135: Map version 0.15.21-0
  61.048 Info PrototypeMigrationList.cpp:61: Activating migration base/2017-12-03_Factorio_0.16.0.json
  78.396 Applying migration: Base Mod: 2017-08-08_Factorio_0.16.0.lua
  78.413 Applying migration: Base Mod: 2017-11-07_Factorio_0.16.0.lua
  78.571 Applying migration: Base Mod: 2018-01-04_Factorio_0.16.13.lua
  78.716 Loading script.dat: 227020 bytes.
  78.722 Checksum for script C:/Users/dgrantham/Desktop/Factorio_0.16/temp/currently-playing/control.lua: 3637072345
  78.723 Checksum for script __5dim_core__/control.lua: 229716422
  78.727 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:23: Running silo script migration: 1 -> 2
  78.727 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:118: Executing silo script migration - Mod gui from left to top
  78.728 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  78.728 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  78.728 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  78.728 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  78.728 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  78.728 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  78.728 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  78.728 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  78.728 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
  88.470 Loading map C:\Users\dgrantham\Desktop\Factorio_0.16\saves\anewworldlocal-replayx5.zip: 57632503 bytes.
  89.141 Loading Level.dat: 76730414 bytes.
  89.148 Info Scenario.cpp:135: Map version 0.15.36-0
  89.158 Info PrototypeMigrationList.cpp:61: Activating migration base/2017-12-03_Factorio_0.16.0.json
 107.045 Applying migration: Base Mod: 2017-08-08_Factorio_0.16.0.lua
 107.060 Applying migration: Base Mod: 2017-11-07_Factorio_0.16.0.lua
 107.183 Applying migration: Base Mod: 2018-01-04_Factorio_0.16.13.lua
 107.304 Loading script.dat: 263560 bytes.
 107.310 Checksum for script C:/Users/dgrantham/Desktop/Factorio_0.16/temp/currently-playing/control.lua: 3637072345
 107.311 Checksum for script __5dim_core__/control.lua: 229716422
 107.317 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:23: Running silo script migration: 1 -> 2
 107.317 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:118: Executing silo script migration - Mod gui from left to top
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
 107.318 Script @C:/Users/dgrantham/Desktop/Factorio_0.16/data/core/lualib/silo-script.lua:106: Removed "orbital-ion-cannon" from tracked items, as it is not a valid item.
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-caa3te\libraries\stackwalker\stackwalker.cpp (923): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-caa3te\src\util\logger.cpp (371): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-caa3te\src\util\logger.cpp (470): Logger::logStacktrace
c:\cygwin64\tmp\factorio-caa3te\src\util\logging.cpp (78): Logging::logAndAbortOrThrow
c:\cygwin64\tmp\factorio-caa3te\src\util\logging.cpp (73): Logging::logAndAbortOrThrow
c:\cygwin64\tmp\factorio-caa3te\src\logistics\logisticnetwork.cpp (1063): LogisticNetwork::fillRequesters
c:\cygwin64\tmp\factorio-caa3te\src\logistics\logisticnetwork.cpp (1006): LogisticNetwork::fillRequesters
c:\cygwin64\tmp\factorio-caa3te\src\logistics\logisticnetwork.cpp (568): LogisticNetwork::update
c:\cygwin64\tmp\factorio-caa3te\src\force\forcedata.cpp (695): ForceData::update
c:\cygwin64\tmp\factorio-caa3te\src\map\map.cpp (1252): Map::update
c:\cygwin64\tmp\factorio-caa3te\src\game.cpp (153): Game::update
c:\cygwin64\tmp\factorio-caa3te\src\scenario\scenario.cpp (815): Scenario::update
c:\cygwin64\tmp\factorio-caa3te\src\mainloop.cpp (985): MainLoop::gameUpdateStep
c:\cygwin64\tmp\factorio-caa3te\src\mainloop.cpp (852): MainLoop::gameUpdateLoop
c:\cygwin64\tmp\factorio-caa3te\src\util\workerthread.cpp (36): WorkerThread::loop
c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.12.25827\include\thr\xthread (232): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl RouterBase::*)(void) __ptr64,ClientRouter * __ptr64>,std::default_delete<std::tuple<void (__cdecl RouterBase::*)(void) __ptr64,ClientRouter * __ptr64> > > >::_Go
c:\program files (x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.12.25827\include\thr\xthread (211): std::_Pad::_Call_func
d:\th\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC48398102)
00007FFC48398102 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC4A08C5B4)
00007FFC4A08C5B4 (ntdll): (filename not available): RtlUserThreadStart
 110.526 Error LogisticPointFilters.cpp:318: Requested filter not present
Logger::writeStacktrace skipped.
 110.526 Error CrashHandler.cpp:128: Map tick at moment of crash: 148057082
 110.526 Error Util.cpp:67: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
 115.316 Creating crash dump.
 115.432 CrashDump success

[kovarex]

Thanks for the report.

Yes, this is a specific (hopefully last) error related to the new data structure of requesters, this one is related to migrating a save from version where player had more requests. Removing the additional filters didn't update the data structuer properly.

Fixed for 0.16.15