[0.15.34] Some ogg files cause crash

[wvlad]

Code: Select all

for i=1,31 do
	data:extend(
	{
	  {
	    type = "ambient-sound",
	    name = "FTL"..tostring(i),
	    track_type = "main-track",
	    sound =
	    {
	      filename = "__ambientjamsmod-tangerinemusiclabs__/FTL"..tostring(i)..".ogg"
	    }
	  }
	})
end

log

f:\dd\vctools\crt\crtw32\stdcpp\xthrow.cpp (25): std::_Xout_of_range
c:\cygwin64\tmp\factorio-rcwofr\src\package\allegrofiletopackagepathadapter.cpp (40): AllegroFileToPackagePathAdapter::fi_fread
c:\cygwin64\tmp\factorio-rcwofr\libraries\vorbis\src\vorbisfile.c (72): _get_data
c:\cygwin64\tmp\factorio-rcwofr\libraries\vorbis\src\vorbisfile.c (245): _get_prev_page_serial
c:\cygwin64\tmp\factorio-rcwofr\libraries\vorbis\src\vorbisfile.c (642): _open_seekable2
c:\cygwin64\tmp\factorio-rcwofr\libraries\vorbis\src\vorbisfile.c (941): _ov_open2
c:\cygwin64\tmp\factorio-rcwofr\libraries\allegro\addons\acodec\ogg.c (480): _al_load_ogg_vorbis_audio_stream_f
c:\cygwin64\tmp\factorio-rcwofr\src\sound\soundinstance.cpp (46): SoundInstance::play
c:\cygwin64\tmp\factorio-rcwofr\src\sound\ambientpool.cpp (43): AmbientPool::play
c:\cygwin64\tmp\factorio-rcwofr\src\globalcontext.cpp (1032): GlobalContext::updateAmbient
c:\cygwin64\tmp\factorio-rcwofr\src\mainloop.cpp (720): MainLoop::prepare
c:\cygwin64\tmp\factorio-rcwofr\src\mainloop.cpp (485): MainLoop::mainLoopStep
c:\cygwin64\tmp\factorio-rcwofr\src\mainloop.cpp (299): MainLoop::run
c:\cygwin64\tmp\factorio-rcwofr\src\main.cpp (1019): wmain
f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl (253): __scrt_common_main_seh
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF9AFF02D92)
00007FF9AFF02D92 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF9B1E79F64)
00007FF9B1E79F64 (ntdll): (filename not available): RtlUserThreadStart

Ogg files https://1drv.ms/f/s!AhAvFYRsqyUIg7oYRLWgHq75JgbOIw

[impetus maximus]

did you validate the ogg files?

[wvlad]

No, I used AIMP converter to make them from mp3, they should be fine. The stack trace tells that the exception is thrown not by the codec but by factorio code.

I've found that everything works fine when I remove all tags from them. The tags support needs fixing.

[Rseding91]

The stack trace tells that the exception is thrown not by the codec but by factorio code.

No, it crashes there because the codec is trying to do something it shouldn't be doing - read data that isn't available.

That's like saying "The car is defective, it blew up when I put nitroglycerin in the gas tank instead of normal gas"

That being said, is there any kind of ogg validation that can say the files you're using are conformant to the standard?

[Philip017]

That's like saying "The car is defective, it blew up when I put nitroglycerin in the gas tank instead of normal gas"

rsedling you come up with some really good analogies and this one gave me a good laugh, thank you for that!

[kovarex]

As it is suspected that it is most probably problem of the file itself, I'm moving it to pending.
If you provide invalid png, the game will not like it as well.

[wvlad]

Is it invalid if it's opened by most players? I don't think so.

Is there a way to verify the files on windows?

[posila]

I found the problem.
Thanks for posting the report and giving us example of files that cause the crash. It is fixed for 0.16

[impetus maximus]

Is it invalid if it's opened by most players? I don't think so.

Is there a way to verify the files on windows?

well VLC can open files that don't conform to a standard.
check out https://www.xiph.org/oggz/ they have windows binaries. no idea how to use them though.