[boskid][1.1.61] Train not snapping to station on curved rail

[SupplyDepoo]

Locomotive doesn't snap to train stops when on curved rail (partially).

(Pls don't judge my eco-friendly spaghetti style. )

no-snapping.gif (5.87 MiB) Viewed 2765 times

[Koub]

[Koub] I'll move this to won't fix, because I' sure it won't be. The stations are supposed to be on straight rails, almost nothing works well on curved rail stations.

[ickputzdirwech]

Wouldn’t be so sure about that. See 101954

[boskid]

Reason why locomotive was not snapping in that case is that code for snapping was implemented in a "simplified" way where it only computes distance to move a stock based only on X coordinates or only on Y coordinates and for this it was required for a locomotive to be completly vertical or completly horizontal. I did a tiny cleanup of the locomotive's snap to stop code for 1.1.64 where instead of using X or Y coordinate differences (4 completly unrelated cases, one for each main direction) it uses distance to travel along rails. In this "after cleanup" code a locomotive will also snap while it is on curved rails.

[SupplyDepoo]

Thanks, boskid!