[0.13.11] Crash on: "(286): CraftingQueue::transferResult"

[daniel34]

I'll add the other bug I found here because it's so closely related, but feel free to split it.

Using the same scenario as above but having 1000 transport-belts instead of 100 so it doesn't crash:
When cancelling intermediates (prerequisites) from the crafting queue it makes no difference if you remove 1 (left-click) or 5 (right-click), it always removes the same amount and always more than intended.
With the example above when cancelling the iron gear wheels it always removes > 100 gear wheels and > 25 fast transport belts, even when only clicking to remove 1 intermediate.

Also, Shift+click on any intermediate always cancels the complete crafting process. Before the change it only removed the intermediate and crafted all of the end-product possible without it. I saw this as a very nice crafting feature (eg. craft all inserters possible without crafting any circuits).

[Oxyd]

When cancelling intermediates (prerequisites) from the crafting queue it makes no difference if you remove 1 (left-click) or 5 (right-click), it always removes the same amount and always more than intended.
With the example above when cancelling the iron gear wheels it always removes > 100 gear wheels and > 25 fast transport belts, even when only clicking to remove 1 intermediate.

Sounds like not a bug to me. If you craft a gear wheel, it means you have to cancel some of the orders that depended on that gear wheel. And if those orders require more gear wheels than 1 (like the 5 gears required for a red belt), you would now be in a situation where you're crafting intermediates that are no longer needed – so they get cancelled as well.

Also, Shift+click on any intermediate always cancels the complete crafting process. Before the change it only removed the intermediate and crafted all of the end-product possible without it. I saw this as a very nice crafting feature (eg. craft all inserters possible without crafting any circuits).

I suppose I can put that back.

[daniel34]

Sounds like not a bug to me. If you craft a gear wheel, it means you have to cancel some of the orders that depended on that gear wheel. And if those orders require more gear wheels than 1 (like the 5 gears required for a red belt), you would now be in a situation where you're crafting intermediates that are no longer needed – so they get cancelled as well.

It removes more than just intermediates.
I have 800 iron plates and 500 gear wheels in my inventory and I start to craft all possible transport belts (basic).
The crafting queue says 100 gear wheels --> 600 transport belt, which is correct so far.
If I now cancel the 100 gear wheels (with a single left-click, like when removing 1) the crafting queue will go down to only 99 transport belt although it should still be able to craft 500 transport belt.

The number of transport belts to keep crafting is the same number of iron gear wheels I just canceled minus 1.
It somehow cancels the iron gear wheels and then determines how many transport belts to keep crafting depending on how many I canceled (100) instead of how many were originally in the crafting process (500).

[Oxyd]

I found the steps to reproduce while testing another potential bug related to crafting.

• Start a new game
• Research all technologies (or at least Logistics 2 for the fast transport belt)
• Have 1000 iron-plate, 100 iron-gear-wheel and 100 transport-belt (the basic one) in your inventory
• Craft all possible fast transport belts using Shift+click
• Cancel the iron gear wheels from the crafting queue by clicking on it (for 1 item)
• Game crashes

Fixed in 0.13.14.

It removes more than just intermediates.
I have 800 iron plates and 500 gear wheels in my inventory and I start to craft all possible transport belts (basic).
The crafting queue says 100 gear wheels --> 600 transport belt, which is correct so far.
If I now cancel the 100 gear wheels (with a single left-click, like when removing 1) the crafting queue will go down to only 99 transport belt although it should still be able to craft 500 transport belt.

That's a bug then. Fixed in 0.13.14.

Also, Shift+click on any intermediate always cancels the complete crafting process. Before the change it only removed the intermediate and crafted all of the end-product possible without it. I saw this as a very nice crafting feature (eg. craft all inserters possible without crafting any circuits).

This is actually a result of the cancellation bug above. So fixed as well.