"Notice" poping up every time I want to save game

[diablek]

See attachment.
I tried to reinstall the game (Steam), did not fix issue.

[PantherX]

I keep having this issue too.

[sparkylicious21]

I have the same issue every time I go to make a manual save. I played through the first campaign mission before starting a new game as I was curious to see what was new in the campaign. I don't know if the error is because of something tied to the new campaign, as in going through the new campaign causes the error to pop up. Or if it is tied to something else, and it just pops up when you go to save the game. I don't see any other issues other than the error message, but it is annoying to have to close it every time I go to save.

[wheybags]

Does this error happen whn you select a save from one of the old campaigns?

[PantherX]

It happens whenever I try to save a game. It can be a brand new map or an existing save, as soon as you go Menu > Save game, the error immediately pops up. I suspect it might be iterating over the saved games as I have some from the old campaign, and if I select those in the save list, the error pops up again. It probably needs to only display that error if you click on one of the old campaign saves, rather than immediately upon displaying the save window.

[PantherX]

I should also have said that it's still an issue on 0.17.5

[diablek]

It happens whenever I try to save a game. It can be a brand new map or an existing save, as soon as you go Menu > Save game, the error immediately pops up. I suspect it might be iterating over the saved games as I have some from the old campaign, and if I select those in the save list, the error pops up again. It probably needs to only display that error if you click on one of the old campaign saves, rather than immediately upon displaying the save window.

I can confirm that it happens on both old and new saves. Campaign or free play..it doesn't matter.
It pops up when I click "Save game", and I have to close it by clicking CONFIRM, escape key doesn't work sadly, then I save the game, and it pops up again!
Just tried in 0.17.6, still the same. Mods/no mods - doesn't matter

[PantherX]

Still happening on 0.17.7 but I've verified that deleting my old campaign saves (the "A New Hope" ones) means that this message no longer pops up.

The bug therefore is better summarised as: "Error appears on the save game screen whenever old 0.16 campaign save games are present"

These errors are irrelevant anyway as the old saves cannot be loaded in 0.17. It should just ignore them unless a player tries to load an unsupported 0.16 save.

[diablek]

Still happening on 0.17.7 but I've verified that deleting my old campaign saves (the "A New Hope" ones) means that this message no longer pops up.

The bug therefore is better summarised as: "Error appears on the save game screen whenever old 0.16 campaign save games are present"

These errors are irrelevant anyway as the old saves cannot be loaded in 0.17. It should just ignore them unless a player tries to load an unsupported 0.16 save.

Are you saying that I have to delete every save prior to 0.17 in order to fix this?

Also, I noticed that this bug report is under "Campaign/Scenario issues". That's not true, at least not in my case.
Notice pops up in freeplay also. It pops us anytime I want to save a game, and also after I saved it.

[PantherX]

I don't believe it's a campaign issue either. This really should be moved to the main bug report forum as it affects the save game screen globally.

And no, you don't have to delete every 0.16 save, only 0.16 saves that were of the campaign missions. At least, that's what fixed it for me.

[Loewchen]

Someone post a log after a session with the issue please.

[PantherX]

Someone post a log after a session with the issue please.

Sure, here's all the details. The log file doesn't show anything unusual however I have attached an old campaign save that will reliably reproduce the issue. I performed these tests on 0.17.8.

Steps to reproduce:

1. Copy the attached save to the Factorio saves directory (or have an existing game with an old 0.16 campaign save)
2. Start a new game, or load any save game
3. Go to Menu > Save game
4. You are immediately presented with the dialog below
   
5. Additionally, if you then click "Confirm" and select the old save in the save window, you'll see a similar error pop up along with a notice that the save file is invalid or corrupt...
   

If you delete the invalid or corrupt save file from your saves folder and restart the game, the issue no longer occurs.

LOG FILE:

Code: Select all

   0.000 2019-03-08 09:06:12; Factorio 0.17.8 (build 43440, mac, steam)
   0.000 Operating system: macOS 10.14.3
   0.000 Program arguments: "/Users/x/Library/Application Support/Steam/steamapps/common/Factorio/factorio.app/Contents/MacOS/factorio" 
   0.000 Read data path: /Users/x/Library/Application Support/Steam/steamapps/common/Factorio/factorio.app/Contents/data
   0.000 Write data path: /Users/x/Library/Application Support/factorio [723357/1069181MB]
   0.000 Binaries path: /Users/x/Library/Application Support/Steam/steamapps/common/Factorio/factorio.app/Contents
   0.043 System info: [CPU: Intel(R) Core(TM) i5-4570 CPU @ 3.20GHz, 4 cores, RAM: 16384 MB]
   0.043 Display options: [FullScreen: 0] [VSync: 1] [UIScale: automatic (100.0%)] [MultiSampling: OFF] [Screen: 255] [Lang: en]
   0.249 Available displays: 1
   0.249  [0]: iMac - {[0,0], 2560x1440, SDL_PIXELFORMAT_ARGB8888, 60Hz}
   0.368 Initialised OpenGL:[0] NVIDIA GeForce GT 755M OpenGL Engine; driver: 4.1 NVIDIA-12.0.21 355.11.10.50.10.103
   0.368   [Extensions] s3tc:yes; KHR_debug:NO; ARB_clear_texture:NO, ARB_copy_image:NO
   0.368   [Version] 4.1
   0.503 Graphics settings preset: medium-with-low-vram
   0.503   Dedicated video memory size 1024 MB (detected from GeForce GT 755M; VendorID: 0x1022700)
   0.503 Graphics options: [Graphics quality: normal] [Video memory usage: high] [Light scale: 25%] [DXT: low-quality]
   0.503                   [Max load threads: 32] [Max texture size: 4096] [Tex.Stream.: 1] [Rotation quality: low] [Color: 32bit]
   1.014 Loading mod core 0.0.0 (data.lua)
   1.100 Loading mod base 0.17.8 (data.lua)
   1.357 Loading mod base 0.17.8 (data-updates.lua)
   1.491 Checksum for core: 2736929835
   1.491 Checksum of base: 3541142062
   2.251 Loading sounds...
   2.488 Info PlayerData.cpp:69: Local player-data.json unavailable
   2.488 Info PlayerData.cpp:72: Cloud player-data.json available, timestamp 1551950117
   2.665 Crop bitmaps.
   4.926 Parallel Sprite Loader initialized (threads: 3)
   9.220 Initial atlas bitmap size is 4096
   9.224 Created atlas bitmap 4096x4096 [none]
   9.230 Created atlas bitmap 4096x4084 [none]
   9.233 Created atlas bitmap 4096x4092 [none]
   9.235 Created atlas bitmap 4096x4092 [none]
   9.237 Created atlas bitmap 4096x4072 [none]
   9.240 Created atlas bitmap 4096x4096 [none]
   9.240 Created atlas bitmap 4096x360 [none]
   9.240 Created atlas bitmap 4096x1952 [decal]
   9.240 Created atlas bitmap 4096x3824 [low-object]
   9.240 Created atlas bitmap 4096x2000 [mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   9.242 Created atlas bitmap 4096x4080 [terrain, mipmap, linear-minification, linear-mip-level, no-crop]
   9.243 Created atlas bitmap 4096x4064 [terrain, mipmap, linear-minification, linear-mip-level, no-crop]
   9.243 Created atlas bitmap 4096x416 [terrain, mipmap, linear-minification, linear-mip-level, no-crop]
   9.243 Created atlas bitmap 4096x1600 [smoke, mipmap, linear-minification, linear-magnification]
   9.243 Created atlas bitmap 4096x1388 [not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   9.243 Created atlas bitmap 4096x836 [alpha-mask]
   9.246 Created atlas bitmap 4096x4096 [shadow, linear-magnification, alpha-mask]
   9.248 Created atlas bitmap 4096x4096 [shadow, linear-magnification, alpha-mask]
   9.253 Created atlas bitmap 4096x4096 [shadow, linear-magnification, alpha-mask]
   9.253 Created atlas bitmap 4096x528 [shadow, linear-magnification, alpha-mask]
   9.253 Created atlas bitmap 4096x1296 [shadow, mipmap, linear-magnification, alpha-mask]
   9.309 Created virtual atlas pages 4096x4096x2
  10.612 Texture processor created. GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
  10.920 Parallel Sprite Loader initialized (threads: 3)
  36.960 Sprites loaded
  39.389 Generated mipmaps for atlas of size 4096x3824
  42.481 Generated mipmaps for atlas of size 4096x2000
  44.919 Generated mipmaps for atlas of size 4096x4080
  46.811 Generated mipmaps for atlas of size 4096x4064
  50.595 Generated mipmaps for atlas of size 4096x416
  53.911 Generated mipmaps for atlas of size 4096x1600
  53.946 Generated mipmaps for atlas of size 4096x1388
  54.002 Generated mipmaps for atlas of size 4096x1296
  54.035 Generated mipmaps for virtual atlas of size 4096x8192
  54.159 Custom inputs active: 0
  54.326 Factorio initialised
  61.923 Loading Level.dat: 1063826 bytes.
  61.924 Info Scenario.cpp:147: Map version 0.17.8-0
  61.991 Checksum for script /Users/x/Library/Application Support/factorio/temp/currently-playing/control.lua: 1848333929
 124.356 Quitting: user-quit.
 124.356 Info GlobalContext.cpp:678: Waiting for child processes to exit: 
 124.691 Steam API shutdown.
 124.691 Goodbye

SAVE GAME:

[diablek]

Great explanation, PantherX!

Everything he describes was happening to me also. I just removed 0.16 campaign saves and no more error.

[movax20h]

Same here. Linux, amd64, Steam.

I never had 0.16 installed on this machine, however I did play 0.16 before, so maybe it was stored and then restored from Steam Cloud.

[abregado]

Fixed in 17.13 by Rseding