Canceling loading a save using esc key, provokes a crash

[braiam]

How to reproduce:

- Generate new map
- Look for the most effective way to commit suicide (bitters just north the attached save file are willing to assist with the euthanasia)
- Get game over
- Click load game
- Select any save file
- Click load on the saved games window
- Press esc before the game loads

What happens:

Game crashes with the following log:

Code: Select all

43279.137 Loading map /home/user/factorio/saves/_autosave3.zip: 32303421 bytes.
43279.155 Loading Level.dat: 73848847 bytes.
43279.164 Info Scenario.cpp:135: Map version 0.16.15-0
43279.796 Warning Map.cpp:295: Map loading failed: Loading cancelled.
43280.084 Error CrashHandler.cpp:419: Received SIGSEGV
43287.885 Warning Logger.cpp:446: Symbols.size() == 17, usedSize == 15
Factorio crashed. Generating symbolized stacktrace, please wait ...
43293.382 Warning Logger.cpp:446: Symbols.size() == 16, usedSize == 14
#0  0x000000000067f287 in CrashHandler::writeStackTrace(CrashHandler::CrashReason) at /tmp/factorio-q84Xcd/src/Util/CrashHandler.cpp:127
#1  0x000000000067f49a in CrashHandler::SignalHandler(int) at /tmp/factorio-q84Xcd/src/Util/CrashHandler.cpp:421
#2  0x0000000000034720 in ?? at ??:0
#3  0x0000000000ba899e in ScenarioExecutionContext::isPlayerWon() const at /tmp/factorio-q84Xcd/src/Scenario/ScenarioExecutionContext.cpp:158
#4  0x0000000000ba9919 in FinishedGameGui::FinishedGameGui(Scenario&) at /tmp/factorio-q84Xcd/src/Gui/FinishedGameGui.cpp:19
#5  0x00000000008225a9 in InFinishedGameGui::enableGui() at /tmp/factorio-q84Xcd/src/AppManagerStates.cpp:2050
#6  0x0000000000c18518 in AppManager::changeStateInternal() at /tmp/factorio-q84Xcd/src/AppManager.cpp:435
#7  0x0000000000c1c7df in AppManager::popStateOutOfGame() at /tmp/factorio-q84Xcd/src/AppManager.cpp:422
#8  0x0000000000c34bdc in InLoadingGameBox::process(AppManager*) at /tmp/factorio-q84Xcd/src/AppManagerStates.cpp:1190
#9  0x0000000000c350af in AppManager::process() at /tmp/factorio-q84Xcd/src/AppManager.cpp:214
#10 0x0000000000c35596 in MainLoop::prePrepare() at /tmp/factorio-q84Xcd/src/MainLoop.cpp:431
#11 0x0000000000429a17 in MainLoop::mainLoopStep(WorkerThread&, MainLoop::HeavyMode) at /tmp/factorio-q84Xcd/src/MainLoop.cpp:508
#12 (nil) in MainLoop::run(std::experimental::filesystem::Path const&, std::experimental::filesystem::Path const&, bool, bool, std::function<void ()>, std::experimental::filesystem::Path const&, MainLoop::HeavyMode) at /tmp/factorio-q84Xcd/src/MainLoop.cpp:331
#13 0x000000000042b17f in main at /tmp/factorio-q84Xcd/src/Main.cpp:1036
43293.382 Error Util.cpp:67: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.

What should happen instead:

I'm not sure what I should expect to happen other than not crashing. Maybe it should return the user to the saves window?

[Rseding91]

Thanks for the report however there's not much I can do without the save file that shows the problem Please upload it.

[braiam]

It's independent of save file. You just need to get game over (forgot that on the original report). Attached a save file with a bitter base just north for scientific purposes. The world doesn't have 5 minutes of being created.

[Rseding91]

Ok, it's now fixed for the next version of 0.16.