[15.35] Crash when starting headless server w/unknown param

[txr13]

I invoked the headless server's executable, attempting to list the various arguments. The parameter I tried using (-?) was not defined, and this crashed the program.

Code: Select all

user@server:/path/to/factorio/bin/x64# ./factorio -?
terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::program_options::unknown_option> >'
  what():  unrecognised option '-?'
   0.000  Error Util.cpp:80: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
   0.000  Error CrashHandler.cpp:355: Unhandled exception type: N5boost16exception_detail10clone_implINS0_19error_info_injectorINS_15program_options14unknown_optionEEEEE
   0.000  Error CrashHandler.cpp:362: Unhandled exception: unrecognised option '-?'

The program should probably catch unrecognised options and print an error message before exiting gracefully, rather than crashing with an unhandled exception...

[posila]

Thanks for the report.
I've fixed it long in 0.16 long time ago and forgot to backport it when we decided to release 0.15.35. I'll put it to 0.15 branch in case we release 0.15.36