Mining drill prototype storage_slots

[Silari]

Moderator note: Discussion split from viewtopic.php?p=549679#p549679, see quote

https://wiki.factorio.com/Prototype/Min ... age_slots
Does this still do anything?

https://wiki.factorio.com/Version_histo ... .0#0.11.21

Storage slots of mining drill is moddable now. This affects the internal inventory size, so when resource with more different results is mined, no items are lost (as long as the size is big enough). Default value is 1.

Description makes it sound like it's for resources that have more than one item in their minable results, and that without enough slots the remaining results are lost.

[Honktown]

Description makes it sound like it's for resources that have more than one item in their minable results, and that without enough slots the remaining results are lost.

From the quoted version, and other forum posts (some of bob's, google factorio "storage_slots"), that was indeed the case. Now though, that doesn't seem to apply. I wouldn't be surprised if a rather non-descript / very seldom used property became "vestigial" (it was added in 2015).

[Silari]

From the quoted version, and other forum posts (some of bob's, google factorio "storage_slots"), that was indeed the case. Now though, that doesn't seem to apply. I wouldn't be surprised if a rather non-descript / very seldom used property became "vestigial" (it was added in 2015).

I totally overlooked the part of your code that changed iron ore minable and thought they were just mining two types of ore. It's weird that they didn't just change their output slots dynamically like assemblers do. Far as I know that was already a thing in .11. Furnace output slots can be set though, not sure what happens there if there's not enough for a recipe.

[Bilka]

So, this was an interesting one. It looks like the property did indeed do what the 0.11.21 changelog says it does. That is, until 0.15, when another "handle extra item output of mining drills" feature was added, basically a "stuck item queue". It was needed to make the newly introduced mining productivity work smoothly.

So, as noticed, the property doesn't really look like it is doing anything, since the new mitigation is taking care of the original issue. It however still does one thing:

[With storage_slots = 1] if a resource does produce > 1 stack at a time it would cause the drill to take 2 ticks to output all of the items because the inventory size would fill with 1 stack, the other stack gets stuck in the "stuck items" and then the next tick the stuck items get moved to the output inventory.

Well, that is rather complicated and the only usecase of the property (no items lost, just some delay). So, we decided to remove the storage_slots property from the mining drill prototype with 1.1.37, instead the inventory size is calculated automatically based on the minable resources. Basically, the game does it all automatically now. Hurray, less work for modders :)