[Twinsen][1.1.27] Disabling side menu leaves right_side_frame stub.

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5081
Joined: Tue Jul 12, 2016 9:03 am
Contact:

[Twinsen][1.1.27] Disabling side menu leaves right_side_frame stub.

Post by eradicator »

What?

When all three parts of the side menu are disabled via game_view_settings there's still a small bit of frame left. Presumably from the mouse-over entity-tooltip frame.
right_side_frame_stub.png
right_side_frame_stub.png (184.78 KiB) Viewed 775 times


Reproduction

1) Have nothing selected.
2) Use this code:

Code: Select all

/c
  local x = false
  local p = game.player
  for _,v in pairs{'show_minimap','show_research_info','show_side_menu'} do
    p.game_view_settings[v] = x
    end
When something is selected manually or by script the stub vanishes when the selection is updated back to "nil" one tick later.

Code: Select all

/c
  local x = false
  local p = game.player
  for _,v in pairs{'show_minimap','show_research_info','show_side_menu'} do
    p.game_view_settings[v] = x
    end
  p.selected = p.character -- example selection
But this doesn't help in my usecase because i also need to disable 'update_entity_selection'.

Code: Select all

/c
  local x = false
  local p = game.player
  for _,v in pairs{'show_minimap','show_research_info','show_side_menu','update_entity_selection'} do
    p.game_view_settings[v] = x
    end
  p.selected = p.character
  p.selected = nil -- doesn't work, stub still visible
Example mod (you have to drag the screenshot menu away after opening it.)
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
ickputzdirwech
Filter Inserter
Filter Inserter
Posts: 626
Joined: Sun May 07, 2017 10:16 am
Contact:

Re: [1.1.27] Disabling side menu leaves right_side_frame stub.

Post by ickputzdirwech »

The same is true if you disable all mod GUI buttons in the top left corner.
Mods: Shortcuts for 1.1, ick's Sea Block, ick's vanilla tweaks
Tools: Atom language pack
Text quickly seems cold and unfriendly. Be careful how you write and interpret what others have written.
- A reminder for me and all who read what I write

Twinsen
Factorio Staff
Factorio Staff
Posts: 1233
Joined: Tue Sep 23, 2014 7:10 am
Contact:

Re: [1.1.27] Disabling side menu leaves right_side_frame stub.

Post by Twinsen »

Fixed in Version: 1.1.28
Thanks for the report.

ickputzdirwech wrote:
Wed Mar 17, 2021 8:03 am
The same is true if you disable all mod GUI buttons in the top left corner.
Please create a separate detailed report.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 5081
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [1.1.27] Disabling side menu leaves right_side_frame stub.

Post by eradicator »

Twinsen wrote:
Wed Mar 17, 2021 1:39 pm
Fixed in Version: 1.1.28
Thanks for the report.
Nice. Was half expecting it to go to the minor-issues grave :p.
Author of: Belt Planner, Hand Crank Generator, Screenshot Maker, /sudo and more.
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

User avatar
NotRexButCaesar
Smart Inserter
Smart Inserter
Posts: 1007
Joined: Sun Feb 16, 2020 12:47 am
Contact:

Re: [Twinsen][1.1.27] Disabling side menu leaves right_side_frame stub.

Post by NotRexButCaesar »

This will be very nice for the trainsaver mod
III: Think about what you intend to accomplish with an action before execution.
Have you ever heard the gospel? Most have not.

Post Reply

Return to “Resolved Problems and Bugs”