[boskid][1.1.25] Placing a (mod) item destroys a number of items in my inventory - new bug

This subforum contains all the issues which we already resolved.
Honktown
Smart Inserter
Smart Inserter
Posts: 1042
Joined: Thu Oct 03, 2019 7:10 am
Contact:

[boskid][1.1.25] Placing a (mod) item destroys a number of items in my inventory - new bug

Post by Honktown »

fill-storage-tanks_1.125.0.zip
(144.61 KiB) Downloaded 136 times
wat.zip
(749.73 KiB) Downloaded 128 times
same_place_result.png
same_place_result.png (376.15 KiB) Viewed 2389 times
Same code, Factorio 1.0 version of mod that does not have the bug:
fill-storage-tanks_1.0.0.zip
(144.51 KiB) Downloaded 139 times

I used /cheat to test the mod and get the items, but am placing the item(s) with my character. Save (for 1.1.25) is included as example.

The items have the same place_result, so that is probably related.

Additionally, only items which are sorted *left* of the item used are destroyed. If a different tank item (color) is chosen, the tanks after that one do not get obliterated.
I have mods! I guess!
Link
User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 3041
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [boskid][1.1.25] Placing a (mod) item destroys a number of items in my inventory - new bug

Post by boskid »

Ok so the issue emerged after the smart belt building was introduced because in those cases you hold one item (transport belt) and underground may be placed and there have to be some items to be removed directly from the inventory. That logic however was not accounting for the multiple items to place given entity. Issue is now fixed for 1.1.26 and there is a test added so it should not happen again.
Post Reply

Return to “Resolved Problems and Bugs”