[Klonan] [1.1.21] Languages listed as 99% complete in-game, but as complete in crowdin

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
valneq
Smart Inserter
Smart Inserter
Posts: 1135
Joined: Fri Jul 12, 2019 7:43 am
Contact:

[Klonan] [1.1.21] Languages listed as 99% complete in-game, but as complete in crowdin

Post by valneq »

I realized something weird.

Now that 1.1.21 is out, I was hoping that for once, Factorio would be completely translated into German (I am the proofreader for German).
While on Crowdin it looks like this:
languages_100percent.png
languages_100percent.png (75.68 KiB) Viewed 1339 times
in-game I see this:
languages_99percent.png
languages_99percent.png (264.64 KiB) Viewed 1339 times
There was one string (internal name: controls:open-trains-gui) that was added with 1.1.20, which is correctly translated as can be seen here:
most_recent_string.png
most_recent_string.png (93.26 KiB) Viewed 1339 times
Is this a bug? How is the 99% counted in-game vs. the 100% from Crowdin? Are there actually untranslated strings that are not visible on Crowdin?

User avatar
boskid
Factorio Staff
Factorio Staff
Posts: 1647
Joined: Thu Dec 14, 2017 6:56 pm
Contact:

Re: [1.1.21] Langages listed as 99% complete in-game, but as complete in crowdin

Post by boskid »

Percentage values are stored in the data/core/XX/info.json so there is not much of code for me to check. There is however the deploy script which pulls locale from crowdin and computes those values. There is a tiny margin of 5 strings that could be not translated and would still give a 100% translate score, so for the 99% to show up there has to be at least 6 strings that are in english but are missing in german.

For a quick check i sorted both core and base files from english and german and started looking for missing lines in de:

core:
- false
- true
base:
- entity-name.compi-logistics-chest (empty string, but a string)
- entity-name.compi-roboport (empty string, but a string)
- autoplace-control-names.copper-ore
- autoplace-control-names.iron-ore
- autoplace-control-names.coal
- autoplace-control-names.stone

User avatar
valneq
Smart Inserter
Smart Inserter
Posts: 1135
Joined: Fri Jul 12, 2019 7:43 am
Contact:

Re: [1.1.21] Langages listed as 99% complete in-game, but as complete in crowdin

Post by valneq »

boskid wrote:
Sat Feb 06, 2021 8:46 am
core:
- false
- true
Those are "hidden" on Crowdin and are not supposed to be translated according to a comment to "true"
https://crowdin.com/translate/factorio/18/en-de#6204
in fact those were not supposed to be in the locale at all
boskid wrote:
Sat Feb 06, 2021 8:46 am
base:
- entity-name.compi-logistics-chest (empty string, but a string)
- entity-name.compi-roboport (empty string, but a string)
- autoplace-control-names.copper-ore
- autoplace-control-names.iron-ore
- autoplace-control-names.coal
- autoplace-control-names.stone
Well these are either empty, or refer to other strings, and all of these are hidden as well.
So what are we supposed to do about those?
Translate? Not Translate?
Will they stay in the locale, or are they meant to be removed like "true" and "false"?

As a workaround, I have just copied the variable references for the autoplace-control-names for German, but other languages are not aware of this.
A clear policy for those strings would be very much appreciated.

User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 4987
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.1.21] Languages listed as 99% complete in-game, but as complete in crowdin

Post by Klonan »

I am going to remove the stupid strings

Post Reply

Return to “Resolved Problems and Bugs”