[0.11.19] [kovarex] Mining item probability with Productivity modules

[bobingabout]

Another strange one that I discovered while modding.

I added a 1% chance (probability=0.01) to coal to drop Diamond ore.

When mining by hand, it works fine, when mining with an electric drill, it also works fine (not tested burner)
here is a box of results, sped up with a module effect tower and speed modules.
https://www.dropbox.com/s/v37oatstr488z ... 3.png?dl=0

When you use a productivity module, things go wrong.
https://www.dropbox.com/s/487a78fm772ei ... 8.png?dl=0
As you can see here, there are way more diamonds than there are supposed to be.
I'm using a productivity 8 module from my modules mod.

Also, another issue, Resources can only ever give 2 items per mining attempt, if you specify 3 or more, only the first 2 as defined in the results= table are dropped. If there are probabilities involved, the 3rd+ result only drops if one of the previous results fails. This isn't so bad, but when coupled with the issue with the productivity module, only the first 2 results apear, and the 3rd one very rarely.

[kovarex]

Hello, thanks for the report, I fixed the probability calculation logic of the bonus production. I took the liberty of not testing it, as the change was super obvious, so please let me know if it doesn't work as intended in 0.11.21.

I also changed the internal storage of the mining drill to be specifiable in the prototype (storage_slots), the default value will be now (instead of the hardcoded 2 until now).

[bobingabout]

Thanks man, you're the best!

I'll have to have a play with both these fixes when I get ahold of the update.