Screenshot causes crash with very small resolution values

This subforum contains all the issues which we already resolved.
GhostPirate
Inserter
Inserter
Posts: 30
Joined: Fri Dec 28, 2018 4:55 pm
Contact:

Screenshot causes crash with very small resolution values

Post by GhostPirate »

Running the following command is guaranteed to cause a crash:

game.take_screenshot{resolution={0.25,0.25}}

It seems that when the resolution is below 1 pixel, the game cannot handle it gracefully.

Log file attached.
Attachments
factorio-current.log
(7.64 KiB) Downloaded 155 times
User avatar
valneq
Smart Inserter
Smart Inserter
Posts: 1262
Joined: Fri Jul 12, 2019 7:43 am
Contact:

Re: Screenshot causes crash with very small resolution values

Post by valneq »

While it is not acceptable that the game crashes there, I still wonder: why exactly do you even try doing that?
User avatar
NotRexButCaesar
Smart Inserter
Smart Inserter
Posts: 1133
Joined: Sun Feb 16, 2020 12:47 am
Contact:

Re: Screenshot causes crash with very small resolution values

Post by NotRexButCaesar »

valneq wrote: Sat Nov 07, 2020 5:55 am While it is not acceptable that the game crashes there, I still wonder: why exactly do you even try doing that?
The things we have to do to find bugs in this game.
—Crevez, chiens, si vous n'étes pas contents!
GhostPirate
Inserter
Inserter
Posts: 30
Joined: Fri Dec 28, 2018 4:55 pm
Contact:

Re: Screenshot causes crash with very small resolution values

Post by GhostPirate »

@Valneq:

It was actually an accident:

- Try to take screenshots of very big base, but UPS is slow and walking is slow and train tracks are intentionally separate networks to prevent clogs
- Learn to use game.take_screenshot instead of /screenshot command
- Try to use parameters "position", "resolution" and "zoom", but accidentally put "resolution=0.25" instead of "zoom=0.25" for the last parameter
- Get confused when game returns errors that says "expects table, not double"
- Ok, think maybe game allows different x and y zoom amounts, no problem, change "0.25" to "{0.25,0.25}"
- Game crashes
- Read log file to try to understand why
- Realize I have "resolution" twice and no zoom
- Silly me
- Realize game still shouldn't crash
- Submit bug report, knowing full well developers are going to say "... ... ... why?"
User avatar
valneq
Smart Inserter
Smart Inserter
Posts: 1262
Joined: Fri Jul 12, 2019 7:43 am
Contact:

Re: Screenshot causes crash with very small resolution values

Post by valneq »

Fair enough.

After all, you are just following my call for bug reports, see here:
viewtopic.php?f=5&t=90670
posila
Factorio Staff
Factorio Staff
Posts: 5408
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: Screenshot causes crash with very small resolution values

Post by posila »

... ... ... why?

Thanks for the report.
Fixed for 1.1
Post Reply

Return to “Resolved Problems and Bugs”