[Klonan] [1.0] tiny memory "leak" in Wave Defense scenario

This subforum contains all the issues which we already resolved.
Honktown
Smart Inserter
Smart Inserter
Posts: 1045
Joined: Thu Oct 03, 2019 7:10 am
Contact:

[Klonan] [1.0] tiny memory "leak" in Wave Defense scenario

Post by Honktown »

The global.wave_defense.gui_actions[player_index] table does not have elements removed when an upgrade is purchased. This leads to 8 extra values every time an upgrade is purchased.

It may be from these two lines being improperly ordered, line ~1196 of wave_defense.lua:

Code: Select all

  gui.clear()
  deregister_gui(gui)
gui.clear removes the children, so only the upgrade_table is deregistered. If the lines are swapped, it ought to deregister everything, and then 'clear' the children.
I have mods! I guess!
Link
User avatar
Klonan
Factorio Staff
Factorio Staff
Posts: 5304
Joined: Sun Jan 11, 2015 2:09 pm
Contact:

Re: [Klonan] [1.0] tiny memory "leak" in Wave Defense scenario

Post by Klonan »

Nice catch, fixed for the next release
Post Reply

Return to “Resolved Problems and Bugs”