[Bilka] [0.18.36] crash in map-gen with custom elevation

[mrvn]

I'm playing around with the map generator elevation expression trying to make a map with a lot of nice looking islands.

Just playing around changing parameters I suddenly get:

19.772 Error NoiseProgram.cpp Unexpectedly compiled a literal-number expression and got a non-fake register (16) back

and the game crashes hard.

[Bilka]

It doesn't like that your density_expression and spot_quantity_expression are the same value. Is intentional that they are the same, or just some temporary debug stuff?

[mrvn]

I'm just modifying values randomly to see what effect they have on the map preview. No real intention to the values at all yet.

[Bilka]

Okay, that is great. The fix for this is rather risky, so I won't be solving this so close to 1.0. In the meantime, you just have to make sure that you do not use the exact same expressions for the 4 *_expression properties of the spot-noise and the game won't crash on you. A simple "+ 1" does the job.

[mrvn]

Okay, that is great. The fix for this is rather risky, so I won't be solving this so close to 1.0. In the meantime, you just have to make sure that you do not use the exact same expressions for the 4 *_expression properties of the spot-noise and the game won't crash on you. A simple "+ 1" does the job.

Thanks.

FYI: --generate-map-preview is a godsend for testing this stuff.

[Bilka]

Thanks for the report, fixed for version 1.1.