[0.18.21] "PathFindAlgorithm.cpp:1147: abstractNodeIt != search.abstractNodes.end() was not true" when modifying terrain

[Hafnium]

I eliminated all mods except Klonan's transport drones and was able to reproduce this crash by spending 15 minutes adding and removing road tiles connecting the depots in this minimal example. I can't figure out how to reproduce reliably but it seems to be related to removing a tile required to complete a path between depots that is being used by drones.

The stack trace from the attached log file:

Code: Select all

Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-build-tqzfrb\src\ai\pathfindalgorithm.cpp (1147): PathFindAlgorithm::baseDistanceHeuristic
c:\cygwin64\tmp\factorio-build-tqzfrb\src\ai\pathfindalgorithm.cpp (1042): PathFindAlgorithm::expandBaseNode
c:\cygwin64\tmp\factorio-build-tqzfrb\src\ai\pathfindalgorithm.cpp (618): PathFindAlgorithm::baseSearch
c:\cygwin64\tmp\factorio-build-tqzfrb\src\ai\pathfindalgorithm.cpp (466): PathFindAlgorithm::update
c:\cygwin64\tmp\factorio-build-tqzfrb\src\ai\pathfinder.cpp (399): PathFinder::update
c:\cygwin64\tmp\factorio-build-tqzfrb\src\surface\surface.cpp (1565): Surface::update
c:\cygwin64\tmp\factorio-build-tqzfrb\src\map\map.cpp (1698): Map::updateEntities
c:\cygwin64\tmp\factorio-build-tqzfrb\src\game.cpp (201): Game::update
c:\cygwin64\tmp\factorio-build-tqzfrb\src\scenario\scenario.cpp (1219): Scenario::update
c:\cygwin64\tmp\factorio-build-tqzfrb\src\mainloop.cpp (1170): MainLoop::gameUpdateStep
c:\cygwin64\tmp\factorio-build-tqzfrb\src\mainloop.cpp (1037): MainLoop::gameUpdateLoop
c:\cygwin64\tmp\factorio-build-tqzfrb\src\util\workerthread.cpp (49): WorkerThread::loop
c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\thr\xthread (230): std::_LaunchPad<std::unique_ptr<std::tuple<void (__cdecl RouterBase::*)(void),ClientRouter *>,std::default_delete<std::tuple<void (__cdecl RouterBase::*)(void),ClientRouter *> > > >::_Go
c:\program files (x86)\microsoft visual studio\2017\buildtools\vc\tools\msvc\14.15.26726\include\thr\xthread (209): std::_Pad::_Call_func
minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (115): thread_start<unsigned int (__cdecl*)(void * __ptr64)>
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFDD0977BD4)
00007FFDD0977BD4 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFDD23ACE51)
00007FFDD23ACE51 (ntdll): (filename not available): RtlUserThreadStart
Stack trace logging done
1525.994 Error PathFindAlgorithm.cpp:1147: abstractNodeIt != search.abstractNodes.end() was not true

[invisus]

Seems another dupe of 84181

[Hafnium]

Apparently so