[Rseding91] [0.17.69] Crash: EntityWithForce::forceReRegistration

[Haphollas]

I'm using a few mods in my current series including the Repair Turrets and the Construction drones.
When i want to manually pickup a specific construction drone the game will crash. I tried it twice to confirm that it's a repeatable error.
I uploaded the factorio-current.log and the savefile to my google drive here: https://drive.google.com/open?id=1EWQpp ... 10CVy_atyN
How to get the CTD:
Try to manually pickup the construction bot in front of the wall (red circle in the image)
https://drive.google.com/file/d/1dve_RC ... yuv-e/view

[boskid]

I see why it crashes. Construction Drone when mined will trigger on_ai_command_completed(result=defines.behavior_result.fail) event that is catched by mod Construction Drones (construction_drone.lua:2291). It tries to update drone (process_drone_command) but drone is already being destroyed (player manual mining). I will try to make test for this.

[boskid]

Yup, easy to reproduce in vanilla:

1. New map at least 20x20

2. Code: Select all

   /c
       function onAiDone(e)
           if global.biter and global.biter.valid then
               global.biter.teleport({5,5})
           end
       end
       script.on_event(defines.events.on_ai_command_completed, onAiDone);
       global.biter = game.surfaces["nauvis"].create_entity{name="small-biter", position={-5,-5}, force="enemy"};
       global.biter.set_command{type=defines.command.go_to_location, destination={-6,-6}}
       global.biter.destroy()

3. Crash
   log

   Code: Select all

   0.002 2019-09-22 22:57:46; Factorio 0.17.69 (build 47194, win64, steam)

   Code: Select all

   c:\cygwin64\tmp\factorio-build-yogpxy\src\entity\entitywithforce.cpp (32): EntityWithForce::forceReRegistration
   c:\cygwin64\tmp\factorio-build-yogpxy\src\entity\entity.cpp (836): Entity::teleport
   c:\cygwin64\tmp\factorio-build-yogpxy\src\script\luacontrol.cpp (885): LuaControl::luaTeleport
   c:\cygwin64\tmp\factorio-build-yogpxy\src\script\luabinder.hpp (326): LuaBinder<LuaAutoplaceControlPrototype>::callWrapper
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\ldo.c (350): luaD_precall
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\lvm.c (710): luaV_execute
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\lapi.c (1027): f_call
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\ldo.c (137): luaD_rawrunprotected
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\ldo.c (623): luaD_pcall
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\lapi.c (1053): lua_pcallk
   c:\cygwin64\tmp\factorio-build-yogpxy\src\util\luahelper.cpp (3581): LuaHelper::pCallWithStackTrace
   c:\cygwin64\tmp\factorio-build-yogpxy\src\script\luagamescript.cpp (970): LuaGameScript::runEventHandler
   c:\cygwin64\tmp\factorio-build-yogpxy\src\script\luaeventdispatcher.cpp (556): LuaEventDispatcher::run<GameAction>
   c:\cygwin64\tmp\factorio-build-yogpxy\src\script\luaeventdispatcher.cpp (425): LuaEventDispatcher::dispatch
   c:\cygwin64\tmp\factorio-build-yogpxy\src\gameactiondispatcher.cpp (14): GameActionDispatcher::sendToListeners
   c:\cygwin64\tmp\factorio-build-yogpxy\src\ai\commandable.cpp (399): Commandable::onCommandableDestroy
   c:\cygwin64\tmp\factorio-build-yogpxy\src\entity\unit.cpp (516): Unit::onDestroy
   c:\cygwin64\tmp\factorio-build-yogpxy\src\entity\entity.cpp (302): Entity::forceDestroy
   c:\cygwin64\tmp\factorio-build-yogpxy\src\script\luaentity.cpp (695): LuaEntity::luaDestroy
   c:\cygwin64\tmp\factorio-build-yogpxy\src\script\luabinder.hpp (326): LuaBinder<LuaAutoplaceControlPrototype>::callWrapper
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\ldo.c (350): luaD_precall
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\lvm.c (710): luaV_execute
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\lapi.c (1027): f_call
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\ldo.c (137): luaD_rawrunprotected
   c:\cygwin64\tmp\factorio-build-yogpxy\libraries\lua\ldo.c (623): luaD_pcall
   c:\cygwin64\tmp\factorio-build-yogpxy\src\script\luagamescript.cpp (1453): LuaGameScript::runLuaCommand
   c:\cygwin64\tmp\factorio-build-yogpxy\src\script\luacontext.cpp (336): LuaContext::runLuaCommand
   c:\cygwin64\tmp\factorio-build-yogpxy\src\commandprocessor.cpp (1448): CommandProcessor::doExecuteCommand
   c:\cygwin64\tmp\factorio-build-yogpxy\src\commandprocessor.cpp (298): CommandProcessor::executeCommand
   c:\cygwin64\tmp\factorio-build-yogpxy\src\commandprocessor.cpp (245): CommandProcessor::process
   c:\cygwin64\tmp\factorio-build-yogpxy\src\gameactionhandler.cpp (3644): GameActionHandler::writeToConsole
   c:\cygwin64\tmp\factorio-build-yogpxy\src\gameactionhandler.cpp (336): GameActionHandler::actionPerformed
   c:\cygwin64\tmp\factorio-build-yogpxy\src\input\inputhandler.cpp (61): InputHandler::flushActions
   c:\cygwin64\tmp\factorio-build-yogpxy\src\gameactionhandler.cpp (376): GameActionHandler::update
   c:\cygwin64\tmp\factorio-build-yogpxy\src\mainloop.cpp (1157): MainLoop::gameUpdateStep
   c:\cygwin64\tmp\factorio-build-yogpxy\src\mainloop.cpp (1032): MainLoop::gameUpdateLoop
   c:\cygwin64\tmp\factorio-build-yogpxy\src\util\workerthread.cpp (42): WorkerThread::loop

Notes: teleport must be during on_ai_command_completed, must teleport to different chunk and unit must have command set.

[Rseding91]

Thanks for the report. It's now fixed for the next version of 0.17.