[0.17.59] Migration content UI only promts on first load.

[lovely_santa]

Hi,

It's a bit of a complicated bug report. In attachments I added 2 files:

• cab-test-old.zip is a save file, it uses content from the angelsaddons-cab mod version 0.1.3
• angelsaddons-cab_0.1.4 is the updated mod (newer version (0.1.4) than on save file, containing some items, entities that needs migration).

Steps to reproduce how behaviour should work:

1. Load up factorio (fresh load, from desktop)
2. Load up the save I attached
3. Behind the scenes is the engine running the latest migration files (in this case 2019-07-27_angelsaddons-cab_0.1.4.json)
4. When done loading the save, you'll be prompted with this migration content UI:

   

   unknown[1].png (287.75 KiB) Viewed 2225 times

Now the bugged behaviour:

1. Load up factorio (fresh load, from desktop)
2. Load up a fresh game (play -> new game -> generate)
3. Quit the game to menu (not quiting factorio)
4. Load up the save I attached
5. Behind the scenes is the engine running the latest migration files (in this case 2019-07-27_angelsaddons-cab_0.1.4.json)
6. When done loading the save, you'll won't be prompted with this migration content UI, but the content will be migrated.

The wanted behaviour is that the migrated content would be prompted for each save file where migration happened, and not only on the first save you load after opening factorio.

Kind regards
lovely_santa

[slippycheeze]

I can reproduce this independently by loading a map generated with the "Alien Biomes" mod installed, after turning off some of the ground tiles in my current game. That removes them from the list of tile entities in the data phase. The save has map version "0.17.47-0", and is freeplay.

Just loading it, it'll report that it removed a bunch of tiles, which is true and correct.

Start Factorio, New Game, Quit, Load save, and I get no migration dialog.

I have not attached the map as I believe it is covered by the existing versions, but I'm absolutely happy to supply it.

[Rseding91]

Thanks for the report. It's now fixed for the next version of 0.17.