[kovarex] [0.17.50] Rail: Setting a temporary stop resets current stop's cooldown (Minor)

[th0]

Hi,

this is a minor thing I noticed when using temporary stops (ctrl+click) a lot in my rail world: When you assign a temporary stop to a train that currently has a wait condition (default is 5 secs idle for a temporary stop), the train moves a tiny bit and the wait condition is reset, before it proceeds to the new temporary stop.

To reproduce:

1. Have a train
2. Ctrl+Click to assign a temporary stop and wait till the train arrives

train1.png (138.48 KiB) Viewed 3359 times

3. While in cooldown, assign (Ctrl+Click) another temporary station. This will most often cause the train to move a tiny bit and then restart the wait condition.

train2.png (187.32 KiB) Viewed 3359 times

What I would expect:
The train waits until it's (whatever) wait condition is fulfilled and then proceeds to the next stop en route.

Log (don't think it's too interesting tho)

Code: Select all

   0.002 2019-06-22 11:49:39; Factorio 0.17.50 (build 45742, win64, steam)
   0.002 Operating system: Windows 7 Service Pack 1
   0.003 Program arguments: "E:\Steam\steamapps\common\Factorio\bin\x64\Factorio.exe" 
   0.003 Read data path: E:/Steam/steamapps/common/Factorio/data
   0.003 Write data path: C:/Users/thorsten/AppData/Roaming/Factorio [54509/228833MB]
   0.003 Binaries path: E:/Steam/steamapps/common/Factorio/bin
   0.138 System info: [CPU: Intel(R) Core(TM) i3-4170 CPU @ 3.70GHz, 4 cores, RAM: 5088/8131 MB, page: 10557/21334 MB, virtual: 174/8388607 MB, extended virtual: 0 MB]
   0.138 Display options: [FullScreen: 1] [VSync: 1] [UIScale: automatic (100.0%)] [Native DPI: 1] [Screen: 255] [Special: 000] [Lang: en]
   0.296 Available displays: 1
   0.296  [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 750 {0x05, [0,0], 1920x1080, 32bit, 60Hz}
   0.531 [Direct3D11] Display: 0, Output: 0, DisplayAdapter: 0, RenderingAdapter: 0; d3dcompiler_43.dll
   0.661 Initialised Direct3D[0]: NVIDIA GeForce GTX 750; id: 10de-1381; driver: nvd3dumx.dll 10.18.13.6191
   0.661   D3D Feature Level: 11.0, DXGI 1.2+, SwapChain: 1,discard,-,-,-,none
   0.661   BGR 565 Supported: No
   0.661   MaximumFrameLatency: 3, GPUThreadPriority: 0
   0.929 Desktop composition is active.
   0.929 Graphics settings preset: medium-with-low-vram
   0.929   Dedicated video memory size 972 MB
   0.929 Graphics options: [Graphics quality: normal] [Video memory usage: high] [Light scale: 25%] [DXT: low-quality]
   0.929                   [Max load threads: 32] [Max texture size: 0] [Tex.Stream.: 1] [Rotation quality: low] [Color: 32bit]
   0.976 DSound: Starting _dsound_update thread
   0.976 DSound: Enter _dsound_update; tid=2976
   2.466 Loading mod core 0.0.0 (data.lua)
   3.038 Loading mod base 0.17.50 (data.lua)
  11.257 Loading mod base 0.17.50 (data-updates.lua)
  11.456 Checksum for core: 240630728
  11.456 Checksum of base: 1267956446
  12.319 Loading sounds...
  17.020 Info PlayerData.cpp:69: Local player-data.json unavailable
  17.020 Info PlayerData.cpp:72: Cloud player-data.json available, timestamp 1561051180
  17.328 Initial atlas bitmap size is 16384
  17.333 Created atlas bitmap 16384x6208 [none]
  17.334 Created atlas bitmap 4096x1952 [decal]
  17.334 Created atlas bitmap 8192x2240 [low-object]
  17.334 Created atlas bitmap 4096x2192 [mipmap, linear-minification, linear-magnification, linear-mip-level]
  17.335 Created atlas bitmap 8192x4256 [terrain, mipmap, linear-minification, linear-mip-level]
  17.335 Created atlas bitmap 4096x1600 [smoke, mipmap, linear-minification, linear-magnification]
  17.336 Created atlas bitmap 4096x1704 [icon, not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level]
  17.336 Created atlas bitmap 2048x192 [icon-background, not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, ]
  17.336 Created atlas bitmap 4096x836 [alpha-mask]
  17.338 Created atlas bitmap 16384x3184 [shadow, linear-magnification, alpha-mask]
  17.338 Created atlas bitmap 4096x1328 [shadow, mipmap, linear-magnification, alpha-mask]
  17.358 Created virtual atlas pages 4096x4096x2
  17.367 Texture processor created (2048). GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
  63.026 Parallel Sprite Loader initialized (threads: 3)
  68.816 Sprites loaded
  68.877 Generated mipmaps (3) for atlas [2] of size 8192x2240   
  68.907 Generated mipmaps (3) for atlas [3] of size 4096x2192   
  68.981 Generated mipmaps (3) for atlas [4] of size 8192x4256   
  69.012 Generated mipmaps (3) for atlas [5] of size 4096x1600   
  69.032 Generated mipmaps (4) for atlas [6] of size 4096x1704   
  69.053 Generated mipmaps (3) for atlas [10] of size 4096x1328   
  69.054 Custom mipmaps uploaded.
  69.186 Generated mipmaps for virtual atlas of size 4096x8192
  69.244 Custom inputs active: 0
  69.366 Factorio initialised
 250.195 Loading map C:\Users\thorsten\AppData\Roaming\Factorio\saves\00_apr_19.zip: 82639127 bytes.
 250.282 Loading level.dat: 231096340 bytes.
 250.287 Info Scenario.cpp:187: Map version 0.17.50-0
 257.911 Loading script.dat: 339 bytes.
 258.013 Checksum for script C:/Users/thorsten/AppData/Roaming/Factorio/temp/currently-playing/control.lua: 1876143224
1390.536 Info AppManager.cpp:277: Saving to _autosave1 (blocking).
1396.328 Info AppManagerStates.cpp:1752: Saving finished
2763.634 Info AppManager.cpp:277: Saving to _autosave2 (blocking).
2768.964 Info AppManagerStates.cpp:1752: Saving finished
4089.201 Info AppManager.cpp:277: Saving to _autosave3 (blocking).
4095.933 Info AppManagerStates.cpp:1752: Saving finished
17684.080 Info AppManager.cpp:277: Saving to _autosave1 (blocking).
17690.589 Info AppManagerStates.cpp:1752: Saving finished
19101.762 Info AppManager.cpp:277: Saving to _autosave2 (blocking).
19107.293 Info AppManagerStates.cpp:1752: Saving finished
20424.320 Info AppManager.cpp:277: Saving to _autosave3 (blocking).
20429.851 Info AppManagerStates.cpp:1752: Saving finished
21761.576 Info AppManager.cpp:277: Saving to _autosave1 (blocking).
21768.181 Info AppManagerStates.cpp:1752: Saving finished
23157.895 Info AppManager.cpp:277: Saving to _autosave2 (blocking).
23163.151 Info AppManagerStates.cpp:1752: Saving finished
24499.893 Info AppManagerStates.cpp:1752: Saving finished
33420.515 Info AppManager.cpp:277: Saving to _autosave3 (blocking).
33426.339 Info AppManagerStates.cpp:1752: Saving finished
34609.141 Info AppManager.cpp:277: Saving to _autosave1 (blocking).
34615.140 Info AppManagerStates.cpp:1752: Saving finished
38544.079 Info AppManagerStates.cpp:1752: Saving finished
38559.437 Quitting: user-quit.
38561.125 DSound: Stopping voice
38561.125 DSound: Joining thread
38561.127 DSound: Exit _dsound_update; tid=2976
38561.127 DSound: Waiting for voice to stop ... signaled
38561.129 DSound: Joined thread
38561.129 DSound: Destroying thread
38561.129 DSound: Thread destroyed
38561.129 DSound: Releasing buffer
38561.130 DSound: Voice stopped
38561.130 DSound: Deallocating voice
38561.130 DSound: Deallocated voice
38561.657 Steam API shutdown.
38562.041 Goodbye

[EnigmaticAussie]

I'd suspect this is "not-a-bug".

Any time the train schedule is modified, it 'resets'. This includes, but is not limited to:
Adding or removing a station
Setting the train from manual to automatic
A loco or wagon is destroyed
A loco or wagon is added to the train

[th0]

I thought so too, first, but then this behavior is inconsistent which made me file the bug report:

As I noted, the train moves a tiny bit which causes the counter to reset. Now, if it did already and you add another station (thus, modifying the schedule), it does not 'reset' again. It only happens once and it only happens *if* the train moves a few pixels.

[kovarex]

Thanks for the report, it is now fixed for the next version.

[th0]

Thank you!
For your information, the same problem as described above now happens when you delete a previously added second temporary station. I'm aware this is a tiny thing and won't bother anyone, though.

[Xynariz]

I'm aware this is a tiny thing and won't bother anyone, though.

It bothered me, I was just too lazy to write up a proper report. Thank you for doing so!