[wheybags][0.17.36]Fonts are not correct in zh-CN

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
wjy
Burner Inserter
Burner Inserter
Posts: 15
Joined: Sat Jan 12, 2019 6:48 am
Contact:

[wheybags][0.17.36]Fonts are not correct in zh-CN

Post by wjy »

Glad to see you applied much better fonts for zh-TW. However I found that you also applied the same fonts to zh-CN, which is not appropriate.
The basic concept is: zh-CN, zh-TW and ja all share some common "Chinese characters" (Japanese people call these Kanji.) But each region use it's own way to define the strokes of characters. For example:
Image
These 4 characters are all U+66DC. From left to right: Simplified Chinese, Traditional Chinese, Japanese, and Korean variation. This image is from https://blog.typekit.com/2014/07/15/int ... -han-sans/
The correct way to fix this, is to apply different fonts for zh-CN, zh-TW and ja. Both zh-TW and ja appear to be correct now. So the only one need to fix is zh-CN.
I checked info.json and saw you are using NotoSansCJKtc fonts. zh-CN need the NotoSansCJKsc ones. "sc" means Simplified Chinese and "tc" means Traditional Chinese.
The most obvious difference for you is the punctuation. Current punctuation is displayed at center, which is for zh-TW. The expected one is displayed at bottom-left. See screenshots.
Attachments
factorio-current.log
(5.47 KiB) Downloaded 54 times
Screenshot from Interface Settings in 0.17.36 zh-CN. With NotoSansCJKsc fonts. Hover mouse to the marked item to see the tooltip.
Screenshot from Interface Settings in 0.17.36 zh-CN. With NotoSansCJKsc fonts. Hover mouse to the marked item to see the tooltip.
expected.png (27.99 KiB) Viewed 1571 times
Screenshot from Interface Settings in 0.17.36 zh-CN. With default fonts. Hover mouse to the marked item to see the tooltip.
Screenshot from Interface Settings in 0.17.36 zh-CN. With default fonts. Hover mouse to the marked item to see the tooltip.
current.png (28 KiB) Viewed 1571 times
Traditional Chinese proofreader of Factorio.
Crowdin profile: https://crowdin.com/profile/willy04wu69

User avatar
wheybags
Former Staff
Former Staff
Posts: 328
Joined: Fri Jun 02, 2017 1:50 pm
Contact:

Re: [wheybags][0.17.36]Fonts are not correct in zh-CN

Post by wheybags »

Thanks for the report. We are going to ship Noto Sans CJKsc in the next release. We had to convert from otf to ttf ourselves, but it seems to be working properly.
Since you seem to know about this stuff, maybe you could check it out when we release (probably later today). Will leave this thread open for now, but hopefully there will be no issues.

User avatar
wjy
Burner Inserter
Burner Inserter
Posts: 15
Joined: Sat Jan 12, 2019 6:48 am
Contact:

Re: [wheybags][0.17.36]Fonts are not correct in zh-CN

Post by wjy »

I tested 0.17.37 and found the good results. Thank you so much. :D
Traditional Chinese proofreader of Factorio.
Crowdin profile: https://crowdin.com/profile/willy04wu69

User avatar
wheybags
Former Staff
Former Staff
Posts: 328
Joined: Fri Jun 02, 2017 1:50 pm
Contact:

Re: [wheybags][0.17.36]Fonts are not correct in zh-CN

Post by wheybags »

Great! Thanks.

Post Reply

Return to “Resolved Problems and Bugs”