[kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

This subforum contains all the issues which we already resolved.
Post Reply
Qon
Smart Inserter
Smart Inserter
Posts: 1251
Joined: Thu Mar 17, 2016 6:27 am
Contact:

[kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by Qon »

[0.17.28] Blueprint preview is scaled by amount of unique entities
If I have many entities in the same blueprint the preview becomes so small that it's hard to see it's even there at all.
ousu(190410-231206-66).jpg
ousu(190410-231206-66).jpg (724.54 KiB) Viewed 1092 times
Same blueprint as above after filtering away everything except rail:
ousu(190410-231234-89).jpg
ousu(190410-231234-89).jpg (710.88 KiB) Viewed 1092 times
And yes, there is a preview in the first picture! You might need to zoom in to see it...

Image

User avatar
TruePikachu
Filter Inserter
Filter Inserter
Posts: 978
Joined: Sat Apr 09, 2016 8:39 pm
Contact:

Re: [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by TruePikachu »

Blueprint strings?

Qon
Smart Inserter
Smart Inserter
Posts: 1251
Joined: Thu Mar 17, 2016 6:27 am
Contact:

Re: [kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by Qon »

It's just a 224x224 (7x7x chunks) (it tiles at that width if you let edge rails combine) square of rails with any entities inside. It doesn't really matter what it is, should work with anything that that is at least that size because it happens every time I change that thing and make a new blueprint of it and for other things too. But I can provide bp strings anyways in a few hours though.

In general I would advocate for blueprint previews to cover the whole screen unless they can be shown at 1:1 scale when covering less.

kovarex
Factorio Staff
Factorio Staff
Posts: 7431
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: [kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by kovarex »

I tried to reproduce it, but I couldn't.

Could you please post a blueprint string, or any other way to reproduce the problem?

Qon
Smart Inserter
Smart Inserter
Posts: 1251
Joined: Thu Mar 17, 2016 6:27 am
Contact:

Re: [kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by Qon »

Made a blueprint for you <3

And then filtered away everything except rails:


mod-list.json before you ask for it:

Code: Select all

{
  "mods": 
  [
    
    {
      "name": "base",
      "enabled": true
    },
    
    {
      "name": "advanced-combinator",
      "enabled": true
    },
    
    {
      "name": "alien-biomes",
      "enabled": true
    },
    
    {
      "name": "AllMinable",
      "enabled": true
    },
    
    {
      "name": "AllNightVision",
      "enabled": true
    },
    
    {
      "name": "AlmostInvisibleElectricWires",
      "enabled": true
    },
    
    {
      "name": "Armored-train",
      "enabled": true
    },
    
    {
      "name": "artillery-bombardment-remote",
      "enabled": true
    },
    
    {
      "name": "AttilaQuickBarMod",
      "enabled": false
    },
    
    {
      "name": "auto-deploy-robots",
      "enabled": false
    },
    
    {
      "name": "auto-research",
      "enabled": true
    },
    
    {
      "name": "autobuild",
      "enabled": true
    },
    
    {
      "name": "AutoDeconstruct",
      "enabled": true
    },
    
    {
      "name": "AutomaticStationNames",
      "enabled": true
    },
    
    {
      "name": "AutoMine",
      "enabled": true
    },
    
    {
      "name": "Autopole",
      "enabled": false
    },
    
    {
      "name": "Auto_Deploy_Destroyers",
      "enabled": true
    },
    
    {
      "name": "auto_manual_mode",
      "enabled": true
    },
    
    {
      "name": "BlueprintAlignment",
      "enabled": true
    },
    
    {
      "name": "BlueprintExtensions",
      "enabled": true
    },
    
    {
      "name": "BotShots",
      "enabled": true
    },
    
    {
      "name": "Bottleneck",
      "enabled": true
    },
    
    {
      "name": "bullet-trails",
      "enabled": true
    },
    
    {
      "name": "ChangeMapSettings",
      "enabled": true
    },
    
    {
      "name": "ChokePoint",
      "enabled": false
    },
    
    {
      "name": "CleanestConcrete",
      "enabled": true
    },
    
    {
      "name": "Clean_Tree_Burning",
      "enabled": true
    },
    
    {
      "name": "ConcreepRefined",
      "enabled": false
    },
    
    {
      "name": "Construction_Drones",
      "enabled": true
    },
    
    {
      "name": "CorpseFlare",
      "enabled": true
    },
    
    {
      "name": "CoverupFIX",
      "enabled": true
    },
    
    {
      "name": "creative-mod",
      "enabled": true
    },
    
    {
      "name": "creative-world-plus",
      "enabled": false
    },
    
    {
      "name": "ctg",
      "enabled": true
    },
    
    {
      "name": "Cursed-BCR",
      "enabled": false
    },
    
    {
      "name": "Cursed-ELB",
      "enabled": true
    },
    
    {
      "name": "Cursed-PC",
      "enabled": true
    },
    
    {
      "name": "DeleteEmptyChunks",
      "enabled": true
    },
    
    {
      "name": "Enhanced_Map_Colors",
      "enabled": true
    },
    
    {
      "name": "entity-symmetry",
      "enabled": true
    },
    
    {
      "name": "event-listener",
      "enabled": true
    },
    
    {
      "name": "FactorIO",
      "enabled": true
    },
    
    {
      "name": "Factorissimo2",
      "enabled": true
    },
    
    {
      "name": "First_One_Is_Free",
      "enabled": false
    },
    
    {
      "name": "GhostBuster",
      "enabled": true
    },
    
    {
      "name": "GhostInHand",
      "enabled": true
    },
    
    {
      "name": "GhostScanner",
      "enabled": true
    },
    
    {
      "name": "HandyHands",
      "enabled": true
    },
    
    {
      "name": "InfiniteInventory",
      "enabled": true
    },
    
    {
      "name": "Infinizoom",
      "enabled": true
    },
    
    {
      "name": "inland_pumps",
      "enabled": true
    },
    
    {
      "name": "JRadarRange",
      "enabled": true
    },
    
    {
      "name": "JunkTrain2",
      "enabled": true
    },
    
    {
      "name": "LaboriousLaboratory",
      "enabled": true
    },
    
    {
      "name": "lamp-placer",
      "enabled": true
    },
    
    {
      "name": "LandfillEverything",
      "enabled": false
    },
    
    {
      "name": "LD_AutoCircuit",
      "enabled": true
    },
    
    {
      "name": "LightCone",
      "enabled": true
    },
    
    {
      "name": "long-reach",
      "enabled": true
    },
    
    {
      "name": "LootMilitaryScience",
      "enabled": true
    },
    
    {
      "name": "LuaCombinator2",
      "enabled": true
    },
    
    {
      "name": "Lumberjack",
      "enabled": true
    },
    
    {
      "name": "Magic Crafting Stick",
      "enabled": true
    },
    
    {
      "name": "more-minimap-autohide-017",
      "enabled": true
    },
    
    {
      "name": "NaturalTreeExpansionReloaded_016",
      "enabled": false
    },
    
    {
      "name": "Nightfall",
      "enabled": false
    },
    
    {
      "name": "nobeltsvanillagame",
      "enabled": true
    },
    
    {
      "name": "Orbital Ion Cannon",
      "enabled": true
    },
    
    {
      "name": "ore-eraser",
      "enabled": true
    },
    
    {
      "name": "platforms",
      "enabled": true
    },
    
    {
      "name": "power-grid-comb",
      "enabled": true
    },
    
    {
      "name": "pumps-everywhere",
      "enabled": true
    },
    
    {
      "name": "pushbutton",
      "enabled": true
    },
    
    {
      "name": "quick-charge-personal-bots-continued",
      "enabled": true
    },
    
    {
      "name": "QuickItemSwap",
      "enabled": true
    },
    
    {
      "name": "RadarGridGuide",
      "enabled": true
    },
    
    {
      "name": "RadarMarker",
      "enabled": true
    },
    
    {
      "name": "rainbow-player-color",
      "enabled": true
    },
    
    {
      "name": "Rampant",
      "enabled": false
    },
    
    {
      "name": "RecExplo",
      "enabled": true
    },
    
    {
      "name": "recursive-blueprints",
      "enabled": true
    },
    
    {
      "name": "regenerate-terrain",
      "enabled": true
    },
    
    {
      "name": "ReloadMods",
      "enabled": true
    },
    
    {
      "name": "remote-switch",
      "enabled": true
    },
    
    {
      "name": "robotarmy",
      "enabled": true
    },
    
    {
      "name": "romulinhosresearchqueuealwaystrue",
      "enabled": true
    },
    
    {
      "name": "scan-rocket-with-radars",
      "enabled": true
    },
    
    {
      "name": "SchallRadarAlignment",
      "enabled": true
    },
    
    {
      "name": "ShockTurret",
      "enabled": true
    },
    
    {
      "name": "SmoothWarnings",
      "enabled": true
    },
    
    {
      "name": "some-corpsemarker",
      "enabled": true
    },
    
    {
      "name": "some-luaconsole",
      "enabled": true
    },
    
    {
      "name": "Squeak Through",
      "enabled": true
    },
    
    {
      "name": "stdlib",
      "enabled": true
    },
    
    {
      "name": "Swarmageddon",
      "enabled": false
    },
    
    {
      "name": "timeseries",
      "enabled": true
    },
    
    {
      "name": "Underneathies",
      "enabled": true
    },
    
    {
      "name": "VehicleSnap",
      "enabled": true
    },
    
    {
      "name": "VehicleVaulting",
      "enabled": true
    },
    
    {
      "name": "Visible_Bots",
      "enabled": true
    },
    
    {
      "name": "visual-signals",
      "enabled": true
    },
    
    {
      "name": "Waterfill_v17",
      "enabled": true
    },
    
    {
      "name": "WireShortcuts",
      "enabled": true
    },
    
    {
      "name": "ZoomPresets",
      "enabled": true
    }
  ]
}
This happens with or without any modded (added, not counting modified by mods as modded even though maybe I should. But with all my mods I don't know which ones are modified...) entities but they are not all filtered away in the BP string.

kovarex
Factorio Staff
Factorio Staff
Posts: 7431
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: [kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by kovarex »

I still wasn't able to see the behaviour witht he blueprints you provided.
Could you please provide a log, so I can use it to fastly install your mods and test it with those?


User avatar
TruePikachu
Filter Inserter
Filter Inserter
Posts: 978
Joined: Sat Apr 09, 2016 8:39 pm
Contact:

Re: [kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by TruePikachu »

Wow that's a long mod list.

Code: Select all

  22.610 Checksum for core: 3129947997
  22.610 Checksum of autobuild: 2143947757
  22.610 Checksum of base: 3522536122
  22.610 Checksum of event-listener: 0
  22.610 Checksum of pumps-everywhere: 2200105833
  22.610 Checksum of WireShortcuts: 3283877692
  22.610 Checksum of advanced-combinator: 3998266111
  22.610 Checksum of alien-biomes: 1542894928
  22.610 Checksum of AllMinable: 3430334088
  22.610 Checksum of AllNightVision: 3356563070
  22.610 Checksum of AlmostInvisibleElectricWires: 2505559633
  22.610 Checksum of Armored-train: 2189983100
  22.610 Checksum of artillery-bombardment-remote: 479873759
  22.610 Checksum of auto-research: 2958201390
  22.610 Checksum of AutoDeconstruct: 2582707891
  22.610 Checksum of AutomaticStationNames: 3834326227
  22.610 Checksum of AutoMine: 3317421599
  22.610 Checksum of Auto_Deploy_Destroyers: 3221460519
  22.610 Checksum of auto_manual_mode: 1469846610
  22.610 Checksum of BlueprintAlignment: 540160205
  22.610 Checksum of BlueprintExtensions: 708079482
  22.610 Checksum of BotShots: 3476236325
  22.610 Checksum of Bottleneck: 3138809866
  22.610 Checksum of bullet-trails: 3671570151
  22.610 Checksum of ChangeMapSettings: 0
  22.610 Checksum of CleanestConcrete: 2588940844
  22.610 Checksum of Clean_Tree_Burning: 439619535
  22.610 Checksum of Construction_Drones: 397369845
  22.610 Checksum of CorpseFlare: 2917445762
  22.610 Checksum of CoverupFIX: 3543048272
  22.610 Checksum of creative-mod: 1648215781
  22.610 Checksum of ctg: 192680493
  22.610 Checksum of Cursed-ELB: 3595934409
  22.610 Checksum of Cursed-PC: 1673045429
  22.610 Checksum of DeleteEmptyChunks: 1603289931
  22.610 Checksum of Enhanced_Map_Colors: 852423496
  22.610 Checksum of entity-symmetry: 1477678679
  22.610 Checksum of FactorIO: 382107765
  22.610 Checksum of Factorissimo2: 2435265800
  22.610 Checksum of GhostBuster: 0
  22.610 Checksum of GhostInHand: 622217995
  22.610 Checksum of GhostScanner: 2463960828
  22.610 Checksum of HandyHands: 3524404154
  22.610 Checksum of InfiniteInventory: 0
  22.610 Checksum of Infinizoom: 3200612880
  22.610 Checksum of inland_pumps: 706188715
  22.610 Checksum of JRadarRange: 0
  22.610 Checksum of JunkTrain2: 3660575421
  22.610 Checksum of LaboriousLaboratory: 625794798
  22.610 Checksum of lamp-placer: 4058292986
  22.610 Checksum of LD_AutoCircuit: 1828807871
  22.610 Checksum of LightCone: 1829541640
  22.610 Checksum of long-reach: 4166847516
  22.610 Checksum of LootMilitaryScience: 852885833
  22.610 Checksum of LuaCombinator2: 2888245578
  22.610 Checksum of Lumberjack: 59971315
  22.610 Checksum of Magic Crafting Stick: 2985794681
  22.610 Checksum of more-minimap-autohide-017: 149315223
  22.610 Checksum of nobeltsvanillagame: 2040544283
  22.610 Checksum of ore-eraser: 3500431690
  22.610 Checksum of platforms: 2523377883
  22.610 Checksum of power-grid-comb: 497877933
  22.610 Checksum of pushbutton: 2363802393
  22.610 Checksum of quick-charge-personal-bots-continued: 967790344
  22.610 Checksum of QuickItemSwap: 2664132876
  22.610 Checksum of RadarGridGuide: 353437662
  22.610 Checksum of RadarMarker: 159568847
  22.610 Checksum of rainbow-player-color: 3708679149
  22.610 Checksum of RecExplo: 1534181477
  22.610 Checksum of recursive-blueprints: 3675454334
  22.610 Checksum of regenerate-terrain: 1937852475
  22.610 Checksum of ReloadMods: 0
  22.610 Checksum of remote-switch: 483187386
  22.610 Checksum of robotarmy: 3960489440
  22.610 Checksum of romulinhosresearchqueuealwaystrue: 0
  22.610 Checksum of scan-rocket-with-radars: 830876262
  22.610 Checksum of SchallRadarAlignment: 3557162629
  22.610 Checksum of ShockTurret: 2495533186
  22.610 Checksum of SmoothWarnings: 762928482
  22.610 Checksum of some-corpsemarker: 0
  22.610 Checksum of some-luaconsole: 843576745
  22.610 Checksum of Squeak Through: 3677677690
  22.610 Checksum of stdlib: 68667574
  22.610 Checksum of timeseries: 2095443204
  22.610 Checksum of Underneathies: 0
  22.610 Checksum of VehicleSnap: 710606590
  22.610 Checksum of VehicleVaulting: 708514520
  22.610 Checksum of Visible_Bots: 1887227623
  22.610 Checksum of visual-signals: 3605029035
  22.610 Checksum of Waterfill_v17: 1222806128
  22.610 Checksum of ZoomPresets: 1582551238
  22.610 Checksum of Orbital Ion Cannon: 2353690525
Here are a couple semi-suspicious lines:

Code: Select all

  22.610 Checksum of BlueprintAlignment: 540160205
  22.610 Checksum of BlueprintExtensions: 708079482
I don't know what those mods are for, but since they're obviously blueprint-related, they could be having some sort of effect.

EDIT: I just ran some analysis on the blueprint strings, the reference positions of entities in the "bugged" one are within 10 tiles of the limits of the not-bugged one. I also don't see any suspicious entities. Just to confirm, if you re-import the first blueprint string (the really long one), it exhibits the bug still?

Qon
Smart Inserter
Smart Inserter
Posts: 1251
Joined: Thu Mar 17, 2016 6:27 am
Contact:

Re: [kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by Qon »

TruePikachu wrote:
Fri Apr 12, 2019 12:05 am
Wow that's a long mod list.
It's basically all helper mods. My late game base is completely vanilla still. Everything runs exactly the same without the mods. I'm trying to build really big so to be able to compare my SPM with others having any non-vanilla entities to run the base would be cheating :)
TruePikachu wrote:
Fri Apr 12, 2019 12:05 am

Here are a couple semi-suspicious lines:

Code: Select all

  22.610 Checksum of BlueprintAlignment: 540160205
  22.610 Checksum of BlueprintExtensions: 708079482
I don't know what those mods are for, but since they're obviously blueprint-related, they could be having some sort of effect.
Well, they don't.
TruePikachu wrote:
Fri Apr 12, 2019 12:05 am
EDIT: I just ran some analysis on the blueprint strings, the reference positions of entities in the "bugged" one are within 10 tiles of the limits of the not-bugged one. I also don't see any suspicious entities. Just to confirm, if you re-import the first blueprint string (the really long one), it exhibits the bug still?
Yes.

If I disable ALL my mods the bug disappears though. I wish the preview was way bigger though than when it is working because it's still too small for big blueprints.

Qon
Smart Inserter
Smart Inserter
Posts: 1251
Joined: Thu Mar 17, 2016 6:27 am
Contact:

Re: [kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by Qon »

Binary search on my mods revealed that "AlmostInvisibleElectricWires" with "Copper Wire Color" set to non-default (tested 30% and invisble) is causing the bug.

kovarex
Factorio Staff
Factorio Staff
Posts: 7431
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: [kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by kovarex »

Qon wrote:
Fri Apr 12, 2019 9:10 am
Binary search on my mods revealed that "AlmostInvisibleElectricWires" with "Copper Wire Color" set to non-default (tested 30% and invisble) is causing the bug.
Thanks for doing this the work I would have to do, now we are getting somewhere :)

kovarex
Factorio Staff
Factorio Staff
Posts: 7431
Joined: Wed Feb 06, 2013 12:00 am
Contact:

Re: [kovarex] [0.17.28] Blueprint preview is scaled by amount of unique entities

Post by kovarex »

That was something ...

So the mod was rewriting some of the sprites, but one of them didn't have the "no-crop" flag in its definition (the shadow), which caused it to get super small, and confuse the drawing logic a lot.

Long story short, I added a check that the no-crop sprite flag is defined for that sprite (which renders the mod invalid until it is fixed).

Fixed for the next release.


Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: No registered users