[0.17.17] Rocket silo displaying incorrect/unhelpful status information

[Rubydrageon]

Hey,

Not sure if actually a bug, but I noticed the following:

When a rocket is ready to launch (all 100 rocket parts are created) and the silo is set to "auto-launch with cargo" and there are still science packs in the output, but there's no satellite in the input, the status of the rocket silo will say "Item production overload", which seems reasonable at first, because obviously there is an overload of output science packs in the silo, but actually if you have an inserter automatically inserting satellites into the rocket silo it will still do so, unlike with normal assembling machines, where inserters won't insert more ingredients when the machine says "Item production overload".

I guess this happens because the actual product of the silo is the rocket part, not the space science pack, and when all 100 rocket parts are produced, the output is "full". I still find it confusing for the user though, since you never really interact or think about the rocket part, only about the rocket (at least I).

So maybe a message saying "Satellite missing" or something similar would be more appropriate in that case, or the inserter inserting the satellites just shouldn't insert when the machine says production overload.

I hope my explanation is clear, if not I can try to explain further.

Ruby

[tehfreek]

Perhaps special-casing "Ready to Launch" would be the best choice here, since it isn't necessarily a problem to launch without a payload, and a satellite isn't the only possible payload.

[lovely_santa]

Perhaps special-casing "Ready to Launch" would be the best choice here, since it isn't necessarily a problem to launch without a payload, and a satellite isn't the only possible payload.

Since it is in auto launch mode it is waiting for an item in it's rocket inventory.

So a message "waiting on rocket cargo" would be more suited when it is in auto launch mode, and a message "ready to launch" or "idle" when in manual mode?

[Rseding91]

Thanks for the report. The root problem is that the rocket silo is an assembling machine when it never should have been. As such, assembling machines where setup with the status logic and never setup to handle one being a rocket silo.