[Dominik][0.17.8] Crash hovering over pipe

[dakotazinn]

When I hover over a specific underground pipe in a save I am playing in from [0.17.7], the game crashes. However, when the game is saved using [0.17.8], the crash no longer occurs.
This crash also does not occur when overing over other underground pipes
Pipe is located at -47, -257 cursor location

Code: Select all

   0.000 2019-03-07 12:38:40; Factorio 0.17.8 (build 43440, win64, steam)
   0.000 Operating system: Windows 10 (build 17763) 
   0.001 Program arguments: "E:\SteamLibrary\steamapps\common\Factorio\bin\x64\Factorio.exe" 
   0.001 Read data path: E:/SteamLibrary/steamapps/common/Factorio/data
   0.001 Write data path: C:/Users/Dakota/AppData/Roaming/Factorio [24846/242782MB]
   0.001 Binaries path: E:/SteamLibrary/steamapps/common/Factorio/bin
   0.007 System info: [CPU: Intel(R) Core(TM) i7-7820HK CPU @ 2.90GHz, 8 cores, RAM: 9522/16256 MB, page: 16176/22506 MB, virtual: 4332/134217727 MB, extended virtual: 0 MB]
   0.007 Display options: [FullScreen: 1] [VSync: 1] [UIScale: automatic (100.0%)] [MultiSampling: OFF] [Screen: 255] [Lang: en]
   0.016 Available displays: 1
   0.016  [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 1080 {0x05, [0,0], 1920x1080, 32bit, 60Hz}
   0.060 [Direct3D11] Display: 0, Output: 0, DisplayAdapter: 0, RenderingAdapter: 0; d3dcompiler_47.dll
   0.145 Initialised Direct3D[0]: NVIDIA GeForce GTX 1080; id: 10de-1be0; driver: nvldumdx.dll 25.21.14.1735
   0.145   D3D Feature Level: 11.1, DXGI 1.5+
   0.145   [Local Video Memory] Budget: 6867MB, CurrentUsage: 2MB, Reservation: 0/3635MB
   0.145   [Non-Local Vid.Mem.] Budget: 7315MB, CurrentUsage: 0MB, Reservation: 0/3861MB
   0.145   Tiled resources: Tier 2
   0.145   Unified Memory Architecture: No
   0.145   BGR 565 Supported: Yes
   0.145   MaximumFrameLatency: 3, GPUThreadPriority: 0
   0.187 Desktop composition is active.
   0.187 Graphics settings preset: very-high
   0.187   Dedicated video memory size 8079 MB
   0.187 Graphics options: [Graphics quality: high] [Video memory usage: all] [Light scale: 100%] [DXT: high-quality]
   0.187                   [Max load threads: 32] [Max texture size: 0] [Tex.Stream.: 0] [Rotation quality: normal] [Color: 32bit]
   0.274 DSound: Starting _dsound_update thread
   0.274 DSound: Enter _dsound_update; tid=31760
   1.000 Razer Chroma Controller initialized.
   1.078 Loading mod core 0.0.0 (data.lua)
   1.160 Loading mod base 0.17.8 (data.lua)
   1.366 Loading mod base 0.17.8 (data-updates.lua)
   1.466 Checksum for core: 2736929835
   1.466 Checksum of base: 3541142062
   1.953 Loading sounds...
   2.039 Info PlayerData.cpp:69: Local player-data.json unavailable
   2.039 Info PlayerData.cpp:72: Cloud player-data.json available, timestamp 1551983805
   2.166 Initial atlas bitmap size is 16384
   2.197 Created atlas bitmap 16384x16384 [none]
   2.200 Created atlas bitmap 16384x11296 [none]
   2.200 Created atlas bitmap 16384x2116 [decal]
   2.201 Created atlas bitmap 16384x3808 [low-object]
   2.202 Created atlas bitmap 16384x1888 [mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   2.203 Created atlas bitmap 16384x6880 [terrain, mipmap, linear-minification, linear-mip-level, no-crop]
   2.203 Created atlas bitmap 16384x480 [smoke, mipmap, linear-minification, linear-magnification]
   2.203 Created atlas bitmap 16384x456 [not-compressed, mipmap, linear-minification, linear-magnification, linear-mip-level, no-crop, no-scale]
   2.204 Created atlas bitmap 16384x748 [alpha-mask]
   2.206 Created atlas bitmap 16384x12640 [shadow, linear-magnification, alpha-mask]
   2.206 Created atlas bitmap 16384x1264 [shadow, mipmap, linear-magnification, alpha-mask]
   2.213 Texture processor created. GPU accelerated compression Supported: yes, Enabled: yes/yes. Test passed. YCoCgDXT PSNR: 35.83, BC3 PSNR: 33.82
   3.056 Parallel Sprite Loader initialized (threads: 7)
   9.910 Sprites loaded
   9.975 Generated mipmaps for atlas of size 16384x3808
  10.008 Generated mipmaps for atlas of size 16384x1888
  10.040 Generated mipmaps for atlas of size 16384x6880
  10.051 Generated mipmaps for atlas of size 16384x480
  10.061 Generated mipmaps for atlas of size 16384x456
  10.072 Generated mipmaps for atlas of size 16384x1264
  10.077 Custom inputs active: 0
  10.133 Factorio initialised
  64.432 Loading map C:\Users\Dakota\AppData\Roaming\Factorio\saves\_autosave1.zip: 7489363 bytes.
  64.506 Loading Level.dat: 14926177 bytes.
  64.509 Info Scenario.cpp:147: Map version 0.17.7-2
  65.345 Loading script.dat: 328 bytes.
  65.349 Checksum for script C:/Users/Dakota/AppData/Roaming/Factorio/temp/currently-playing/control.lua: 1848333929
 186.991 Loading map C:\Users\Dakota\AppData\Roaming\Factorio\saves\_autosave1.zip: 7489363 bytes.
 187.094 Loading Level.dat: 14926177 bytes.
 187.098 Info Scenario.cpp:147: Map version 0.17.7-2
 187.874 Loading script.dat: 328 bytes.
 187.877 Checksum for script C:/Users/Dakota/AppData/Roaming/Factorio/temp/currently-playing/control.lua: 1848333929
 573.620 Loading map C:\Users\Dakota\AppData\Roaming\Factorio\saves\v17.1 Update.zip: 7053731 bytes.
 573.689 Loading Level.dat: 15118014 bytes.
 573.693 Info Scenario.cpp:147: Map version 0.17.8-0
 573.993 Loading script.dat: 328 bytes.
 573.995 Checksum for script C:/Users/Dakota/AppData/Roaming/Factorio/temp/currently-playing/control.lua: 1848333929
 579.695 Loading map C:\Users\Dakota\AppData\Roaming\Factorio\saves\_autosave1.zip: 7489363 bytes.
 579.772 Loading Level.dat: 14926177 bytes.
 579.775 Info Scenario.cpp:147: Map version 0.17.7-2
 580.543 Loading script.dat: 328 bytes.
 580.545 Checksum for script C:/Users/Dakota/AppData/Roaming/Factorio/temp/currently-playing/control.lua: 1848333929
 588.391 Error CrashHandler.cpp:515: Received SIGSEGV
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-build-k9grxp\libraries\stackwalker\stackwalker.cpp (924): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-build-k9grxp\src\util\logger.cpp (415): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-build-k9grxp\src\util\logger.cpp (566): Logger::logStacktrace
c:\cygwin64\tmp\factorio-build-k9grxp\src\util\crashhandler.cpp (169): CrashHandler::writeStackTrace
c:\cygwin64\tmp\factorio-build-k9grxp\src\util\crashhandler.cpp (524): CrashHandler::SignalHandler
minkernel\crts\ucrt\src\appcrt\misc\exception_filter.cpp (219): _seh_filter_exe
f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl (304): `__scrt_common_main_seh'::`1'::filt$0
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF7F722E588)
00007FF7F722E588 (Factorio): (filename not available): __C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC78FC468F)
00007FFC78FC468F (ntdll): (filename not available): _chkstk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC78F24BEF)
00007FFC78F24BEF (ntdll): (filename not available): RtlWalkFrameChain
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC78FC33FE)
00007FFC78FC33FE (ntdll): (filename not available): KiUserExceptionDispatcher
c:\cygwin64\tmp\factorio-build-k9grxp\src\entity\pipetoground.cpp (95): PipeToGround::drawSelectionInfo
c:\cygwin64\tmp\factorio-build-k9grxp\src\graphics\cursorrenderer.cpp (260): CursorRenderer::renderEntitySelection
c:\cygwin64\tmp\factorio-build-k9grxp\src\graphics\cursorrenderer.cpp (173): CursorRenderer::renderPlayerCursor
c:\cygwin64\tmp\factorio-build-k9grxp\src\graphics\cursorrenderer.cpp (77): CursorRenderer::prepare
c:\cygwin64\tmp\factorio-build-k9grxp\src\graphics\gamerenderer.cpp (149): GameRenderer::prepareJob
c:\cygwin64\tmp\factorio-build-k9grxp\src\graphics\gamerenderer.cpp (129): GameRenderer::prepare
c:\cygwin64\tmp\factorio-build-k9grxp\src\gameview.cpp (1150): GameView::prepareRender
c:\cygwin64\tmp\factorio-build-k9grxp\src\mainloop.cpp (903): MainLoop::prepare
c:\cygwin64\tmp\factorio-build-k9grxp\src\mainloop.cpp (598): MainLoop::mainLoopStep
c:\cygwin64\tmp\factorio-build-k9grxp\src\mainloop.cpp (366): MainLoop::run
c:\cygwin64\tmp\factorio-build-k9grxp\src\main.cpp (1242): wmain
f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl (288): __scrt_common_main_seh
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC78E381F4)
00007FFC78E381F4 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFC78F8A251)
00007FFC78F8A251 (ntdll): (filename not available): RtlUserThreadStart
Stack trace logging done
 590.079 Error CrashHandler.cpp:174: Map tick at moment of crash: 3744371
 590.079 Error Util.cpp:97: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
 593.520 Error CrashHandler.cpp:221: Heap validation: success.
 593.522 Creating crash dump.
 593.739 CrashDump success

[Dominik]

maybe related to 66966

[Dominik]

I have fixed the crash (will update this once I add it to the release) but I still don't know how the pipe disconnection happened in the first place. Is it possible that there was some sort of fluid mixing along that connection in the past?
I will add something into the code to fix it on load, but then I won't know anymore if this error happens. So if you could help me find the reason, I would be very grateful.
Cases where the pipes should get into this disconnected state (marked by the red color between them) is when there are two underground pipes with a different fluid that would connect, but there is another underground pipe between them preventing the connection. But once the middle one is removed/rotated/replaced the disconnected state is created. And there were various bugs around it like this viewtopic.php?f=47&t=66118.
So can you recall if something of that sort happened there in the past?

[dakotazinn]

There might have been some Water mixing in that pipeline. However, I don't think any fluid truly flowed through that pipe.
I believe that the only thing that happened with that pipeline was that I connected it to the input for water on the Chemical plant (Light Oil/Water>Petroleum) instead of the Light Oil input