[0.16.51] Crash with mod

[darkfrei]

Get a crash on mod creating, may come from fish, that has only one picture (vanilla has two pictures, but second was not used):

Code: Select all

local pictures = 
  {
    {
      filename = mod_name..'/graphics/entities/'..file_name,
      scale = 4,
      priority = "extra-high",
      width = 5,
      height = 8
    }
  }
  
fish.pictures = pictures

2018-11-17 20_39_41-Factorio 0.16.51.png (223.66 KiB) Viewed 3419 times

last part of factorio-current.log

Code: Select all

  22.314 Checksum for script D:/Factorio_0.16/temp/currently-playing/control.lua: 950616531
  22.316 Checksum for script __ConductingBelt__/control.lua: 2218516650
  22.319 Checksum for script __NewGamePlus__/control.lua: 2383505054
  22.320 Checksum for script __OilBurnerGenerator__/control.lua: 839540749
  22.322 Checksum for script __RITEG__/control.lua: 826572389
  22.323 Checksum for script __SmogSolarPanels__/control.lua: 3029295295
  22.324 Checksum for script __bobplates__/control.lua: 2137047030
  23.190 Device reset internal.
1615.712 Error CrashHandler.cpp:522: Received SIGSEGV
Factorio crashed. Generating symbolized stacktrace, please wait ...
c:\cygwin64\tmp\factorio-build-gumsut\libraries\stackwalker\stackwalker.cpp (924): StackWalker::ShowCallstack
c:\cygwin64\tmp\factorio-build-gumsut\src\util\logger.cpp (408): Logger::writeStacktrace
c:\cygwin64\tmp\factorio-build-gumsut\src\util\logger.cpp (521): Logger::logStacktrace
c:\cygwin64\tmp\factorio-build-gumsut\src\util\crashhandler.cpp (169): CrashHandler::writeStackTrace
c:\cygwin64\tmp\factorio-build-gumsut\src\util\crashhandler.cpp (531): CrashHandler::SignalHandler
d:\th\minkernel\crts\ucrt\src\appcrt\misc\exception_filter.cpp (219): _seh_filter_exe
d:\th\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp (117): `thread_start<unsigned int (__cdecl*)(void * __ptr64)>'::`1'::filt$0
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FF63CC94B2C)
00007FF63CC94B2C (factorio): (filename not available): __C_specific_handler
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA6B29ED3D)
00007FFA6B29ED3D (ntdll): (filename not available): _chkstk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA6B206C86)
00007FFA6B206C86 (ntdll): (filename not available): RtlWalkFrameChain
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA6B29DC6E)
00007FFA6B29DC6E (ntdll): (filename not available): KiUserExceptionDispatcher
c:\cygwin64\tmp\factorio-build-gumsut\src\graphics\spritedraworder.cpp (112): SpriteDrawOrder::render
c:\cygwin64\tmp\factorio-build-gumsut\src\graphics\drawengine.cpp (443): DrawEngine::renderShadowsToWorkingSprite
c:\cygwin64\tmp\factorio-build-gumsut\src\graphics\drawengine.cpp (141): DrawEngine::render
c:\cygwin64\tmp\factorio-build-gumsut\src\graphics\gamerenderer.cpp (201): GameRenderer::render
c:\cygwin64\tmp\factorio-build-gumsut\src\mainloop.cpp (1065): MainLoop::render
c:\cygwin64\tmp\factorio-build-gumsut\src\mainloop.cpp (553): MainLoop::mainLoopStep
c:\cygwin64\tmp\factorio-build-gumsut\src\mainloop.cpp (338): MainLoop::run
c:\cygwin64\tmp\factorio-build-gumsut\src\main.cpp (1130): wmain
f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl (283): __scrt_common_main_seh
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA6A523034)
00007FFA6A523034 (KERNEL32): (filename not available): BaseThreadInitThunk
ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 00007FFA6B271471)
00007FFA6B271471 (ntdll): (filename not available): RtlUserThreadStart
Stack trace logging done
1619.004 Error CrashHandler.cpp:174: Map tick at moment of crash: 196044
1619.004 Error Util.cpp:67: Unexpected error occurred. If you're running the latest version of the game you can help us solve the problem by posting the contents of the log file on the Factorio forums.
Please also include the save file(s), any mods you may be using, and any steps you know of to reproduce the crash.
1636.632 Uploading log file
1636.648 Error CrashHandler.cpp:227: Heap validation: success.
1636.668 Creating crash dump.
1636.753 CrashDump success

Dump:

[darkfrei]

So, I can reproduce it:

2018-11-17 21_33_19-Factorio 0.16.51.png (103.8 KiB) Viewed 3411 times

[posila]

It is crashing at drawing shadow layer, so probably not fish. Does it crash with the latest version of the mod you released to mod portal?

[darkfrei]

On the same place I can't reproduce when the fish's picture was doubled.

Code: Select all

local fish = data.raw.fish.fish
local file_name = 'fish.png'
local pictures = 
  {
    {
      filename = mod_name..'/graphics/entities/'..file_name,
      scale = 4,
      priority = "extra-high",
      width = 5,
      height = 8
    },
    {
      filename = mod_name..'/graphics/entities/'..file_name,
      scale = 4,
      priority = "extra-high",
      width = 5,
      height = 8
    }
  }
  
fish.pictures = pictures

[darkfrei]

It is crashing at drawing shadow layer, so probably not fish. Does it crash with the latest version of the mod you released to mod portal?

No, it comes only on the fish.

[posila]

Thanks for the report.
The problem was missing migration when number of variations of fish sprite changed, so it was trying to draw sprite that doesn't exist.

Fixed for 0.17