[0.16.51] Crash with mod

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
darkfrei
Smart Inserter
Smart Inserter
Posts: 2035
Joined: Thu Nov 20, 2014 11:11 pm
Contact:

[0.16.51] Crash with mod

Post by darkfrei » Sat Nov 17, 2018 8:11 pm

Get a crash on mod creating, may come from fish, that has only one picture (vanilla has two pictures, but second was not used):

Code: Select all

local pictures = 
  {
    {
      filename = mod_name..'/graphics/entities/'..file_name,
      scale = 4,
      priority = "extra-high",
      width = 5,
      height = 8
    }
  }
  
fish.pictures = pictures
2018-11-17 20_39_41-Factorio 0.16.51.png
2018-11-17 20_39_41-Factorio 0.16.51.png (223.66 KiB) Viewed 491 times
last part of factorio-current.log
Dump:
Attachments
factorio-dump-current.dmp
(551.14 KiB) Downloaded 14 times

User avatar
darkfrei
Smart Inserter
Smart Inserter
Posts: 2035
Joined: Thu Nov 20, 2014 11:11 pm
Contact:

Re: [0.16.51] Crash with mod

Post by darkfrei » Sat Nov 17, 2018 8:35 pm

So, I can reproduce it:
2018-11-17 21_33_19-Factorio 0.16.51.png
2018-11-17 21_33_19-Factorio 0.16.51.png (103.8 KiB) Viewed 483 times
Attachments
_autosave2.zip
(1.4 MiB) Downloaded 16 times
factorio-dump-current.dmp
(561.72 KiB) Downloaded 16 times
factorio-current.log
(14.38 KiB) Downloaded 18 times

posila
Factorio Staff
Factorio Staff
Posts: 3624
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.16.51] Crash with mod

Post by posila » Sat Nov 17, 2018 8:39 pm

It is crashing at drawing shadow layer, so probably not fish. Does it crash with the latest version of the mod you released to mod portal?

User avatar
darkfrei
Smart Inserter
Smart Inserter
Posts: 2035
Joined: Thu Nov 20, 2014 11:11 pm
Contact:

Re: [0.16.51] Crash with mod

Post by darkfrei » Sat Nov 17, 2018 9:10 pm

On the same place I can't reproduce when the fish's picture was doubled.

Code: Select all

local fish = data.raw.fish.fish
local file_name = 'fish.png'
local pictures = 
  {
    {
      filename = mod_name..'/graphics/entities/'..file_name,
      scale = 4,
      priority = "extra-high",
      width = 5,
      height = 8
    },
    {
      filename = mod_name..'/graphics/entities/'..file_name,
      scale = 4,
      priority = "extra-high",
      width = 5,
      height = 8
    }
  }
  
fish.pictures = pictures
Last edited by darkfrei on Sat Nov 17, 2018 9:12 pm, edited 2 times in total.

User avatar
darkfrei
Smart Inserter
Smart Inserter
Posts: 2035
Joined: Thu Nov 20, 2014 11:11 pm
Contact:

Re: [0.16.51] Crash with mod

Post by darkfrei » Sat Nov 17, 2018 9:11 pm

posila wrote:
Sat Nov 17, 2018 8:39 pm
It is crashing at drawing shadow layer, so probably not fish. Does it crash with the latest version of the mod you released to mod portal?
No, it comes only on the fish.

posila
Factorio Staff
Factorio Staff
Posts: 3624
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.16.51] Crash with mod

Post by posila » Sat Nov 17, 2018 10:40 pm

Thanks for the report.
The problem was missing migration when number of variations of fish sprite changed, so it was trying to draw sprite that doesn't exist.

Fixed for 0.17

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: No registered users