[Rseding91] Max upload speed has exponential decay

[BenSeidel]

Hi,
When you set "Max upload speed" for a multiplayer game any connecting players have to wait longer and longer for a "second" to pass.

Best way to exhibit the bug:
Launch Factorio.
Create multiplayer game and set "Max upload speed" to 1
Start the game

Launch a second Factorio instance
Connect to the first Factorio's game by connecting to 127.0.0.1
Watch how initially the downloads occur in 1KB chunks ever 1 seconds, but slowly each "second" becomes longer and longer.

The download will effectively stop at some random amount (ranges from 12KB to 34KB).


Few things of note:
I'm not 100% sure if this is the case BUT, it only happens IF the server is hosting a game where the max upload speed has JUST been set. For me to get it to work "100%" of the time I would have to (in the host instance)
1) load up a game with no download limit.
2) quit that game
3) load up a new game with the download limit

I have not included any log files as they all just end with:
385.780 Info ClientMultiplayerManager.cpp:573: MapTick(4294967295) changing state from(ConnectedWaitingForMap) to(ConnectedDownloadingMap)

It also happens on both Windows an Linux.

Thanks

[Rseding91]

Thanks for the report. It's now fixed for 0.17. I don't recommend using 1 KB/s upload speed as it basically limits the game to uploading to 1 person at a time.

[BenSeidel]

lol, of course, But it makes a debug report easier to write. The original case was 300k/s... 1k isn't dialup speeds!

[BenSeidel]

Sorry, forgot to say thanks.

Thanks!

[zachtac]

I have this issues with 0.16.51 build 36654 win64 steam, cannot get higher than 13kb over lan connection between to computers regardless of who is hosting.

[TruePikachu]

I have this issues with 0.16.51 build 36654 win64 steam, cannot get higher than 13kb over lan connection between to computers regardless of who is hosting.

It's already resolved for 0.17