[0.16.36] Multiplayer Join Failure with No Error Dialog

[416365416c]

I was trying to join a friend's multiplayer game through steam. At that time we did not have factorio.com accounts, just hosted a game from save and unchecked public advertise and unchecked verify identity. The host loaded the game fine, but the player trying to join the game (after right clicking on the steam friends list, clicking 'join game', and clicking through the prompt steam raised about launching with arguments) just saw an empty splash screen. No loading bar, no error message, nothing. The logs are pretty telling though, here's my factorio-current.log:

Code: Select all

 0.000 2018-05-06 16:32:48; Factorio 0.16.36 (build 36253, win64, steam)
   0.000 Operating system: Windows 10 (version 1709) 
   0.000 Program arguments: "B:\SteamLibrary\steamapps\common\Factorio\bin\x64\Factorio.exe" "--join-game-by-id" "4294967295" 
   0.001 Read data path: B:/SteamLibrary/steamapps/common/Factorio/data
   0.001 Write data path: C:/Users/aalpert/AppData/Roaming/Factorio [53919/237672MB]
   0.001 Binaries path: B:/SteamLibrary/steamapps/common/Factorio/bin
   0.005 System info: [CPU: Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz, 8 cores, RAM: 8095/16239 MB, page: 16540/21103 MB, virtual: 232/134217727 MB, extended virtual: 0 MB]
   0.006 Display options: [FullScreen: 1] [VSync: 1] [UIScale: system (100.0%)] [MultiSampling: OFF] [Screen: 255] [Lang: en]
   0.006 Available display adapters: 1
   0.006  [0]: \\.\DISPLAY1 - NVIDIA GeForce GTX 1080 Ti {0x05, [0,0], 3440x1440, 32bit, 60Hz}
   0.007 Create display on adapter 0. Size 1280x720 at position [1070, 342].
   0.115 Initialised Direct3D:[0] NVIDIA GeForce GTX 1080 Ti; driver: nvldumdx.dll 23.21.13.9124
   0.120   Video memory size (dedicated video/dedicated system/shared system/available): 11127/0/8119/4077 MB
   0.153 DSound: Starting _dsound_update thread
   0.153 DSound: Enter _dsound_update; tid=13376
   0.154 Device reset internal.
   0.155 Desktop composition is active.
   0.155 WARNING: You have vsync and desktop composition enabled on Direct3D. Consider disabling vsync to increase performance on some configurations.
   0.155 Graphics settings preset: extreme
   0.155 Graphics options: [Graphics quality: normal] [Video memory usage: all] [Light scale: 100%] [DXT: false] [Shader: 1]
   0.155                   [Parallel sprite loading: 1] [Max texture size: 0/8192] [Bmp cache: 0] [Sprite slicing: 1] [Low quality rotation: 0]
   0.220 Error GlobalModSettings.cpp:107: Failed to migrate mod settings file: Error when opening C:\Users\aalpert\AppData\Roaming\Factorio\mods\mod-settings.json for reading: No such file or directory
   0.221 Loading mod core 0.0.0 (data.lua)
   0.244 Loading mod base 0.16.36 (data.lua)
   0.357 Loading mod base 0.16.36 (data-updates.lua)
   0.418 Checksum for core: 1316978547
   0.418 Checksum of base: 4140083139
   0.513 Loading sounds...
   0.552 Info PlayerData.cpp:67: Local player-data.json unavailable
   0.553 Info PlayerData.cpp:70: Cloud player-data.json available, timestamp 1525649170
   0.647 Loaded shader file B:/SteamLibrary/steamapps/common/Factorio/data/core/graphics/shaders/game.cso
   0.647 Loaded shader file B:/SteamLibrary/steamapps/common/Factorio/data/core/graphics/shaders/zoom-to-world.cso
   0.647 Loaded shader file B:/SteamLibrary/steamapps/common/Factorio/data/core/graphics/shaders/alpha-mask.cso
   0.670 Initial atlas bitmap size is 16384
   0.674 Created atlas bitmap 16384x8428 [none]
   0.871 Created atlas bitmap 16384x2124 [shadow]
   0.922 Created atlas bitmap 16384x682 [decal]
   0.935 Created atlas bitmap 8192x1492 [mipmap]
   0.953 Created atlas bitmap 8192x800 [mipmap, smoke]
   0.962 Created atlas bitmap 8192x2376 [linear-minification, mipmap, terrain]
   0.990 Created atlas bitmap 8192x1036 [no-crop, trilinear-filtering, icon, light]
   1.000 Created atlas bitmap 8192x238 [alpha-mask]
   3.722 Sprites loaded
   3.722 Convert atlas 8192x1492 to: mipmap 
   3.785 Convert atlas 8192x800 to: mipmap 
   3.813 Convert atlas 8192x2376 to: min-linear 
   3.885 Convert atlas 8192x1036 to: trilinear-filtering 
   3.918 Convert atlas 8192x238 to: alpha-mask
   4.707 Custom inputs active: 0
   4.739 Factorio initialised
   4.740 Info Main.cpp:1123: Going to join game 4294967295
   4.740 Info HttpSharedState.cpp:54: Downloading https://multiplayer.factorio.com/get-game-details/4294967295
   5.166 Info HttpSharedState.cpp:145: Status code: 404

Note that the steam dialog said the extra arguments were " --join-game-by-id 4294967295", so my guess is that the steam integration is getting a -1 for the game ID somehow and then not handling it as an error (also using unsigned ints).

[Rseding91]

Thanks for the report. It's now fixed for the next version of 0.16.