[.16] "Recursive technology prerequisites detected." useless

This subforum contains all the issues which we already resolved.
Post Reply
mrvn
Smart Inserter
Smart Inserter
Posts: 3411
Joined: Mon Sep 05, 2016 9:10 am
Contact:

[.16] "Recursive technology prerequisites detected." useless

Post by mrvn » Sat Jan 27, 2018 7:20 am

Some mod here introduces a recursive technology prerequisites. Instead of making that technology loop simply unreachable the game aborts with a basically useless error message listing all technologies.

Here is what is wrong with this:
  • The game is probably still playable. Give the option to simply continue.
  • The error message seems to output all technologies instead of just those involved in the recursion.
  • The error message should highlight the loop, e.g. list prerequisites with + and those in the recursion with #.
  • The error message should indicate the origin of each technology like it does when hovering over an entity.
ps: allowed subjects are too short

Rseding91
Factorio Staff
Factorio Staff
Posts: 9471
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [.16] "Recursive technology prerequisites detected." useless

Post by Rseding91 » Sat Jan 27, 2018 7:29 am

mrvn wrote:The game is probably still playable. Give the option to simply continue.
It's not, it will crash - which is why the check exists.
mrvn wrote:The error message seems to output all technologies instead of just those involved in the recursion.
It doesn't, it includes the technologies in the loop.

I'm all for making the error better but as it is now it simply lists the technologies which when you follow each ones prerequisite will find itself again.
If you want to get ahold of me I'm almost always on Discord.

mrvn
Smart Inserter
Smart Inserter
Posts: 3411
Joined: Mon Sep 05, 2016 9:10 am
Contact:

Re: [.16] "Recursive technology prerequisites detected." useless

Post by mrvn » Mon Jan 29, 2018 9:17 am

Say you have the following:

Code: Select all

#---#---#---#---#---#---#---#---#---#
|       |
#---#---#
[code]

where # denotes a technology. Does it list only the 6 techs in the loop or everything behind the loop too? The list I got is miles long from different tech branches that I can't believe they all are in one giant loop. The mod that causes the problem is AAI Industries, which changes fundamental things like gears. So it's likely a loop at the very base of the tech tree. But having it link a tech way down the tree to one way up is highly unlikely.

I don't have the log accessible at the moment but should the techs be reported in order of the loop?

Oxyd
Factorio Staff
Factorio Staff
Posts: 1243
Joined: Thu May 07, 2015 8:42 am
Contact:

Re: [.16] "Recursive technology prerequisites detected." useless

Post by Oxyd » Mon Jan 29, 2018 1:16 pm

The error message did print a lot of junk not related to the cycle in question, yes. I fixed that for 0.16.21.

mrvn
Smart Inserter
Smart Inserter
Posts: 3411
Joined: Mon Sep 05, 2016 9:10 am
Contact:

Re: [.16] "Recursive technology prerequisites detected." useless

Post by mrvn » Tue Jan 30, 2018 10:29 am

Oxyd wrote:The error message did print a lot of junk not related to the cycle in question, yes. I fixed that for 0.16.21.
Thanks. I will see if that makes this debugable and otherwise attach a log of the actual output.

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: Google [Bot]