[posila][0.16] Artillery shell shadow mismatches turret shadow

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
Mooncat
Smart Inserter
Smart Inserter
Posts: 1165
Joined: Wed May 18, 2016 4:55 pm
Contact:

[posila][0.16] Artillery shell shadow mismatches turret shadow

Post by Mooncat » Mon Dec 18, 2017 2:11 pm

Bug:
The shadow of artillery shell doesn't match the shadow of the artillery turret that shot the shell.

Steps to reproduce:
1) Start a game.
2) Place an artillery turret and give it some artillery shells.
3) (Optional) Slow the game down with /c game.speed = 0.1
4) Use artillery targeting remote to command the artillery turret to shoot.
5) Zoom in and observe the turret.
Artillery Shell Shadow.gif
Artillery Shell Shadow.gif (3.67 MiB) Viewed 1499 times
Artillery Shell Shadow.png
Artillery Shell Shadow.png (97.5 KiB) Viewed 1499 times
Expected:
The shell should be shot from the cannon. :)


By the way, I love the infinity chest. Thanks! :D
My mods (Deprecated, maybe temporary... idk. Currently enjoying vanilla 0.17): Article: List of black magic for modding

orzelek
Smart Inserter
Smart Inserter
Posts: 3574
Joined: Fri Apr 03, 2015 10:20 am
Contact:

Re: [0.16] Artillery shell shadow mismatches turret shadow

Post by orzelek » Mon Dec 18, 2017 8:27 pm

Tbh I would be a bit more concerned that bullet flies like rocket not like artilliery shell :D

posila
Factorio Staff
Factorio Staff
Posts: 3617
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.16] Artillery shell shadow mismatches turret shadow

Post by posila » Mon Dec 18, 2017 8:55 pm

I am concerned about both :)

User avatar
TruePikachu
Filter Inserter
Filter Inserter
Posts: 865
Joined: Sat Apr 09, 2016 8:39 pm
Contact:

Re: [0.16] Artillery shell shadow mismatches turret shadow

Post by TruePikachu » Tue Dec 19, 2017 10:48 pm

My theory as to the cause of this bug is from how the lighting is set up in the render process -- it is configured to act as a point source, which causes distortion on the cast shadow. In effect, the artillery shell and cannon are being lit by two different light sources, which causes their misaligned shadows.

The proper fix to this would involve reconfiguring the entire render setup to use "sun" light sources (parallel beams) instead of "lamp" light sources (radiant beams), followed by ensuring that entity shadows are correctly aligned.

Rseding91
Factorio Staff
Factorio Staff
Posts: 9436
Joined: Wed Jun 11, 2014 5:23 am
Contact:

Re: [0.16] Artillery shell shadow mismatches turret shadow

Post by Rseding91 » Wed Dec 20, 2017 12:13 am

TruePikachu wrote:My theory as to the cause of this bug is from how the lighting is set up in the render process -- it is configured to act as a point source, which causes distortion on the cast shadow. In effect, the artillery shell and cannon are being lit by two different light sources, which causes their misaligned shadows.

The proper fix to this would involve reconfiguring the entire render setup to use "sun" light sources (parallel beams) instead of "lamp" light sources (radiant beams), followed by ensuring that entity shadows are correctly aligned.
It's nothing near that complex. The cannon is one entity and the shell is something else with its own fake height of 3 tiles. It just doesn't line up with the fake height of the cannon because it was never meant to have a visible shell coming out of the cannon but someone thought it would be a good idea to add one last minute :P
If you want to get ahold of me I'm almost always on Discord.

User avatar
Ranakastrasz
Smart Inserter
Smart Inserter
Posts: 1999
Joined: Thu Jun 12, 2014 3:05 am
Contact:

Re: [0.16] Artillery shell shadow mismatches turret shadow

Post by Ranakastrasz » Wed Dec 20, 2017 1:10 am

Also the shell clearly turns like 30.degrees as soom as.it leaves the barrel.
My Mods:
Modular Armor Revamp - V16
Large Chests - V16
Agent Orange - V16
Flare - V16
Easy Refineries - V16

posila
Factorio Staff
Factorio Staff
Posts: 3617
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.16] Artillery shell shadow mismatches turret shadow

Post by posila » Wed Dec 20, 2017 8:05 am

That's what I thought orzelek means by flying like a rocket.

User avatar
Ranakastrasz
Smart Inserter
Smart Inserter
Posts: 1999
Joined: Thu Jun 12, 2014 3:05 am
Contact:

Re: [0.16] Artillery shell shadow mismatches turret shadow

Post by Ranakastrasz » Wed Dec 20, 2017 12:49 pm

posila wrote:That's what I thought orzelek means by flying like a rocket.
I was thinking it was homing like a rocket vs a grenade myself.
My Mods:
Modular Armor Revamp - V16
Large Chests - V16
Agent Orange - V16
Flare - V16
Easy Refineries - V16

orzelek
Smart Inserter
Smart Inserter
Posts: 3574
Joined: Fri Apr 03, 2015 10:20 am
Contact:

Re: [0.16] Artillery shell shadow mismatches turret shadow

Post by orzelek » Wed Dec 20, 2017 8:30 pm

Ranakastrasz wrote:
posila wrote:That's what I thought orzelek means by flying like a rocket.
I was thinking it was homing like a rocket vs a grenade myself.
It's the trajectory.
It's very un-artilliery like. It's more like railgun with the exception that it turns.. thats more like homing missile :D

posila
Factorio Staff
Factorio Staff
Posts: 3617
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [posila][0.16] Artillery shell shadow mismatches turret shadow

Post by posila » Tue Jan 16, 2018 1:03 pm

The shadow will be aligned properly in 0.16.17
I'll look into trajectory of the projectile ... sometime in future :)

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: No registered users