[posila][0.16.4] Offshore pumps can be placed one tile opposite of each other

This subforum contains all the issues which we already resolved.
Post Reply
User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3151
Joined: Tue Jul 12, 2016 9:03 am
Contact:

[posila][0.16.4] Offshore pumps can be placed one tile opposite of each other

Post by eradicator » Sun Dec 17, 2017 10:11 am

Unlike the signal/train stop placement markers the offshore pump placement markers show in every "possible" tile even if a pump can't be placed there due to collision with another pump.
pummmppp.png
pummmppp.png (186.8 KiB) Viewed 5090 times
(The "double" pumpe placement is probably not-a-bug so i'm not reporting that seperately for now.)
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

Zavian
Smart Inserter
Smart Inserter
Posts: 1416
Joined: Thu Mar 02, 2017 2:57 am
Contact:

Re: [0.16.4] Pump placement marker ignores collision boxes

Post by Zavian » Sun Dec 17, 2017 10:17 am

Looking at that picture I actually think the double placement should be a bug, but whichever dev gets this issue can make that call, (and can probably fix both at the same time).

posila
Factorio Staff
Factorio Staff
Posts: 3617
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [0.16.4] Pump placement marker ignores collision boxes

Post by posila » Sun Dec 17, 2017 10:20 am

I am going to flip this and say the offshore pump placement marker won't be changed to check for entity collisions,
but the double placement should be fixed.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3151
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [posila][0.16.4] Offshore pumps can be placed one tile opposite of each other

Post by eradicator » Sun Dec 17, 2017 10:46 am

@posila:
How do the rail signal markers check for "collision" then? They are aware of neighbouring/opposite side signals. I just said "collision" because that was easiest to describe the behavior.
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

posila
Factorio Staff
Factorio Staff
Posts: 3617
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [posila][0.16.4] Offshore pumps can be placed one tile opposite of each other

Post by posila » Sun Dec 17, 2017 11:10 am

Rail signal/Train stop markers are rendered by rail entities, so it has to check only positions around the rail.

Offshore pump markers are rendered with tiles - which means they take advantage terrain buffer and not be rechecked and redrawn every tick. If entity collision checks are done too, it would have to invalidate terrain buffer everytime an entity is built or destroyed, or moved (while you are holding an offshore pump in cursor), which I think is not worth it.
Since these markers are between terrain and entities, I don't see problem with having them also on positions that collide with entities.

User avatar
eradicator
Smart Inserter
Smart Inserter
Posts: 3151
Joined: Tue Jul 12, 2016 9:03 am
Contact:

Re: [posila][0.16.4] Offshore pumps can be placed one tile opposite of each other

Post by eradicator » Sun Dec 17, 2017 11:45 am

@posila

Well. If you say updating the cache in on_build/mined is too expensive (computaionally/development time wise) i guess it can't be helped.

From a mechanic/didactic point of view i still don't like having a visually "noisy" "Hey! Build stuff here!" marker like that in places where you can't actually build stuff though, especially because all the other "green marker" things in game are always positions where you can actually build. The (novice) player doesn't know/care about the technical background of why those two types of "green markers" behave differently.
Author of: Hand Crank Generator, Screenshot Hotkey 2.0
Mod support languages: 日本語, Deutsch, English
My code in the post above is dedicated to the public domain under CC0.

posila
Factorio Staff
Factorio Staff
Posts: 3617
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [posila][0.16.4] Offshore pumps can be placed one tile opposite of each other

Post by posila » Tue Jan 09, 2018 10:24 pm

For 0.16.16 I changed offshore pump collision box from 3x1 to 3x2 so they can't be placed so that they overlap.
Thanks for the report.

User avatar
bobingabout
Smart Inserter
Smart Inserter
Posts: 6723
Joined: Fri May 09, 2014 1:01 pm
Contact:

Re: [posila][0.16.4] Offshore pumps can be placed one tile opposite of each other

Post by bobingabout » Thu Jan 11, 2018 8:51 am

how will this effect pumps in existing savegames?
Creator of Bob's mods. Expanding your gameplay since version 0.9.8.
I also have a Patreon.

posila
Factorio Staff
Factorio Staff
Posts: 3617
Joined: Thu Jun 11, 2015 1:35 pm
Contact:

Re: [posila][0.16.4] Offshore pumps can be placed one tile opposite of each other

Post by posila » Thu Jan 11, 2018 8:56 am

Their collision box will be resized but othewise nothing happens. If a pump collides with something after a migration, it still will be there, will work, but if you remove it you won't be able to place it back.

Post Reply

Return to “Resolved Problems and Bugs”

Who is online

Users browsing this forum: ParkerSelfridge